[GH-ISSUE #1561] fix(setup): reject invalid OMP profiles before fallback configuration writes #526

New issue

Closed

opened 2026-10-15 18:25:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:25:53 +00:00

Owner

Originally created by @N0zoM1z0 on GitHub (Oct 10, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/1561

When OMP_PROFILE or the legacy PI_PROFILE selects an invalid profile, REA silently falls back to the default agent directory. Native OMP refuses to start with the same environment. Setup should report that selection error before planning or writing another profile.

Reproduced on Linux with the official OMP 18.8.7 binary (tag v18.8.7, f261ed9faf16b61880b544f599876bface4ded0d) and REA main 0e19db9f:

Use an isolated PI_CODING_AGENT_DIR with an existing mcp.json.
Set OMP_PROFILE="Bad Name".
omp --print --no-session --no-title Hello exits 1 with Invalid OMP profile "Bad Name".
rea setup --client omp --dry-run --json exits 0 with status: planned, proposing changes to that default agent's mcp.json and the shared skill directory.

Only dry-run was used for the failing REA reproduction; no user configuration was changed. The same resolver also accepts Windows reserved names such as con.txt and com0, which OMP rejects even on Linux.

Expected: preserve OMP_PROFILE precedence (including an explicitly empty/default selection), match native profile validation, report an invalid registration in doctor, and block setup for OMP without affecting unrelated clients. Never use an invalid selection to write a fallback profile.

Related prior configuration support: #1257. Native OMP MCP/skill and actual JavaScript analysis otherwise worked through its default xd:// read/write interface using a loopback model fixture; this report is specifically about profile resolution.

Originally created by @N0zoM1z0 on GitHub (Oct 10, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/1561 When `OMP_PROFILE` or the legacy `PI_PROFILE` selects an invalid profile, REA silently falls back to the default agent directory. Native OMP refuses to start with the same environment. Setup should report that selection error before planning or writing another profile. Reproduced on Linux with the official OMP 18.8.7 binary (tag v18.8.7, f261ed9faf16b61880b544f599876bface4ded0d) and REA main 0e19db9f: 1. Use an isolated `PI_CODING_AGENT_DIR` with an existing `mcp.json`. 2. Set `OMP_PROFILE="Bad Name"`. 3. `omp --print --no-session --no-title Hello` exits 1 with `Invalid OMP profile "Bad Name"`. 4. `rea setup --client omp --dry-run --json` exits 0 with `status: planned`, proposing changes to that default agent's `mcp.json` and the shared skill directory. Only dry-run was used for the failing REA reproduction; no user configuration was changed. The same resolver also accepts Windows reserved names such as `con.txt` and `com0`, which OMP rejects even on Linux. Expected: preserve OMP_PROFILE precedence (including an explicitly empty/default selection), match native profile validation, report an invalid registration in doctor, and block setup for OMP without affecting unrelated clients. Never use an invalid selection to write a fallback profile. Related prior configuration support: #1257. Native OMP MCP/skill and actual JavaScript analysis otherwise worked through its default `xd://` read/write interface using a loopback model fixture; this report is specifically about profile resolution.

bsakaguchi

2026-10-15 18:25:53 +00:00