[PR #2511] [MERGED] fix(ci): ignore generated website translation staging #5286

New issue

Closed

opened 2026-10-31 01:05:27 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:05:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2511
Author: @N0zoM1z0
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/ci-website-translation-staging

📝 Commits (5)

42537ad fix(ci): ignore generated website translation staging
d2a3c60 Merge commit '3ae826ceba' into fix/ci-website-translation-staging
3491ac3 test(ghidra): declare Java minima in positive integration hosts
f806b5c Merge commit '91886982fc' into fix/ci-website-translation-staging
110368b test(ghidra): declare Java minimum for PSP extension host

📊 Changes

8 files changed (+43 additions, -7 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 src/ghidra/GhidraDoctor.test.ts (+3 -1)
📝 src/ghidra/GhidraSnapshotCache.test.ts (+2 -1)
📝 tests/boundary/filesystem/ghidraPspExtension.test.ts (+1 -1)
📝 tests/boundary/filesystem/staticCheckReports.test.ts (+31 -1)
📝 tests/boundary/mcp/ghidraMcpHarness.ts (+1 -1)
📝 tests/boundary/mcp/ghidraReopen.test.ts (+1 -1)
📝 tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts (+2 -1)

📄 Description

Running website translation builds alongside lint can fail the developer gate on copied Electron examples under temporary website/.i18n-*/site directories. Ignore only that generator-owned staging output alongside the final _site/ output. Authored website files remain checked.

The regression uses the real checker, configuration and ignore rules. It fails before the change with two errors, then requires the authored source error, nonzero exit status and complete diagnostic to remain. A production translation build passes lint while staging exists, and the authored Electron example remains in the actual checker inventory.

Validation: static/architecture, documentation/license checks, exact discovery, 20 Python cases, 12 website maintenance regressions and 17 real Wireshark CLI/MCP checks passed. The frozen full local run passed 1,023 files / 10,465 cases (10,370 passed, 95 skipped), all coverage gates, three real Chrome cases and no observed surviving process generations; elapsed 36m54.5s, sampled family RSS 5.02 GiB / PSS 4.92 GiB. These observations are not a paired global performance improvement. Updated-source integration passes 42 files / 674 cases with one named skip; expanded Ghidra integration passes 42 files / 583 cases with one named skip.

Current main 18d56f532 already contains the equivalent Ghidra fixture/admission-drift repair investigated in #2629. The PR’s remaining change against current main is exactly the two staging ignore/regression files; its complete CI head 110368bea contains that same corrected runtime/test tree. Final full remote coverage at 110368bea passed 1,024 files / 10,504 cases: 10,409 passed, 95 skipped, zero failed. All gates pass (lines 89.41%, statements 87.85%, functions 91.32%, branches 79.76%). All 36 selected jobs and the required gate passed. Windows passed one targeted rerun after its pre-existing webModuleCli 15-second deadline; no source/timeout/configured-retry changes were made, and the original failure remains documented. No production runtime, lint rule, coverage threshold, retry or concurrency setting changes.

Fixes #2508

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2511 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/ci-website-translation-staging` --- ### 📝 Commits (5) - [`42537ad`](https://github.com/morluto/rea/commit/42537ad073ba4614eef14d4ada96df2fa90e66af) fix(ci): ignore generated website translation staging - [`d2a3c60`](https://github.com/morluto/rea/commit/d2a3c602397c91ae071842f6e7df7af75a476fa8) Merge commit '3ae826ceba6f25b08bce50bcb51001209bc16b57' into fix/ci-website-translation-staging - [`3491ac3`](https://github.com/morluto/rea/commit/3491ac3ef8d87446b6f6fec5a431c14d46fb8080) test(ghidra): declare Java minima in positive integration hosts - [`f806b5c`](https://github.com/morluto/rea/commit/f806b5c791dc40ecdc2ad4492fd9bf91f71f4e19) Merge commit '91886982fccc50a9f7f31d4f320b25ffbcff35af' into fix/ci-website-translation-staging - [`110368b`](https://github.com/morluto/rea/commit/110368beadb2aed91901da5f177e898f454f927d) test(ghidra): declare Java minimum for PSP extension host ### 📊 Changes **8 files changed** (+43 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `src/ghidra/GhidraDoctor.test.ts` (+3 -1) 📝 `src/ghidra/GhidraSnapshotCache.test.ts` (+2 -1) 📝 `tests/boundary/filesystem/ghidraPspExtension.test.ts` (+1 -1) 📝 `tests/boundary/filesystem/staticCheckReports.test.ts` (+31 -1) 📝 `tests/boundary/mcp/ghidraMcpHarness.ts` (+1 -1) 📝 `tests/boundary/mcp/ghidraReopen.test.ts` (+1 -1) 📝 `tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts` (+2 -1) </details> ### 📄 Description Running website translation builds alongside lint can fail the developer gate on copied Electron examples under temporary `website/.i18n-*/site` directories. Ignore only that generator-owned staging output alongside the final `_site/` output. Authored website files remain checked. The regression uses the real checker, configuration and ignore rules. It fails before the change with two errors, then requires the authored source error, nonzero exit status and complete diagnostic to remain. A production translation build passes lint while staging exists, and the authored Electron example remains in the actual checker inventory. Validation: static/architecture, documentation/license checks, exact discovery, 20 Python cases, 12 website maintenance regressions and 17 real Wireshark CLI/MCP checks passed. The frozen full local run passed 1,023 files / 10,465 cases (10,370 passed, 95 skipped), all coverage gates, three real Chrome cases and no observed surviving process generations; elapsed 36m54.5s, sampled family RSS 5.02 GiB / PSS 4.92 GiB. These observations are not a paired global performance improvement. Updated-source integration passes 42 files / 674 cases with one named skip; expanded Ghidra integration passes 42 files / 583 cases with one named skip. Current main `18d56f532` already contains the equivalent Ghidra fixture/admission-drift repair investigated in #2629. The PR’s remaining change against current main is exactly the two staging ignore/regression files; its complete CI head `110368bea` contains that same corrected runtime/test tree. Final full remote coverage at `110368bea` passed 1,024 files / 10,504 cases: 10,409 passed, 95 skipped, zero failed. All gates pass (lines 89.41%, statements 87.85%, functions 91.32%, branches 79.76%). All 36 selected jobs and the required gate passed. Windows passed one targeted rerun after its pre-existing webModuleCli 15-second deadline; no source/timeout/configured-retry changes were made, and the original failure remains documented. No production runtime, lint rule, coverage threshold, retry or concurrency setting changes. Fixes #2508 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:05:27 +00:00