morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #2633] [CLOSED] test(ghidra): declare the Java minimum in boundary installation fixtures #5294

New issue

Closed

opened 2026-10-31 01:05:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:05:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2633
Author: @kaoru0822-kitauji
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: test/ghidra-java-min-fixtures

📝 Commits (1)

4964383 test(ghidra): declare the Java minimum in boundary installation fixtures

📊 Changes

6 files changed (+10 additions, -6 deletions)

View changed files

📝 src/ghidra/GhidraDoctor.test.ts (+3 -1)
📝 src/ghidra/GhidraSnapshotCache.test.ts (+2 -1)
📝 tests/boundary/filesystem/ghidraPspExtension.test.ts (+1 -1)
📝 tests/boundary/mcp/ghidraMcpHarness.ts (+1 -1)
📝 tests/boundary/mcp/ghidraReopen.test.ts (+1 -1)
📝 tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts (+2 -1)

📄 Description

Problem

Main CI has been red since 2187e16f1 (fix(ghidra): derive installation admission from Java property semantics). Every PR's merge build shows the same failures:

Static checks: format:check reports src/ghidra/GhidraDoctor.test.ts and src/ghidra/GhidraSnapshotCache.test.ts. Both are reformatted lines from that commit.
Test shards: 2187e16f1 made admission require application.java.min from application.properties. It updated the unit-test fixtures, but these boundary fixtures still declare only application.version:
- tests/boundary/mcp/ghidraMcpHarness.ts, used by 9 MCP suites
- tests/boundary/mcp/ghidraReopen.test.ts
- tests/boundary/filesystem/ghidraPspExtension.test.ts
- tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts
Their providers now resolve as unavailable (Provider ghidra adapter failed during resolve_analysis_profile). That fails 43 tests in 11 boundary files, for example ghidraJavaLaunch.test.ts > Ghidra startup interruption diagnostics > preserves helper warnings through the provider-neutral cancelled projection.

Fix

Add application.java.min=21 to the four remaining fixtures, matching the unit fixtures in 2187e16f1.
Run oxfmt on the two unit tests.

Only test files change.

Validation

npm run test:focused over the 11 affected boundary files plus the two unit tests (13 files):

	result
`origin/main` (`91886982f`)	43 failed, 54 passed
this branch	97 passed

npm run format:check is clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Updated Ghidra test fixtures to specify Java 21 as the minimum supported version, consistent with their Java version probes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2633 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/ghidra-java-min-fixtures` --- ### 📝 Commits (1) - [`4964383`](https://github.com/morluto/rea/commit/4964383491d9fef06ab8ad4f69520558697ad73b) test(ghidra): declare the Java minimum in boundary installation fixtures ### 📊 Changes **6 files changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/ghidra/GhidraDoctor.test.ts` (+3 -1) 📝 `src/ghidra/GhidraSnapshotCache.test.ts` (+2 -1) 📝 `tests/boundary/filesystem/ghidraPspExtension.test.ts` (+1 -1) 📝 `tests/boundary/mcp/ghidraMcpHarness.ts` (+1 -1) 📝 `tests/boundary/mcp/ghidraReopen.test.ts` (+1 -1) 📝 `tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts` (+2 -1) </details> ### 📄 Description ## Problem Main CI has been red since 2187e16f1 (`fix(ghidra): derive installation admission from Java property semantics`). Every PR's merge build shows the same failures: - **Static checks:** `format:check` reports `src/ghidra/GhidraDoctor.test.ts` and `src/ghidra/GhidraSnapshotCache.test.ts`. Both are reformatted lines from that commit. - **Test shards:** 2187e16f1 made admission require `application.java.min` from `application.properties`. It updated the unit-test fixtures, but these boundary fixtures still declare only `application.version`: - `tests/boundary/mcp/ghidraMcpHarness.ts`, used by 9 MCP suites - `tests/boundary/mcp/ghidraReopen.test.ts` - `tests/boundary/filesystem/ghidraPspExtension.test.ts` - `tests/boundary/providers/ghidra/ghidraJavaLaunch.test.ts` Their providers now resolve as unavailable (`Provider ghidra adapter failed during resolve_analysis_profile`). That fails 43 tests in 11 boundary files, for example `ghidraJavaLaunch.test.ts > Ghidra startup interruption diagnostics > preserves helper warnings through the provider-neutral cancelled projection`. ## Fix - Add `application.java.min=21` to the four remaining fixtures, matching the unit fixtures in 2187e16f1. - Run `oxfmt` on the two unit tests. Only test files change. ## Validation `npm run test:focused` over the 11 affected boundary files plus the two unit tests (13 files): | | result | | --- | --- | | `origin/main` (91886982f) | 43 failed, 54 passed | | this branch | 97 passed | `npm run format:check` is clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)  ## Summary by CodeRabbit * **Tests** * Updated Ghidra test fixtures to specify Java 21 as the minimum supported version, consistent with their Java version probes.  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:05:31 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:43:40 +00:00

[PR #5301] [CLOSED] fix(sqlite): bind returned cleanup errors to their exact root and worker owners #6867

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5294

No description provided.

Rows
Columns