morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #2719] [CLOSED] test(javascript): expect unknown provenance for a shadowing parameter #5342

New issue

Closed

opened 2026-10-31 01:05:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:05:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2719
Author: @kaoru0822-kitauji
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: test/js-parameter-provenance-expectation

📝 Commits (2)

fd76852 test(javascript): expect unknown provenance for a shadowing parameter
7f34865 test(javascript): describe the parameter's provenance without claiming shadowing

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticAnalysis.structure.test.ts (+4 -2)

📄 Description

Problem

src/domain/javascript/javascriptSemanticAnalysis.structure.test.ts > resolves imports, require destructuring, aliases, assignments, and shadowing fails on main (reproduced locally at c02fb0ea8). It also fails the domain test shard of every open PR, e.g. #2683 and #2690:

- "reason": null,
- "status": "local",
+ "reason": "Parameter provenance depends on caller arguments.",
+ "status": "unknown",

Cause

c7a890d12 (fix(javascript): preserve unknown module-alias provenance) intentionally removed the implicit local-provenance fallback: parameters, opaque results and caught values now stay unknown. This older structure test still expected the shadowing ipcRenderer parameter of function local(ipcRenderer) to be local.

Fix

Update the expectation to the documented parameter provenance. The test still checks what it is for: the parameter has no origins, so it does not inherit the electron ipcRenderer alias it shadows, and its reference resolves to the parameter binding.

Validation

All 63 JavaScript domain/application unit test files: only this test failed on main. With the fix, the file passes (24/24).
npm run check:fast passes.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2719 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/js-parameter-provenance-expectation` --- ### 📝 Commits (2) - [`fd76852`](https://github.com/morluto/rea/commit/fd768524d87c188087fcc67cc6a54025b343f905) test(javascript): expect unknown provenance for a shadowing parameter - [`7f34865`](https://github.com/morluto/rea/commit/7f348657e60ad72c14bafd03c74fc49868b4ed5c) test(javascript): describe the parameter's provenance without claiming shadowing ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticAnalysis.structure.test.ts` (+4 -2) </details> ### 📄 Description ## Problem `src/domain/javascript/javascriptSemanticAnalysis.structure.test.ts > resolves imports, require destructuring, aliases, assignments, and shadowing` fails on `main` (reproduced locally at c02fb0ea8). It also fails the domain test shard of every open PR, e.g. #2683 and #2690: ``` - "reason": null, - "status": "local", + "reason": "Parameter provenance depends on caller arguments.", + "status": "unknown", ``` ## Cause c7a890d12 (`fix(javascript): preserve unknown module-alias provenance`) intentionally removed the implicit local-provenance fallback: parameters, opaque results and caught values now stay `unknown`. This older structure test still expected the shadowing `ipcRenderer` parameter of `function local(ipcRenderer)` to be `local`. ## Fix Update the expectation to the documented parameter provenance. The test still checks what it is for: the parameter has no origins, so it does not inherit the `electron` `ipcRenderer` alias it shadows, and its reference resolves to the parameter binding. ## Validation - All 63 JavaScript domain/application unit test files: only this test failed on main. With the fix, the file passes (24/24). - `npm run check:fast` passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:05:53 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:44:06 +00:00

[PR #5425] [MERGED] fix(ghidra): treat format-specific disabled analyzers as not applicable #6926

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5342

No description provided.

Rows
Columns