mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 01:05:58 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5353
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/2736
Author: @0xLLVEL
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/25/2026
Merged by: @morluto
Base:
main← Head:feat/add-freebuff-agent-support📝 Commits (10+)
4799644feat: add FreeBuff agent support for REA setup783f0fefix(freebuff): detect FreeBuff from its profile directory, not shared .agents6092f6dfix(setup): require product evidence for FreeBuff discovery19271a4fix(uninstall): retain unverified shared client configuration871757efix(clients): preserve scoped removal evidencee27c32efix(doctor): omit undefined selectedClientIds under exactOptionalPropertyTypes93d7d83fix(update): separate ownership evidence from product applicabilityb3cde64test(dotnet): split oversized operand extent diagnostics describeb4ce737fix(update): preserve ZCode's disabled shared registration during maintenance9862ad1fix(doctor): let explicit client selection authorize the config read📊 Changes
133 files changed (+2098 additions, -389 deletions)
View changed files
📝
.agents/skills/reverse-engineer-anything/references/connection-and-recovery.md(+1 -1)📝
docs/client-configuration.md(+22 -0)📝
docs/client-verification.md(+5 -0)📝
docs/installation.md(+3 -0)📝
src/adb/AdbProvider.ts(+3 -5)📝
src/apktool/ApktoolProvider.ts(+3 -5)📝
src/application/BinaryTargetResolver.ts(+6 -6)📝
src/application/BrowserObservationService.test.ts(+5 -3)📝
src/application/ClientRegistration.ts(+17 -0)📝
src/application/ClientRegistrationStatus.ts(+62 -8)📝
src/application/DirectAnalysis.ts(+4 -2)📝
src/application/Doctor.ts(+6 -3)📝
src/application/EnhancedTools.objcClasses.test.ts(+1 -1)📝
src/application/Setup.fixture.ts(+1 -2)📝
src/application/SetupHost.ts(+6 -2)📝
src/application/SupportedClients.ts(+99 -9)📝
src/application/Uninstall.ts(+366 -73)📝
src/application/UpdateMaintenance.ts(+12 -0)📝
src/application/analysisView/AnalysisViewService.test.ts(+3 -5)📝
src/application/android/AndroidAnalysisPort.ts(+1 -1)...and 80 more files
📄 Description
Register FreeBuff Desktop as a supported setup client. FreeBuff loads MCP servers from
~/.agents/mcp.json(mcpServers) and personal skills from~/.agents/skills, so its registration shares storage with ZCode's user-scope fallback.Summary
Closes #3243.
Problem and expected behavior
FreeBuff Desktop was missing from the supported-client inventory, so
rea setup,rea doctor,rea uninstall, andrea updateignored it: there was no supported way to register REA for FreeBuff, and no way to detect, repair, or remove that registration.The shared storage is what makes the naive version wrong.
~/.agents/mcp.jsonis also created by REA's own skill installs and is ZCode's user-scope fallback, so its existence cannot prove that FreeBuff is installed. Treating it as FreeBuff's config unconditionally would add a phantom client torea doctor, letrea setup --all-detectedwrite it, and let uninstall act on another product's file.Change and scope
freebuffclient definition:~/.agents/mcp.jsonfor the server entry,~/.agents/skillsfor the personal skill, and~/.config/freebuff-desktopas the product-specific discovery and marker path.clientEvidencePathsprefers a client'sdiscoveryPaths, so shared storage never proves a product is installed; newclientOwnershipEvidencePathsandclientSharedRegistrationPathsdescribe storage a client shares with another product.~/.agents/mcp.jsonresolves to its owner (FreeBuff) and is inspected and edited once; ZCode's fallback view reports that same removal instead of finding the row already absent. Two clients that each declare the same path as their own configuration (OpenCode pointed at FreeBuff's file throughOPENCODE_CONFIG) write different tables, so each keeps its own removal. A discovery path that is a dangling link is no longer installation evidence, matching setup and doctor, so a leftover profile link cannot turn an unrelated shared file into a blocking failure.enable: falserather than silently re-enabling a row it does not own, and doctor reports that preserved disable as a manual conflict instead of pointing at a setup run that cannot repair it.selectedClientIdsis threaded through doctor and the registration status path, so an explicit--client freebuffis honored without a profile marker.client-verificationnote that FreeBuff loading is unverified with an installed client.Not included: no change to FreeBuff itself, to the MCP transport, or to provider behavior.
Contract and boundary impact
src/application/SupportedClients.tsowns the client inventory and its applicability/ownership paths; the earliest changed stage is setup, doctor, and uninstall discovery.rea setup --client freebuffandrea doctor --client freebuffare accepted;--all-detectedselects FreeBuff only with product-specific evidence; uninstall retains unverified shared storage instead of failing globally.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
tests/boundary/filesystem/freebuffClientConfiguration.test.ts(new),clientLifecycle.test.ts,setupClientConfigCleanupOwnership.test.ts,clientRegistrationStatus.test.ts,zcodeClientConfiguration.test.ts,tests/process-global/updateMaintenance.test.ts.upstream/main. The new file exercises the shared-storage boundaries directly (phantom detection, unverified applicability, owned-row removal, unresolved probes); running it on main is not possible without the client definition it covers.rea setup --client freebuffwritesmcpServers.reainto~/.agents/mcp.json;rea doctorreports FreeBuff only when~/.config/freebuff-desktopexists.docs/client-verification.mdrecords that. The original validation below ran on Windows x64; the merge-resolution validation below adds macOS coverage.For evidence-bearing changes:
Validation performed
Latest review fixes (macOS arm64, Node.js v24.22.1, npm 11.16.0):
npm run check:fast— pass. Seven focused lifecycle, registration, cleanup, FreeBuff/ZCode, and maintenance files — 217 passed; the final two changed test files were rerun — 50 passed.Latest merge-resolution validation (macOS arm64, Node.js v24.22.1, npm 11.16.0), merging
mainat4ed33efb0:enable: falsepreservation rule into main's current registration writer and reused it for doctor remediation. Kept main's client-specific activation rules, configuration-error details, and skill-discovery results.npm run check:fast— pass.npm run test:focusedover FreeBuff/ZCode configuration, cleanup ownership, client lifecycle, registration status/ownership, and update maintenance — 214 passed across 7 files.npm run docs:check— pass.Earlier branch validation:
On
0d776df76(merge ofupstream/mainat2c3dd946d), Windows x64, Node.js v26.12.0:npm run check:fast(typecheck + lint) — 2 tasks, 0 errorsnpm run format:check— 4,999 files, cleannpm run test:focusedoversetupClientConfigCleanupOwnership(32),freebuffClientConfiguration(15),zcodeClientConfiguration(27 passed, 1 skipped) — green. The four new uninstall regressions (one shared removal reported to both clients, per-client rows when OpenCode owns the same file, a dangling profile link, and the unresolved-probe fail-closed case) all fail on the pre-fix source and pass here.clientLifecycle+clientRegistrationStatus— 77 passed, 4 skipped, 9 failed. The same 9 tests fail on the unmodified merge commit in this worktree: five cannot create symlinks (EPERM: operation not permitted, symlink) on this Windows account, and four path-sensitive assertions compare POSIX-style paths. Host failures, not regressions.npm run docs:check— passCompatibility, safety, and release
sharedRegistration.freebuffships with the first release containing this PR and is absent from published packages until then, as noted indocs/client-configuration.md.Author readiness
Human owner: @0xLLVEL
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.