[PR #2741] [CLOSED] test(ci): admit reusable-workflow jobs in the release preflight check #5356

New issue

Closed

opened 2026-10-31 01:06:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2741
Author: @kaoru0822-kitauji
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: test/release-preflight-reusable-jobs

📝 Commits (1)

c0cc777 test(ci): admit reusable-workflow jobs in the release preflight check

📊 Changes

1 file changed (+10 additions, -7 deletions)

View changed files

📝 tests/boundary/filesystem/releaseCheckpoint.test.ts (+10 -7)

📄 Description

Problem

tests/boundary/filesystem/releaseCheckpoint.test.ts fails on main at d13c9f840 (reproduced locally). It also fails the boundary shard of open PRs, e.g. #2690 and #2720. All four the actual $job preflight admits the next action only for valid metadata cases fail:

ZodError: expected array, received undefined at jobs.qualification.steps

Cause

d13c9f840 (ci: reduce redundant compatibility and qualification work) turned the release workflow's qualification job into a reusable-workflow call (uses:), so it has no steps. The test parses .github/workflows/release.yml with a schema that requires steps on every job, although it only reads the steps of release-please and merged-release.

Fix

Make steps optional per job in the test's workflow schema and look up steps with ?.. If either inspected job loses its validation step, the test still fails: the z.string().parse(...) of the step's run rejects undefined.

Validation

releaseCheckpoint.test.ts: 39 passed (4 failed on main).
The other workflow-parsing suites (ciRequiredLanes, releaseWorkflow, ciTestReports, ciChangeScope, ciQualification, realGhidraWindowsWorkflow) already pass on main: 175 passed.
npm run check:fast passes.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2741 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/release-preflight-reusable-jobs` --- ### 📝 Commits (1) - [`c0cc777`](https://github.com/morluto/rea/commit/c0cc77766ec8dcc4bbf6445760a7133d6fe901ea) test(ci): admit reusable-workflow jobs in the release preflight check ### 📊 Changes **1 file changed** (+10 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/filesystem/releaseCheckpoint.test.ts` (+10 -7) </details> ### 📄 Description ## Problem `tests/boundary/filesystem/releaseCheckpoint.test.ts` fails on `main` at d13c9f840 (reproduced locally). It also fails the boundary shard of open PRs, e.g. #2690 and #2720. All four `the actual $job preflight admits the next action only for valid metadata` cases fail: ``` ZodError: expected array, received undefined at jobs.qualification.steps ``` ## Cause d13c9f840 (`ci: reduce redundant compatibility and qualification work`) turned the release workflow's `qualification` job into a reusable-workflow call (`uses:`), so it has no `steps`. The test parses `.github/workflows/release.yml` with a schema that requires `steps` on every job, although it only reads the steps of `release-please` and `merged-release`. ## Fix Make `steps` optional per job in the test's workflow schema and look up steps with `?.`. If either inspected job loses its validation step, the test still fails: the `z.string().parse(...)` of the step's `run` rejects `undefined`. ## Validation - `releaseCheckpoint.test.ts`: 39 passed (4 failed on main). - The other workflow-parsing suites (`ciRequiredLanes`, `releaseWorkflow`, `ciTestReports`, `ciChangeScope`, `ciQualification`, `realGhidraWindowsWorkflow`) already pass on main: 175 passed. - `npm run check:fast` passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:00 +00:00