[PR #2748] [MERGED] fix(javascript): keep spread child argv counts unknown #5362

New issue

Closed

opened 2026-10-31 01:06:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2748
Author: @xu91102
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/child-process-spread-argv

📝 Commits (4)

02724d4 fix(javascript): keep spread child argv counts unknown
e92e547 test(javascript): own runtime controls and tighten evidence assertions
f3a70c7 test(apple): keep dyld slice regression portable
1057fc2 chore: merge upstream CI baseline fixes

📊 Changes

2 files changed (+76 additions, -1 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticChildProcesses.ts (+4 -1)
➕ tests/acceptance/applications/javascriptChildProcessArgumentsCli.test.ts (+72 -0)

📄 Description

A spread element in a spawn argument array does not establish the expanded argument count. REA previously published the syntactic element count as resolved evidence. Preserve an unknown count for spread arrays while retaining exact counts for fixed and empty arrays. Real Node controls and public CLI/MCP assert expanded behavior and prevent false resolved supplies-argv claims.

Fixes #2746

Validation on 1057fc251a89a678758b86e15a63b56e7cdd59fb:

7 relevant files / 157 tests passed, including real public CLI/MCP, Node controls and producer regressions.
npm run check and npm run verify:test-discovery passed (1057 files discovered once).
Local self-review: Standards PASS / Spec PASS.
Upstream main's release-preflight and portable x64 Mach-O fixture fixes are integrated; there is no duplicate fixture contribution in this PR.

CI for this final merge commit is pending. Local checks run on macOS arm64; their source-analysis controls do not claim a Linux run or an installed Electron application's execution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2748 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/child-process-spread-argv` --- ### 📝 Commits (4) - [`02724d4`](https://github.com/morluto/rea/commit/02724d4704cb8ba527388c4a1cba9ecc9aec0bea) fix(javascript): keep spread child argv counts unknown - [`e92e547`](https://github.com/morluto/rea/commit/e92e547d07c0150c034494e22502342ecd598bc2) test(javascript): own runtime controls and tighten evidence assertions - [`f3a70c7`](https://github.com/morluto/rea/commit/f3a70c73a2c879010e25513b616c2bff1b92b11c) test(apple): keep dyld slice regression portable - [`1057fc2`](https://github.com/morluto/rea/commit/1057fc251a89a678758b86e15a63b56e7cdd59fb) chore: merge upstream CI baseline fixes ### 📊 Changes **2 files changed** (+76 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticChildProcesses.ts` (+4 -1) ➕ `tests/acceptance/applications/javascriptChildProcessArgumentsCli.test.ts` (+72 -0) </details> ### 📄 Description A spread element in a spawn argument array does not establish the expanded argument count. REA previously published the syntactic element count as resolved evidence. Preserve an unknown count for spread arrays while retaining exact counts for fixed and empty arrays. Real Node controls and public CLI/MCP assert expanded behavior and prevent false resolved supplies-argv claims. Fixes #2746 Validation on `1057fc251a89a678758b86e15a63b56e7cdd59fb`: - 7 relevant files / 157 tests passed, including real public CLI/MCP, Node controls and producer regressions. - `npm run check` and `npm run verify:test-discovery` passed (1057 files discovered once). - Local self-review: Standards PASS / Spec PASS. - Upstream main's release-preflight and portable x64 Mach-O fixture fixes are integrated; there is no duplicate fixture contribution in this PR. CI for this final merge commit is pending. Local checks run on macOS arm64; their source-analysis controls do not claim a Linux run or an installed Electron application's execution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:03 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:43:54 +00:00

[PR #5363] [MERGED] fix(apple): preserve line terminators in dyld path expansion #6895

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5362

No description provided.

Rows
Columns