[PR #2749] [CLOSED] fix(javascript): retain child-process options when argv is omitted #5363

New issue

Closed

opened 2026-10-31 01:06:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2749
Author: @xu91102
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/child-process-options-overloads

📝 Commits (5)

f746324 fix(javascript): retain child-process options when argv is omitted
6b0c6d8 test(javascript): own runtime controls and tighten evidence assertions
6d5d975 test(apple): keep dyld slice regression portable
2370a9a chore: merge upstream CI baseline fixes
dc26ab7 fix(process): report no remaining time after a provider deadline fires

📊 Changes

4 files changed (+102 additions, -2 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticChildProcesses.ts (+5 -2)
📝 src/process/ProviderDeadline.test.ts (+17 -0)
📝 src/process/ProviderDeadline.ts (+3 -0)
➕ tests/acceptance/applications/javascriptChildProcessOptionsCli.test.ts (+77 -0)

📄 Description

Valid spawn, execFile, and fork calls can pass their options object as the second argument when argv is omitted. REA previously discarded the environment and stdio configuration in these overloads. Decode the options position once in the shared producer while preserving explicit argv/third-options forms and omitted defaults. Public CLI/MCP verify configuration evidence; actual Node children confirm the options-only environment behavior.

Fixes #2571

Validation on dc26ab7148f89ac8f1da73abfb9ea53e9d827ff8:

11 relevant files / 215 tests passed, including real public CLI/MCP, Node controls and producer regressions.
npm run check and npm run verify:test-discovery passed (1057 files discovered once).
Local self-review of the contribution and independent review of the maintainer update: Standards PASS / Spec PASS.
Upstream main's release-preflight and portable x64 Mach-O fixture fixes are integrated; there is no duplicate fixture contribution in this PR.
The maintainer integrated the timeout-state consistency correction from #2720. Fresh validation includes ProviderDeadline, ProviderProcessOutput, GhidraProvider and HopperProvider adapter suites. Cancellation and owned timer cleanup remain covered. This resolves the observed remaining-budget assertion locally; the deeper early-timer behavior tracked by #2760 / #2793 remains outside this correction.

CI for this latest commit is pending. Local checks run on macOS arm64; their source-analysis controls do not claim a Linux run or an installed Electron application's execution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2749 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/child-process-options-overloads` --- ### 📝 Commits (5) - [`f746324`](https://github.com/morluto/rea/commit/f746324538de4420b32685703773d5f2f8109506) fix(javascript): retain child-process options when argv is omitted - [`6b0c6d8`](https://github.com/morluto/rea/commit/6b0c6d8e57c0c63bd5c941fa8a79f7f98adbd2ed) test(javascript): own runtime controls and tighten evidence assertions - [`6d5d975`](https://github.com/morluto/rea/commit/6d5d9756178d1458f7a00a91a73380369f23e9f1) test(apple): keep dyld slice regression portable - [`2370a9a`](https://github.com/morluto/rea/commit/2370a9aa61a2f8502409e318438fd2cf25190d4b) chore: merge upstream CI baseline fixes - [`dc26ab7`](https://github.com/morluto/rea/commit/dc26ab7148f89ac8f1da73abfb9ea53e9d827ff8) fix(process): report no remaining time after a provider deadline fires ### 📊 Changes **4 files changed** (+102 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticChildProcesses.ts` (+5 -2) 📝 `src/process/ProviderDeadline.test.ts` (+17 -0) 📝 `src/process/ProviderDeadline.ts` (+3 -0) ➕ `tests/acceptance/applications/javascriptChildProcessOptionsCli.test.ts` (+77 -0) </details> ### 📄 Description Valid spawn, execFile, and fork calls can pass their options object as the second argument when argv is omitted. REA previously discarded the environment and stdio configuration in these overloads. Decode the options position once in the shared producer while preserving explicit argv/third-options forms and omitted defaults. Public CLI/MCP verify configuration evidence; actual Node children confirm the options-only environment behavior. Fixes #2571 Validation on `dc26ab7148f89ac8f1da73abfb9ea53e9d827ff8`: - 11 relevant files / 215 tests passed, including real public CLI/MCP, Node controls and producer regressions. - `npm run check` and `npm run verify:test-discovery` passed (1057 files discovered once). - Local self-review of the contribution and independent review of the maintainer update: Standards PASS / Spec PASS. - Upstream main's release-preflight and portable x64 Mach-O fixture fixes are integrated; there is no duplicate fixture contribution in this PR. - The maintainer integrated the timeout-state consistency correction from #2720. Fresh validation includes ProviderDeadline, ProviderProcessOutput, GhidraProvider and HopperProvider adapter suites. Cancellation and owned timer cleanup remain covered. This resolves the observed remaining-budget assertion locally; the deeper early-timer behavior tracked by #2760 / #2793 remains outside this correction. CI for this latest commit is pending. Local checks run on macOS arm64; their source-analysis controls do not claim a Linux run or an installed Electron application's execution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:03 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:43:54 +00:00

[PR #5363] [MERGED] fix(apple): preserve line terminators in dyld path expansion #6895

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5363

No description provided.

Rows
Columns