[PR #2766] [MERGED] fix(javascript): ignore erased TypeScript names in native-addon requests #5375

New issue

Closed

opened 2026-10-31 01:06:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2766
Author: @BeqaKs
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/js-ts-type-only-native-bindings

📝 Commits (4)

e8867b6 fix(javascript): ignore erased TypeScript names in native-addon requests
2f98ac3 test(javascript): cover erased TypeScript re-export forms
afa6931 test(javascript): allow Inspector observation events to arrive
bb2970a test(inspector): emit events before enable responses

📊 Changes

4 files changed (+186 additions, -6 deletions)

View changed files

➕ src/application/javascript/nativeTypeBindings.test.ts (+98 -0)
📝 src/domain/javascript/electronNativeLoaderPaths.test.ts (+61 -0)
📝 src/domain/javascript/electronStaticAnalysisNative.ts (+26 -5)
📝 tests/fixtures/inspector/fakeV8Inspector.ts (+1 -1)

📄 Description

Summary

Stop import type / export type (and mixed type members) from becoming JavaScript-requested native-addon bindings.
Keep ordinary value imports and the value half of mixed imports unchanged.
Regression coverage at the static analyzer and application-service / handoff boundaries.

Fixes #2667

Test plan

npm run test:focused -- src/domain/javascript/electronNativeLoaderPaths.test.ts src/application/javascript/nativeTypeBindings.test.ts
npm run check:fast

Made with Cursor

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2766 **Author:** [@BeqaKs](https://github.com/BeqaKs) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/js-ts-type-only-native-bindings` --- ### 📝 Commits (4) - [`e8867b6`](https://github.com/morluto/rea/commit/e8867b6abbb8df9e81a0db5a812b1966f99b6044) fix(javascript): ignore erased TypeScript names in native-addon requests - [`2f98ac3`](https://github.com/morluto/rea/commit/2f98ac329c517255a04e601e7203b61e324451ea) test(javascript): cover erased TypeScript re-export forms - [`afa6931`](https://github.com/morluto/rea/commit/afa6931e40eb65247002b8ecfe35868f53a944b3) test(javascript): allow Inspector observation events to arrive - [`bb2970a`](https://github.com/morluto/rea/commit/bb2970a88341c14657f914bef468a45e99255ced) test(inspector): emit events before enable responses ### 📊 Changes **4 files changed** (+186 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `src/application/javascript/nativeTypeBindings.test.ts` (+98 -0) 📝 `src/domain/javascript/electronNativeLoaderPaths.test.ts` (+61 -0) 📝 `src/domain/javascript/electronStaticAnalysisNative.ts` (+26 -5) 📝 `tests/fixtures/inspector/fakeV8Inspector.ts` (+1 -1) </details> ### 📄 Description ## Summary - Stop `import type` / `export type` (and mixed `type` members) from becoming JavaScript-requested native-addon bindings. - Keep ordinary value imports and the value half of mixed imports unchanged. - Regression coverage at the static analyzer and application-service / handoff boundaries. Fixes #2667 ## Test plan - [x] `npm run test:focused -- src/domain/javascript/electronNativeLoaderPaths.test.ts src/application/javascript/nativeTypeBindings.test.ts` - [x] `npm run check:fast` Made with [Cursor](https://cursor.com) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:08 +00:00