[PR #2803] [CLOSED] fix(javascript): retain unpaired return locations with empty opposite exports #5408

New issue

Closed

opened 2026-10-31 01:06:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:06:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2803
Author: @chqcjq
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/export-unpaired-return-locations

📝 Commits (10+)

bb0a8b9 fix(javascript): retain unpaired return locations with empty opposite exports
1255253 chore: merge captured main into PR 2803
1718f6b fix(comparison): recheck historical calls-only changes (#2223)
c9c7492 fix(ci): isolate Linux Hopper process fixture inventory
81adbd7 fix(android): make DEX descriptor pattern portable
a4fabf6 style: format comparison and IDA sources
89315f1 Merge commit '8fef2aa64e' into HEAD
aeaac75 Merge branch 'main' into fix/export-unpaired-return-locations
ded84e7 Merge branch 'main' into fix/export-unpaired-return-locations
1b79f56 Merge remote-tracking branch 'origin/main' into fix/export-unpaired-return-locations

📊 Changes

2 files changed (+138 additions, -11 deletions)

View changed files

📝 src/domain/javascript/javascriptExportShapeVariants.ts (+5 -11)
➕ tests/acceptance/applications/unpairedExportReturnsCli.test.ts (+133 -0)

📄 Description

Summary

Follow-up to #2659. The core fix was integrated into main by b58adafa4, and the issue is closed as completed. This PR retains public CLI/stdio MCP regressions and directly related cleanup of the both-empty diagnostic.

Synchronization and remaining scope

Merged main cbc0e97c2 into the existing branch with merge commit 1b79f56ac. Maintainer commits and merge history are preserved; no rebase or force push.

The remaining diff has two files: six comparison scenarios per public adapter, and removal of the now-unreachable nonempty branch in the empty-shape diagnostic. Empty opposite exports keep per-variant unknown changes; both-empty exports retain a generic unknown diagnostic. No runtime behavior or added/removed correspondence is inferred.

Current validation

npm run check:ci — pass, including typecheck, lint, format, knip, metadata, duplication, module boundaries and architecture guards.
npm run docs:check — pass.
npm run verify:test-discovery — all 1,275 test files discovered exactly once.
npm run test:focused -- tests/acceptance/applications/unpairedExportReturnsCli.test.ts tests/boundary/filesystem/javascriptExportShapeComparison.test.ts — attempted; 50 tests fail before analysis because this Windows host's native private-runtime authority inspection is invalid (private-runtime-root-authority-unavailable). These failures do not reach export comparison, and no current runtime pass is claimed.
Normal pre-push check:fast — pass; no hook bypass.

Historical validation on the original fix: the new CLI/MCP regression failed before the fix, then the four focused files passed 69 tests on bb0a8b90c. That historical result is not validation of this newly synchronized head.

The previous format failure in packagePlatformDiagnostics.test.ts and Turkish README link drift have upstream corrections included in this merge. The full deterministic suite and public runtime verification remain for CI. This change is static analysis only; no native provider or target code execution is involved.

Author readiness

Human owner: @chqcjq

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Draft pending the human owner's initial readiness declaration, as required by the current AGENTS.md/CONTRIBUTING.md.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2803 **Author:** [@chqcjq](https://github.com/chqcjq) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/export-unpaired-return-locations` --- ### 📝 Commits (10+) - [`bb0a8b9`](https://github.com/morluto/rea/commit/bb0a8b90c2d52e9745185318525dda1257e1c4b0) fix(javascript): retain unpaired return locations with empty opposite exports - [`1255253`](https://github.com/morluto/rea/commit/12552535c660248b1474a7447d8fdb55d80b3993) chore: merge captured main into PR 2803 - [`1718f6b`](https://github.com/morluto/rea/commit/1718f6b11d91ab4c9ec8d4977d5537d128064fb6) fix(comparison): recheck historical calls-only changes (#2223) - [`c9c7492`](https://github.com/morluto/rea/commit/c9c7492539f4524b4950071f3f91caf0e76b0656) fix(ci): isolate Linux Hopper process fixture inventory - [`81adbd7`](https://github.com/morluto/rea/commit/81adbd7c162f4249fd87d64205ec22b64ec3c2b8) fix(android): make DEX descriptor pattern portable - [`a4fabf6`](https://github.com/morluto/rea/commit/a4fabf6e5e11c711ba427a2a8c059c3c9ecbd3da) style: format comparison and IDA sources - [`89315f1`](https://github.com/morluto/rea/commit/89315f100d8302549af9d1e1ce6970af0df41c83) Merge commit '8fef2aa64ec1ee742e8b70b825938d30a0ea7319' into HEAD - [`aeaac75`](https://github.com/morluto/rea/commit/aeaac752dc482cc64af44ada4493781d849ded88) Merge branch 'main' into fix/export-unpaired-return-locations - [`ded84e7`](https://github.com/morluto/rea/commit/ded84e7a495b4e0f487db7cf8cdaaaa0f9c16ed6) Merge branch 'main' into fix/export-unpaired-return-locations - [`1b79f56`](https://github.com/morluto/rea/commit/1b79f56acf84a485386f44918c012682db0ad0dc) Merge remote-tracking branch 'origin/main' into fix/export-unpaired-return-locations ### 📊 Changes **2 files changed** (+138 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptExportShapeVariants.ts` (+5 -11) ➕ `tests/acceptance/applications/unpairedExportReturnsCli.test.ts` (+133 -0) </details> ### 📄 Description ## Summary Follow-up to #2659. The core fix was integrated into main by [`b58adafa4`](https://github.com/morluto/rea/commit/b58adafa4fa16d578132810f677eabc6d9ffdc09), and the issue is closed as completed. This PR retains public CLI/stdio MCP regressions and directly related cleanup of the both-empty diagnostic. ## Synchronization and remaining scope Merged main `cbc0e97c2` into the existing branch with merge commit `1b79f56ac`. Maintainer commits and merge history are preserved; no rebase or force push. The remaining diff has two files: six comparison scenarios per public adapter, and removal of the now-unreachable nonempty branch in the empty-shape diagnostic. Empty opposite exports keep per-variant unknown changes; both-empty exports retain a generic unknown diagnostic. No runtime behavior or added/removed correspondence is inferred. ## Current validation - `npm run check:ci` — pass, including typecheck, lint, format, knip, metadata, duplication, module boundaries and architecture guards. - `npm run docs:check` — pass. - `npm run verify:test-discovery` — all 1,275 test files discovered exactly once. - `npm run test:focused -- tests/acceptance/applications/unpairedExportReturnsCli.test.ts tests/boundary/filesystem/javascriptExportShapeComparison.test.ts` — attempted; 50 tests fail before analysis because this Windows host's native private-runtime authority inspection is invalid (`private-runtime-root-authority-unavailable`). These failures do not reach export comparison, and no current runtime pass is claimed. - Normal pre-push `check:fast` — pass; no hook bypass. Historical validation on the original fix: the new CLI/MCP regression failed before the fix, then the four focused files passed 69 tests on `bb0a8b90c`. That historical result is not validation of this newly synchronized head. The previous format failure in `packagePlatformDiagnostics.test.ts` and Turkish README link drift have upstream corrections included in this merge. The full deterministic suite and public runtime verification remain for CI. This change is static analysis only; no native provider or target code execution is involved. ## Author readiness Human owner: @chqcjq - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. Draft pending the human owner's initial readiness declaration, as required by the current AGENTS.md/CONTRIBUTING.md. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:06:24 +00:00