mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #2879] [CLOSED] fix(cli): honor SIGINT/SIGTERM in browser and JS-runtime commands #5463
Closed
opened 2026-10-31 01:06:50 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5463
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/2879
Author: @DeryFerd
Created: 10/13/2026
Status: ❌ Closed
Base:
main← Head:fix/cli-browser-javascript-cancellation📝 Commits (3)
85e7f52fix(cli): honor SIGINT/SIGTERM and report cancellation in browser and JS-runtime commandsb23dd48fix(browser): report cancellation after target cleanupa6ecfe9Merge origin/main into fix/cli-browser-javascript-cancellation📊 Changes
7 files changed (+453 additions, -0 deletions)
View changed files
📝
src/application/javascript/JavaScriptRuntimeObservationService.test.ts(+39 -0)➕
tests/acceptance/passiveObservationCliCancellation.test.ts(+201 -0)➕
tests/boundary/browser/browserObservationServiceCancellation.test.ts(+146 -0)📝
tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts(+52 -0)📝
tests/fixtures/fakeCdpBrowser.ts(+1 -0)📝
tests/fixtures/fakeCdpBrowserTypes.ts(+2 -0)➕
tests/fixtures/passiveObservationCancellation.mjs(+12 -0)📄 Description
Summary
rea's passive browser commands and V8 Inspector commands do not honorSIGINTorSIGTERM. When you interrupt one of them, the process either dies without running any awaited cleanup or reports an ordinary operation failure instead of a cancellation, so a caller watching the process status cannot tell "I interrupted this" from "this broke". This PR wires the eight affected CLI commands through the same cancellation boundary the rest of the CLI already uses, so an interrupt aborts the in-flight observation, waits for cleanup, and exits with the conventional130(SIGINT) or143(SIGTERM) status while printing the typedcancelledresult.The MCP side already threads
context.mcpReq.signalinto these same services, and the services already accept anExecutionOptionssignal. Only the CLI adapter was missing the boundary, which makes this a one-layer fix rather than a contract change. The sibling web-runtime commands (observe-web-execution,inspect-web-event-listeners) already received this exact treatment for the same defect (issue #1126, commit1d9b96a9c); this PR applies the established pattern to the browser and JavaScript-runtime commands that were left behind.Problem and expected behavior
Smallest trigger: run any of these commands against a loopback endpoint that accepts the discovery connection but never answers, then send
SIGINTorSIGTERMonce the command has parked in discovery.Violated invariant: a one-shot CLI command that receives an interrupt should abort its awaited work, run cleanup, and exit with the signal's conventional status and a typed cancellation result, matching every other cancellable command in the CLI. Before this change these eight commands registered their handlers directly, so the interrupt reached the process without any listener that aborts the observation. The command then either terminated abruptly or, once the stalled discovery finally failed on its own, reported a provider failure and exited
1.Expected behavior after the change: the interrupt aborts the pending CDP/Inspector work, the command resolves a
cancelledresult withcleanup: "complete", and the process exits130forSIGINTand143forSIGTERM. Two of the browser commands,compare-web-capturesandcompare-web-screenshots, are pure comparisons with no provider or socket work, so they are correctly left unwrapped.Change and scope
The change is narrow and follows an existing pattern instead of inventing a new one. Each affected handler is wrapped in
withCommandCancellation((signal) => logCliCommand(...))and passes{ signal }into the service call it already makes.withCommandCancellationinstallsSIGINT/SIGTERMlisteners that abort anAbortController, records130/143, and removes the listeners in afinallyblock that also setsprocess.exitCode. The aborted signal travels through the existingExecutionOptionsplumbing intodiscoverCdpEndpointandreadCdpJson, which already translate an aborted signal intoAnalysisCancelledError, andlogCliCommandalready projects that into the typedcancelledresult. Nothing in the domain, application, or provider layers needed to change, because the only broken stage was the CLI adapter's missing boundary.Files changed:
src/cli/browserCommands.tswrapslist-browser-targets,inspect-web-page,analyze-web-bundle, andobserve-web-session.src/cli/browserAdvancedCommands.tswrapsdiscover-webmcp-toolsandcapture-web-screenshot.src/cliJavaScriptRuntimeCommands.tswrapslist-javascript-runtime-targetsandobserve-javascript-runtime.tests/acceptance/passiveObservationCliCancellation.test.tsandtests/fixtures/passiveObservationCancellation.mjsadd the regression coverage.Intentionally not included: no change to
withCommandCancellationitself, no change to the MCP adapters (they already passcontext.mcpReq.signal), no change to service signatures (they already acceptExecutionOptions), and no change to the pure comparison commands. The change is additive at the adapter boundary and does not expand what any command reads, launches, injects, or mutates.Follow the contribution scope. This is a routine bug fix inside existing boundaries, so no advance maintainer scope decision is required; the linked scope decision is "not applicable".
Contract and boundary impact
130/143and returns the existingcancelledresult instead of exiting1with a provider failure. MCP is untouched and already cancels throughcontext.mcpReq.signal. No generated tool catalog changes.SIGINT/SIGTERM; Windows cannot deliver a catchable signal throughchild.kill(signal), so the test exercises the same handler through an in-process relay. No CDP, Inspector, or bridge protocol change.cancelledresult withcleanup: "complete"; no artifact is published for a cancelled observation, and partial evidence semantics are unchanged.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): None. No contract, schema, catalog, package, or installation surface changes.Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible.
The two checked items describe the commands' existing passive behavior: they read page and runtime evidence and connect to a caller-supplied loopback CDP/Inspector endpoint. This PR changes none of those effects; it only adds awaited cleanup when the caller interrupts.
Evidence and regression coverage
tests/acceptance/passiveObservationCliCancellation.test.tsdrives all eight commands through a realreaprocess against a stalled loopback server, and asserts that the process exits130/143, that it was not force-terminated, and that stdout carries thecancelledresult withcleanup: "complete"and the matchingoperation. It runs 16 cases (eight commands acrossSIGINTandSIGTERM).tests/fixtures/passiveObservationCancellation.mjsis the relay hook that re-emits the signal in-process on Windows, where the OS cannot deliver a catchable signal to a child.terminationSignal: "SIGINT"with a null exit code) or the stalled discovery eventually fails and the command exits1with a provider failure instead of thecancelledresult. With the fix in place all 16 cases pass. The regression therefore fails on the affected base revision and passes after the change.For evidence-bearing changes:
The middle item is left unchecked because a cancelled observation publishes no artifact, so artifact identity and provenance are not exercised by this change. The typed
cancelledresult keeps the interrupted outcome visible rather than collapsing it into a generic failure.Validation performed
npm run test:focused -- tests/acceptance/passiveObservationCliCancellation.test.ts— 16 passed, 16 skipped (the OS-signal lane is skipped on Windows; the relay lane runs). On the reverted base revision the same file reports 16 failed, 16 skipped.npm run check:fast— passed (cached typecheck and lint, plus the pre-push check).git diff --stat upstream/main...HEAD— 5 files changed, 420 insertions, 165 deletions.Compatibility, safety, and release
1to the conventional130/143, which is the fix, not a break. Command names, arguments, options, and JSON fields are unchanged.reabinary against a stalled loopback CDP/Inspector endpoint. A real browser or Electron target was not exercised; see the remaining proof gap above.finally. It does not add target selection, execution, injection, mutation, persistence, or new network behavior, and it does not weaken any existing boundary. No secrets or sensitive values are involved.Before merge
type(scope): outcome.On the issue link: no open issue tracks this exact gap. Issue #1126 covers the sibling web-runtime commands and was fixed by the same pattern, so this PR extends that fix to the browser and JavaScript-runtime commands rather than reopening a closed issue. If maintainers prefer, this can be filed as a follow-up issue first.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.