[PR #2902] [MERGED] test(windows): verify retained inspection ownership after rename #5482

New issue

Closed

opened 2026-10-31 01:07:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2902
Author: @N0zoM1z0
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/14/2026
Merged by: @kaoru0822-kitauji

Base: main ← Head: fix/windows-inspection-owner-2898

📝 Commits (5)

120a2d7 test(windows): verify retained inspection ownership after rename
5ffbe64 chore: sync Windows inspection fix with main
6f9623d chore: refresh Windows inspection fix with repaired main
be289ef Merge remote-tracking branch 'origin/main' into fix/windows-inspection-owner-2898
c2fbb66 Merge remote-tracking branch 'origin/main' into fix/windows-inspection-owner-2898

📊 Changes

1 file changed (+39 additions, -23 deletions)

View changed files

📝 scripts/verify-windows-native-inspection.mjs (+39 -23)

📄 Description

The Windows inspection verifier did not prove that cleanup of a renamed probe removes its children while preserving a different directory created at the original pathname. Both existing retry and normal-exit cases now verify retained NTFS identity, child cleanup and replacement identity/sentinel contents. Retry is checked before the child exits, so exit cleanup cannot hide a retry failure; the parent independently checks teardown after exit and captures cleanup diagnostics.

Fixes #2898.

The final diff contains only scripts/verify-windows-native-inspection.mjs (46 additions, 16 deletions). Production code and CLI/MCP behavior are unchanged; two serial child launches remain bounded at20s. The main branch already permits rename; this change strengthens its retained-owner regression coverage.

Validation on head be289efec, merged from main 0161a593e:

Standard npm run build:cached, uncached npm run check:fast, targeted formatting/syntax/diff checks pass with pinned Node24.18.0/npm11.16.0. Build and checks ran concurrently on two selected CPUs with1GiB Node heaps (47.04s/54.85s; not performance comparisons). Focused upstream static-input and Rizin tests pass30 assertions/1skip after their fixes landed in main. No unrelated repair is included in this PR.
Refreshed standard runtime on real Windows11 x64/NTFS: inspection passes both cases and all ownership/retry/teardown assertions;269-byte report, exit0, Job activeProcesses0. Production native conformance also passes token/environment, snapshot sharing, cleanup retry, descendants/breakaway, stdin/cancellation/backpressure, owner exit and Job limits. Exact relevant native/loader/fixture source identity permits reuse of the previously rebuilt current-main native artifacts; staged runtime hashes match the fresh build.
Inspection4.48s/76.45MiB peak Job commit; whole sampled guardian/family8.76s/3.19s CPU/56.83MiB working set. Native conformance23.00s/216.23MiB Job; whole observation27.74s/14.30s CPU/181.75MiB working set. Two CPUs/BelowNormal,2GiB enclosing Job,Node768MiB heap. Two-second samples miss short children and exclude the PowerShell observer; Job commit is separate. No runtime analysis speedup or agent-token cost change is claimed.
Independent review of the identical final verifier found no blocking issue. Previous-head Windows CI directly passed this ownership oracle, plus401/47/58 Windows tests and all three native package platforms; Greptile review passed. Its only two failing test files were fixed upstream. Current-head CI and automatic review must complete before normal merge.

The failure is controlled; this does not claim reproduction of the intermittent original host/filter-driver failure or inspection cleanup after forced termination. Caller integrity remains elevated as measured; owner normalization does not drop integrity. Temporary artifacts and private targets remain outside the repository.

Current-head Source tests:6561 passed/4 skipped, one unchanged upstream services test starts the compiled JavaScript worker before the source-only job prepares dist. The exact test passes locally with the standard runtime prepared. Main7e9fb6f1b subsequently moved it to the compiled boundary group. Exact head/base test, worker, package import and test-project identities plus complete CI log are retained locally. Other CI jobs are still settling; no unrelated edit or retry is included.

Final current-head CI result: Windows capability/package, native builds/packages on Linux x64/arm64 and Darwin arm64, Static checks, package build, Greptile and three built shards pass; one shard is cancelled. Source tests fail only the upstream compiled-worker prerequisite case noted above. Shard3 fails only ciTestReports.test.ts:471: it expects stdout Markdown while inheriting GITHUB_STEP_SUMMARY, which makes the unchanged reporter write to that path instead. Both test and producer blobs match head/base/main; no Windows-verifier code participates. Complete attribution and logs are retained locally. Portable tests and required gate also fail; their final diagnostics are being checked before the next main sync.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2902 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/14/2026 **Merged by:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Base:** `main` ← **Head:** `fix/windows-inspection-owner-2898` --- ### 📝 Commits (5) - [`120a2d7`](https://github.com/morluto/rea/commit/120a2d75cf8536677b73844fce579511d478adcb) test(windows): verify retained inspection ownership after rename - [`5ffbe64`](https://github.com/morluto/rea/commit/5ffbe643348b3a0181804825bb69f456dc94fd88) chore: sync Windows inspection fix with main - [`6f9623d`](https://github.com/morluto/rea/commit/6f9623de32bad1070bd1137ebc4f8eb22f83f5e9) chore: refresh Windows inspection fix with repaired main - [`be289ef`](https://github.com/morluto/rea/commit/be289efec72430d664e20fc4b1c7086ca8b7c796) Merge remote-tracking branch 'origin/main' into fix/windows-inspection-owner-2898 - [`c2fbb66`](https://github.com/morluto/rea/commit/c2fbb6604b2792ddba2cc40e1d7c696a5df7550a) Merge remote-tracking branch 'origin/main' into fix/windows-inspection-owner-2898 ### 📊 Changes **1 file changed** (+39 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify-windows-native-inspection.mjs` (+39 -23) </details> ### 📄 Description The Windows inspection verifier did not prove that cleanup of a renamed probe removes its children while preserving a different directory created at the original pathname. Both existing retry and normal-exit cases now verify retained NTFS identity, child cleanup and replacement identity/sentinel contents. Retry is checked before the child exits, so exit cleanup cannot hide a retry failure; the parent independently checks teardown after exit and captures cleanup diagnostics. Fixes #2898. The final diff contains only `scripts/verify-windows-native-inspection.mjs` (46 additions, 16 deletions). Production code and CLI/MCP behavior are unchanged; two serial child launches remain bounded at20s. The main branch already permits rename; this change strengthens its retained-owner regression coverage. Validation on head `be289efec`, merged from main `0161a593e`: - Standard `npm run build:cached`, uncached `npm run check:fast`, targeted formatting/syntax/diff checks pass with pinned Node24.18.0/npm11.16.0. Build and checks ran concurrently on two selected CPUs with1GiB Node heaps (47.04s/54.85s; not performance comparisons). Focused upstream static-input and Rizin tests pass30 assertions/1skip after their fixes landed in main. No unrelated repair is included in this PR. - Refreshed standard runtime on real Windows11 x64/NTFS: inspection passes both cases and all ownership/retry/teardown assertions;269-byte report, exit0, Job activeProcesses0. Production native conformance also passes token/environment, snapshot sharing, cleanup retry, descendants/breakaway, stdin/cancellation/backpressure, owner exit and Job limits. Exact relevant native/loader/fixture source identity permits reuse of the previously rebuilt current-main native artifacts; staged runtime hashes match the fresh build. - Inspection4.48s/76.45MiB peak Job commit; whole sampled guardian/family8.76s/3.19s CPU/56.83MiB working set. Native conformance23.00s/216.23MiB Job; whole observation27.74s/14.30s CPU/181.75MiB working set. Two CPUs/BelowNormal,2GiB enclosing Job,Node768MiB heap. Two-second samples miss short children and exclude the PowerShell observer; Job commit is separate. No runtime analysis speedup or agent-token cost change is claimed. - Independent review of the identical final verifier found no blocking issue. Previous-head Windows CI directly passed this ownership oracle, plus401/47/58 Windows tests and all three native package platforms; Greptile review passed. Its only two failing test files were fixed upstream. Current-head CI and automatic review must complete before normal merge. The failure is controlled; this does not claim reproduction of the intermittent original host/filter-driver failure or inspection cleanup after forced termination. Caller integrity remains elevated as measured; owner normalization does not drop integrity. Temporary artifacts and private targets remain outside the repository. Current-head Source tests:6561 passed/4 skipped, one unchanged upstream services test starts the compiled JavaScript worker before the source-only job prepares `dist`. The exact test passes locally with the standard runtime prepared. Main7e9fb6f1b subsequently moved it to the compiled boundary group. Exact head/base test, worker, package import and test-project identities plus complete CI log are retained locally. Other CI jobs are still settling; no unrelated edit or retry is included. Final current-head CI result: Windows capability/package, native builds/packages on Linux x64/arm64 and Darwin arm64, Static checks, package build, Greptile and three built shards pass; one shard is cancelled. Source tests fail only the upstream compiled-worker prerequisite case noted above. Shard3 fails only `ciTestReports.test.ts:471`: it expects stdout Markdown while inheriting `GITHUB_STEP_SUMMARY`, which makes the unchanged reporter write to that path instead. Both test and producer blobs match head/base/main; no Windows-verifier code participates. Complete attribution and logs are retained locally. Portable tests and required gate also fail; their final diagnostics are being checked before the next main sync. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:00 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-03 13:40:07 +00:00

[PR #7254] [MERGED] feat(cli): add CSV and TSV analysis views #7748

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5482

No description provided.

Rows
Columns