[PR #2943] [MERGED] fix(ci): skip portable report merge when shards are skipped #5508

New issue

Closed

opened 2026-10-31 01:07:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2943
Author: @morluto
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: codex/ci-skip-portable-merge-after-skipped-shards

📝 Commits (3)

38ad901 fix(ci): skip portable report merge when shards are skipped
13c9104 fix(ci): preserve failed shard diagnostics
1f727ff docs: clarify current revision CI policy

📊 Changes

3 files changed (+26 additions, -8 deletions)

View changed files

📝 .github/workflows/ci.yml (+11 -3)
📝 CONTRIBUTING.md (+1 -2)
📝 tests/boundary/filesystem/ciTestReports.test.ts (+14 -3)

📄 Description

When a Build package failure prevents the test-shard matrix from running, the Portable tests job must skip report download and merge because no shard artifacts exist. Failed shards are different: their !cancelled() upload step can publish blob reports, and merging those preserves partial diagnostics. Permit report download and both full/fast merges for successful or failed shard results; keep them skipped when shards are cancelled or skipped. The final required-shard gate still fails every required outcome other than success, and successful timing history remains success-only.

Also correct CONTRIBUTING.md to describe routine CI as required checks passing for the current PR revision, without requiring every PR to stay up to date with main. Administrators retain the documented recovery override.

Validation: focused ciTestReports.test.ts (7 tests), npm run check:fast, npm run docs:check, pinned actionlint v1.7.7, and git diff --check passed. Hosted CI has not yet completed for this revision.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2943 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/ci-skip-portable-merge-after-skipped-shards` --- ### 📝 Commits (3) - [`38ad901`](https://github.com/morluto/rea/commit/38ad901c9a25586abae4bea696d6fd6370205bd8) fix(ci): skip portable report merge when shards are skipped - [`13c9104`](https://github.com/morluto/rea/commit/13c9104df13639eda13b21aedbe1ee3b3ea36af1) fix(ci): preserve failed shard diagnostics - [`1f727ff`](https://github.com/morluto/rea/commit/1f727ffef865545fc84899210963ee16d03da61e) docs: clarify current revision CI policy ### 📊 Changes **3 files changed** (+26 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+11 -3) 📝 `CONTRIBUTING.md` (+1 -2) 📝 `tests/boundary/filesystem/ciTestReports.test.ts` (+14 -3) </details> ### 📄 Description When a Build package failure prevents the test-shard matrix from running, the Portable tests job must skip report download and merge because no shard artifacts exist. Failed shards are different: their `!cancelled()` upload step can publish blob reports, and merging those preserves partial diagnostics. Permit report download and both full/fast merges for successful or failed shard results; keep them skipped when shards are cancelled or skipped. The final required-shard gate still fails every required outcome other than success, and successful timing history remains success-only. Also correct `CONTRIBUTING.md` to describe routine CI as required checks passing for the current PR revision, without requiring every PR to stay up to date with `main`. Administrators retain the documented recovery override. Validation: focused `ciTestReports.test.ts` (7 tests), `npm run check:fast`, `npm run docs:check`, pinned actionlint v1.7.7, and `git diff --check` passed. Hosted CI has not yet completed for this revision. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:11 +00:00