[GH-ISSUE #1630] [Bug] Main duplicate-code gate blocks unrelated client onboarding changes #551

New issue

Closed

opened 2026-10-15 18:26:05 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:26:05 +00:00

Owner

Originally created by @N0zoM1z0 on GitHub (Oct 10, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/1630

Before submitting

Searched the existing duplicate-gate reports (#1446 and #172).
Removed credentials, private paths and target data.

Area

Other: test verification / CI

Observed behavior

PR #1627 fails npm run check:ci because jscpd src/ tests/ reports 9360 duplicated lines / 372016 total (2.52%), above the unchanged 2.5% gate. The PR changes only documentation and optional verifier scripts, which this scanner does not examine. Git tree IDs for both src and tests are identical to its main base 5100a1a1.

Reproduction

Run npm ci and npm run jscpd at the main baseline. CI job 114298725901 has the full clone report. The largest copied fixture blocks are the observed/unknown Evidence and relation graph inputs in javascriptSemanticGraphQuery.test.ts and javascriptSemanticGraphTraversal.test.ts.

Expected behavior

The baseline passes its existing duplicate-code gate. Identical semantic Evidence and graph fixtures have one test-family owner, while query and traversal assertions remain independent.

Impact and scope

Blocks unrelated contributions. This is a REA test-fixture maintenance defect; no production provider, contract or Evidence semantics need change. Do not raise the threshold, exclude tests, or delete distinct assertions.

REA version

Main 5100a1a1 and refreshed main 39da0b15. The refreshed baseline also fails: 9367 / 372253 duplicated lines (2.52%). The same 38 focused semantic graph tests pass before changes.

Runtime and platform

Linux x64, Node 24.18.0, npm 11.16.0, jscpd 5.0.12.

Interface

Other: CI

Earliest failure stage

Unknown: static duplicate-code gate

Relevant output or evidence

9360 (2.52%) duplicated lines; scanner threshold 2.5. Both src/tests tree identities match the PR base exactly. CI: https://github.com/morluto/rea/actions/runs/38081331865

Analysis or suspected cause

Observed common immutable fixture definitions have been copied between two test suites. Share the input builders at the owning test-family boundary and preserve IDs, provenance, unknowns, coverage and all assertions. Verify the same focused tests before and after, then rerun the full existing static gate.

Additional context

Prerequisite discovered while babysitting #1627. Work is isolated in a separate worktree/branch; no original in-progress checkout edits.

Originally created by @N0zoM1z0 on GitHub (Oct 10, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/1630 ### Before submitting - [x] Searched the existing duplicate-gate reports (#1446 and #172). - [x] Removed credentials, private paths and target data. ### Area Other: test verification / CI ### Observed behavior PR #1627 fails `npm run check:ci` because `jscpd src/ tests/` reports 9360 duplicated lines / 372016 total (2.52%), above the unchanged 2.5% gate. The PR changes only documentation and optional verifier scripts, which this scanner does not examine. Git tree IDs for both src and tests are identical to its main base 5100a1a1. ### Reproduction Run `npm ci` and `npm run jscpd` at the main baseline. CI job 114298725901 has the full clone report. The largest copied fixture blocks are the observed/unknown Evidence and relation graph inputs in `javascriptSemanticGraphQuery.test.ts` and `javascriptSemanticGraphTraversal.test.ts`. ### Expected behavior The baseline passes its existing duplicate-code gate. Identical semantic Evidence and graph fixtures have one test-family owner, while query and traversal assertions remain independent. ### Impact and scope Blocks unrelated contributions. This is a REA test-fixture maintenance defect; no production provider, contract or Evidence semantics need change. Do not raise the threshold, exclude tests, or delete distinct assertions. ### REA version Main 5100a1a1 and refreshed main 39da0b15. The refreshed baseline also fails: 9367 / 372253 duplicated lines (2.52%). The same 38 focused semantic graph tests pass before changes. ### Runtime and platform Linux x64, Node 24.18.0, npm 11.16.0, jscpd 5.0.12. ### Interface Other: CI ### Earliest failure stage Unknown: static duplicate-code gate ### Relevant output or evidence `9360 (2.52%)` duplicated lines; scanner threshold 2.5. Both src/tests tree identities match the PR base exactly. CI: https://github.com/morluto/rea/actions/runs/38081331865 ### Analysis or suspected cause Observed common immutable fixture definitions have been copied between two test suites. Share the input builders at the owning test-family boundary and preserve IDs, provenance, unknowns, coverage and all assertions. Verify the same focused tests before and after, then rerun the full existing static gate. ### Additional context Prerequisite discovered while babysitting #1627. Work is isolated in a separate worktree/branch; no original in-progress checkout edits.

bsakaguchi

2026-10-15 18:26:05 +00:00