[PR #2964] [MERGED] test(reconstruction): declare complete comparison fixture facets #5521

New issue

Closed

opened 2026-10-31 01:07:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2964
Author: @morluto
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: codex/triage-function-comparison-call-facet-fixture

📝 Commits (1)

8d51af9 test(reconstruction): declare complete comparison fixture facets

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 src/domain/reconstructionVerification.functionSources.test.ts (+10 -0)

📄 Description

The clean main baseline at 8fef2aa64ec1ee742e8b70b825938d30a0ea7319 failed 5 of 68 tests in reconstructionVerification.functionSources.test.ts. The test fixture predates #2450 and omitted facet_availability, so empty facets correctly made these comparisons unknown under the current contract.

Declare complete availability for the fixture's eight facets. This restores the intended historical calls comparisons while preserving every assertion. No production code changes.

Validation: both functionComparison.test.ts and reconstructionVerification.functionSources.test.ts pass (117 tests); npm run check:fast, formatting, and git diff --check pass. Full CI pending.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2964 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/triage-function-comparison-call-facet-fixture` --- ### 📝 Commits (1) - [`8d51af9`](https://github.com/morluto/rea/commit/8d51af982e906c32c4bf401c05e5d5517becea0c) test(reconstruction): declare complete comparison fixture facets ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/reconstructionVerification.functionSources.test.ts` (+10 -0) </details> ### 📄 Description The clean main baseline at `8fef2aa64ec1ee742e8b70b825938d30a0ea7319` failed 5 of 68 tests in `reconstructionVerification.functionSources.test.ts`. The test fixture predates #2450 and omitted `facet_availability`, so empty facets correctly made these comparisons unknown under the current contract. Declare complete availability for the fixture's eight facets. This restores the intended historical calls comparisons while preserving every assertion. No production code changes. Validation: both `functionComparison.test.ts` and `reconstructionVerification.functionSources.test.ts` pass (117 tests); `npm run check:fast`, formatting, and `git diff --check` pass. Full CI pending. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:18 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:44:24 +00:00

[PR #5571] [MERGED] fix(artifacts): report a stable symlink loop as a path resolution failure #6970

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5521

No description provided.

Rows
Columns