[PR #2966] [CLOSED] test(javascript): cover exact primitive property keys #5523

New issue

Closed

opened 2026-10-31 01:07:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2966
Author: @rudycelekli
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: candidate/rea-next10-literal-keys-20261013

📝 Commits (4)

9ea060b fix(javascript): retain exact primitive computed property keys
a1032d2 test(javascript): cover returned literal-key object completeness
d7f4b62 chore: sync main before retaining property-key regressions
7b52f22 test(javascript): retain primitive-key regressions without redundant fallback

📊 Changes

1 file changed (+131 additions, -0 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticAnalysis.empty_keys.test.ts (+131 -0)

📄 Description

Summary

Retains focused regression coverage for exact JavaScript primitive property keys already supported by current main. The redundant literal fallback from the original implementation proposal has been removed; the net PR diff is now test-only.

The added cases cover literal templates, boolean/null computed keys, method names, CommonJS exports, environment keys and nonfinite numeric property spellings. Dynamic template expressions and unknown computed keys remain unresolved.

Validation

Merged main at 3dbe314ada9f6dcc994ca4655dc0faf082503847, then removed the superseded fallback at its original owning boundary.

On Node 24.18.0/npm 11.16.0:

npm run test:local -- src/domain/javascript/javascriptSemanticAnalysis.empty_keys.test.ts: 25 passed.
npm run check:fast: passed; the push hook repeated the cached checks successfully.

No public CLI/MCP, runtime or provider verification was performed in this pass. No production behavior changes remain in this PR.

Author readiness

Human owner: @rudycelekli

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2966 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `candidate/rea-next10-literal-keys-20261013` --- ### 📝 Commits (4) - [`9ea060b`](https://github.com/morluto/rea/commit/9ea060bc5ce34b577fcf4576fc8050d5a42c9425) fix(javascript): retain exact primitive computed property keys - [`a1032d2`](https://github.com/morluto/rea/commit/a1032d2785cb9a11157c292b1d4bb4eac3f08cd7) test(javascript): cover returned literal-key object completeness - [`d7f4b62`](https://github.com/morluto/rea/commit/d7f4b6292ef5b00f3d174bdbad09a114d22e5817) chore: sync main before retaining property-key regressions - [`7b52f22`](https://github.com/morluto/rea/commit/7b52f22add4828d8f7f92973fce5bf92ef6c714d) test(javascript): retain primitive-key regressions without redundant fallback ### 📊 Changes **1 file changed** (+131 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticAnalysis.empty_keys.test.ts` (+131 -0) </details> ### 📄 Description ## Summary Retains focused regression coverage for exact JavaScript primitive property keys already supported by current main. The redundant literal fallback from the original implementation proposal has been removed; the net PR diff is now test-only. The added cases cover literal templates, boolean/null computed keys, method names, CommonJS exports, environment keys and nonfinite numeric property spellings. Dynamic template expressions and unknown computed keys remain unresolved. ## Validation Merged main at `3dbe314ada9f6dcc994ca4655dc0faf082503847`, then removed the superseded fallback at its original owning boundary. On Node 24.18.0/npm 11.16.0: - `npm run test:local -- src/domain/javascript/javascriptSemanticAnalysis.empty_keys.test.ts`: 25 passed. - `npm run check:fast`: passed; the push hook repeated the cached checks successfully. No public CLI/MCP, runtime or provider verification was performed in this pass. No production behavior changes remain in this PR. ## Author readiness Human owner: @rudycelekli - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:18 +00:00