[PR #2972] [CLOSED] fix(ci): fail required gate after current-head cancellation #5529

New issue

Closed

opened 2026-10-31 01:07:20 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2972
Author: @morluto
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: codex/ci-required-cancellation-gate

📝 Commits (2)

a00401e fix(ci): fail required gate after cancellation
806bd81 docs(ci): clarify canceled dependency gate

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -2)

📄 Description

Withdrawn after validating the cancellation premise. A live probe with a completed prerequisite and a manually canceled selected lane produced a terminal cancelled aggregate check, not a skipped or successful one (run 38440482565, aggregate check 115446479057). The proposed always() condition was unnecessary and could keep superseded PR runs in the shared concurrency group. The repository's existing !cancelled() condition and strict scripts/ci/required.mjs aggregation remain in place.

Validation: npm run test:focused -- tests/boundary/filesystem/ciRequiredLanes.test.ts passed (16 tests) under Node 24.18.0/npm 11.16.0; git diff --check passed. This PR is closed as an unnecessary proposal; its branch history was preserved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2972 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/ci-required-cancellation-gate` --- ### 📝 Commits (2) - [`a00401e`](https://github.com/morluto/rea/commit/a00401ecc12ecc148c4d5d88512abcc800bcea1d) fix(ci): fail required gate after cancellation - [`806bd81`](https://github.com/morluto/rea/commit/806bd81b42b887f54f0664c1644c0a14a626bdef) docs(ci): clarify canceled dependency gate ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -2) </details> ### 📄 Description Withdrawn after validating the cancellation premise. A live probe with a completed prerequisite and a manually canceled selected lane produced a terminal `cancelled` aggregate check, not a skipped or successful one (run 38440482565, aggregate check 115446479057). The proposed `always()` condition was unnecessary and could keep superseded PR runs in the shared concurrency group. The repository's existing `!cancelled()` condition and strict `scripts/ci/required.mjs` aggregation remain in place. Validation: `npm run test:focused -- tests/boundary/filesystem/ciRequiredLanes.test.ts` passed (16 tests) under Node 24.18.0/npm 11.16.0; `git diff --check` passed. This PR is closed as an unnecessary proposal; its branch history was preserved. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:20 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5529

No description provided.

Rows
Columns