mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 01:07:30 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5549
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/2994
Author: @maxazure
Created: 10/13/2026
Status: ❌ Closed
Base:
main← Head:fix/artifacts-literal-backslash-2619📝 Commits (8)
bb9c156fix(artifacts): preserve literal POSIX backslash names405ffc2fix(browser): retain Windows saved-source path admission7826656fix(javascript): preserve literal artifact names across graph consumers3e75ad4fix(artifacts): preserve owning paths through joins and runtime mappings7b74f88fix(javascript): retain raw loadFile runtime path authority61e77b0fix(artifacts): scope renderer mappings and retain historical names3bc87cafix(artifacts): retain inventoried symlink and URL path semanticsaadbe63fix(wakaru): retain multi-input filename refusal📊 Changes
23 files changed (+1484 additions, -81 deletions)
View changed files
📝
src/artifacts/ArtifactPaths.ts(+3 -8)📝
src/artifacts/SafeOutputTree.ts(+5 -0)📝
src/browser/assets/LocalWebScriptArtifacts.ts(+5 -0)📝
src/domain/artifactGraph.ts(+0 -1)📝
src/domain/artifactIdentity.ts(+1 -3)📝
src/domain/javascript/javascriptApplicationEvidenceSchemas.ts(+1 -1)📝
src/domain/javascript/javascriptRuntimeReconciliationMatching.ts(+43 -7)📝
src/domain/javascript/javascriptRuntimeReconciliationSchemas.ts(+2 -2)📝
src/domain/javascript/javascriptRuntimeStaticCandidates.ts(+155 -9)📝
src/domain/javascript/javascriptSemanticGraphSchemas.ts(+0 -1)📝
src/domain/javascript/javascriptSourceMapPaths.ts(+11 -10)📝
src/domain/javascript/sourceToBundleComparison.test.ts(+7 -5)📝
src/domain/javascript/sourceToBundleSignals.ts(+42 -13)📝
src/domain/referenceSourceGraph.test.ts(+51 -0)📝
src/domain/referenceSourceGraph.ts(+18 -15)📝
src/javascript/recovery/RecoveryFiles.ts(+5 -0)📝
tests/boundary/cli/referenceSourceUtf8.test.ts(+146 -2)➕
tests/boundary/filesystem/artifactLiteralBackslash.test.ts(+222 -0)📝
tests/boundary/filesystem/javascript-applications/javascriptRuntimeReconciliation.test.ts(+482 -0)➕
tests/boundary/filesystem/recoveryInputPaths.test.ts(+72 -0)...and 3 more files
📄 Description
Summary
Fixes #2619. Preserve supported POSIX filenames containing literal backslashes through inventory, extraction, JavaScript graphs, runtime mapping, and historical reference import.
Problem and expected behavior
Directory and ASAR readers return a member such as
literal\name.jsintact, but shared path admission rejects the inventory. Downstream graph validators also reject that spelling, while several graph consumers reinterpret it asliteral/name.js, causing false location matches or source-map paths. A recorded artifact name must retain the reader's identity.Change and scope
Keep slash-separated logical names in the shared normalizer and inventory/application/semantic result validators. Refuse backslash interpretation at Windows output and saved-source read boundaries before host joins.
Artifact joins preserve an inventoried importer base, so a valid relative import resolves to its literal directory rather than a slash-named decoy. Runtime matching preserves owned artifact facts and POSIX paths. Raw
loadFiledeclarations use application-root semantics and the captured native file format; their source-relative static inference is not promoted to an owned runtime target. Genuine resolved artifact facts suppress competing raw aliases. Runtime mappings accept safe logical backslash prefixes without decoding them. Native declaration lookup retains the mapped file-root suffix and uses source provenance only to constrain the selected application prefix; overlapping mapping interpretations remain uncertain. Source comparison uses resolved artifact facts instead of reinterpreting their raw declarations. Explicitscheme://observation metadata keeps URL query/fragment handling, while canonical and resolved artifact identities remain exact. Source-map resolution preserves its exact artifact base and checks encoded separators in the parsed declaration pathname, keeping Windows, URL authority, and query semantics separate.The runtime view leaves the existing static source-relative
loadFileinference in the supplied graph and does not treat that derivation as owning target identity. This corrects existing inventory/reconstruction workflows; no separate maintainer scope decision is applicable. Historical entry and observed symlink-target validation accepts literal backslashes while retaining NUL, traversal, absolute-target, and membership checks. Internal symlink classification first verifies the exact or uniquely Unicode-equivalent relative inventory target, so an inventoried POSIX name resembling a Windows UNC path remains internal; unproven Windows external targets retain their existing classification. The reader already preserves these names; CLI failures on original base729ca2ab6prove this is a pre-existing contract gap. Raw import-specifier parsing, module/URL admission, and symlink authority/IO remain unchanged.Contract and boundary impact
bundle.jssnapshot naming is preserved.Expected effects:
Evidence and regression coverage
Red regressions establish each affected boundary:
729ca2ab6: directory and packed-ASAR inventory reject supported literal names withArtifactReaderFailurereasonpath.loadFiledeclaration fails to match; suppressing its raw declaration in favor of a source-relative inference also drops a legitimate application-root match from a nested module (compared against exact earlier head7826656).729ca2ab6. After admission, a real internal symlink to a UNC-looking POSIX filename fails target-state validation.../outside.jstraversal; a positive inventory control keeps literal and slash names distinct.Controls cover embedded/leading/doubled/nested backslashes, ordinary names, distinct slash paths, verified digests, extraction readback, cleanup, containment/collisions, recorded Windows roots, URL prefixes, UNC/source-map declarations, encoded URI authority data, and Windows native literal percent sequences, application-prefix isolation, overlapping mapping ambiguity, Unicode prefix equivalence, historical exact digests, input bytes unchanged, and observed symlink targets.
Built public CLI inspection/extraction and CLI/pinned-SDK MCP application analysis preserve
literal\name.js; extraction readback matches, input bytes remain unchanged, and MCP ping succeeds afterward. Fresh independent agent review of the final diff found no remaining issue; remote CI and PR automatic review remain separate checks.Validation performed
npm run build:cached,npm run typecheck,npm run knip, module-boundary and architecture guards: passed.npm run verify:test-discovery: all 1,124 files discovered exactly once.git diff --check: passed.npm run check: unchanged baseline lint error insrc/dotnet/ManagedCilDecoding.test.ts:248(162 function lines, maximum 150), reproduced on clean base.npm run docs:check: unchanged Turkish README link drift, independently reproduced with prepared prerequisites on clean base.HUSKY=0, without hook/global configuration changes.macOS, Node 24.18.0/npm 11.16.0. Windows destination checks use the writer's explicit platform parameter; saved-source tests simulate Windows admission. Recorded Windows/runtime fixtures verify interpretation, not native Windows IO or live Electron behavior. Real Hopper/Ghidra were not run. The pinned Wakaru binary was not run locally; its audited source explicitly folds multi-input public names and importer bases from backslashes to slashes. The local snapshot refusal preserves the existing prelaunch contract without claiming engine support. No performance claim is made. OpenAI Codex prepared the implementation and automated verification; no human-authored implementation or human review is claimed.
Latest-head CI evidence
Head
aadbe63d0c1c77fccfad1643453f1f4a0e28d85b: the final local related suite passed 915 tests with 47 explicit platform skips (82 files passed / three skipped). CI run 38478453214 completed with failing required checks; build, static checks, docs and the Windows lane passed. Real Linux recovery verified 12 CLI/MCP fixtures with Wakaru 1.14.0; this did not exercise a literal-backslash engine input. The real source-map lane also passed.The executed merge was
8c0702e90f70a8aa13d24d1176b30d5dc8905f8dinto basecd740a6764d24e466f31613c2cef3368c3f64cba. The remaining test failures have clean-base controls:ProviderAdapterError. Reproduced after locked installation on clean4d98123279c5a6f5442c458307f5a3ec678fd49e, mirroring the source CI job's no-dist layout. The test, worker, workflow and package/config inputs are identical at the current base; the baseline comparison is public.cd740a6withGITHUB_STEP_SUMMARYdirected to a temporary file: the unchanged report script writes the summary instead of stdout. One selected test failed; seven others were unselected, not platform skips.The partial aggregate contains 7,974 passed / two failed / 30 skipped. Four sibling shards were cancelled by fail-fast and are absent from that report, so it is not complete all-green coverage. Required checks remain failing pending these upstream corrections.
Before merge
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.