mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #3026] [CLOSED] feat(mcp): scope advertised tools by family through REA_MCP_TOOL_FAMILIES #5565
Closed
opened 2026-10-31 01:07:37 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5565
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/3026
Author: @0xLLVEL
Created: 10/13/2026
Status: ❌ Closed
Base:
main← Head:feat/mcp-tool-families📝 Commits (10+)
36ab380feat(mcp): scope advertised tools by family through REA_MCP_TOOL_FAMILIES30202cadocs(mcp): recommend tool-family scopes per common workflowaaa9217fix(mcp): honor tool-family scope in status reports and stop suppressing Hopper offer16c24d2docs(mcp): include browser family for Electron and browser-hosted appse28e01dchore: merge main into PR #3026a53b370chore: merge upstream main to pick up doctor Hopper path retention fixb7aa7b2fix(mcp): honor tool-family scope in doctor, identity and status63c4702fix(mcp): skip availability probes for scoped-out providers24395c9fix(mcp): preserve DSH unknowns and gate budget resolver by client in statusf594216chore: merge upstream main into MCP tool family scope📊 Changes
40 files changed (+1659 additions, -332 deletions)
View changed files
📝
docs/client-configuration.md(+8 -0)📝
docs/installation.md(+3 -3)📝
docs/mcp-contracts.md(+64 -0)📝
docs/mcp-prompts.md(+7 -0)📝
experiments/analysis-efficiency/mcp-profile-digest.mjs(+5 -4)📝
scripts/lib/catalog-builders.mjs(+8 -138)📝
scripts/lib/catalog-core.mjs(+1 -3)📝
scripts/verify-claude-client.mjs(+6 -4)📝
src/application/ClientRegistrationEnvironment.ts(+6 -1)📝
src/application/ClientRegistrationStatus.ts(+10 -1)📝
src/application/DirectAnalysisStatus.ts(+4 -4)📝
src/application/Doctor.ts(+5 -1)📝
src/application/Setup.configuration.test.ts(+57 -0)📝
src/application/Setup.ts(+8 -0)📝
src/application/SetupTypes.ts(+2 -0)📝
src/application/binary/BinarySessionStatus.test.ts(+40 -1)📝
src/application/binary/BinarySessionStatus.ts(+47 -1)📝
src/catalogIdentity.ts(+33 -22)📝
src/cli/setupCommands.ts(+20 -0)📝
src/config/environment.ts(+2 -0)...and 20 more files
📄 Description
Summary
Closes #3246.
REA advertises its complete MCP tool catalog (200+ tools) to every client. Agents pay context for each advertised schema, which prices local models with small context windows out entirely. This PR scopes the advertised tool set by family through
REA_MCP_TOOL_FAMILIES(env var, orrea setup --tool-families <ids>persisted into the registration entry). Unset behavior is unchanged: the complete catalog is advertised exactly as before.Problem and expected behavior
A local 32K-context model driving REA over MCP gets a ~249K-token tool advertisement it cannot fit, so the investigation never starts (independent benchmark in discussion #3098: full list refused at once;
session,direct+ compact still 28K tokens and failed; only a 10-tool allowlist at 4.4K tokens succeeded 3 of 3). Users need a supported, server-side way to narrow the advertised set to the families their investigation needs, without client-side filtering hacks.Change and scope
REA_MCP_TOOL_FAMILIESselection (env var orrea setup --tool-families <ids>, persisted into the registration entry) omits out-of-scope schemas fromtools/listentirely.Tool ... disabledinvalid-params error.scripts/lib/catalog-builders.mjsintosrc/contracts/toolFamilies.ts, so runtime advertising and the product catalog derive from one grouping.sessionas the near-universal base; browser family included for Electron and browser-hosted apps.src/contracts/toolFamilyIds.ts, so startup configuration validates a scope without loading the canonical schema graph the deferred MCP runtime deliberately avoids;src/contracts/toolFamilies.tskeeps the contract ownership.scripts/verify-claude-client.mjscalls the named-options catalog identity API, and the EVM limiter probe is gated on theartifactfamily like the other provider probes.Follow the contribution scope. No target execution, injection, mutation, or protection recovery is introduced; scope decision: not applicable beyond the documented MCP advertisement contract.
Contract and boundary impact
src/contracts/toolFamilies.tsowns the grouping); earliest changed stage is server startup/registration.tools/listomits out-of-scope tools; direct out-of-scope calls return the SDK disabled-tool error;rea setup --tool-familiesand doctor validation added. Default (unset) output is unchanged.docs/public/product-catalog.json), package, or installation impact: catalog derives from the same grouping;metadata:checkvalidates the family inventory against everyTOOL_CONTRACTSentry. No build outputs committed.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
This change only filters which schemas are advertised and which calls are accepted; it adds no new target interaction:
Evidence and regression coverage
src/contracts/toolFamilies.test.ts(unit: every catalog tool resolves to a family; unknown names resolve undefined)tests/conformance/contracts/mcpToolFamilies.test.ts(family inventory covers everyTOOL_CONTRACTSentry)tests/boundary/mcp/toolFamiliesMcp.test.ts(tools/listomission + disabled-call error at the boundary)src/application/Setup.configuration.test.ts(scope persisted into the registration env; status reports honor scope)session,direct+compact failed, 10-tool allowlist succeeded 3 of 3. That benchmark used PR #3026 atd993ffeb1plus a client-side allowlist; this PR provides the server-side half.tools/listwithREA_MCP_TOOL_FAMILIES=session,directreturns only in-scope tools; calling an out-of-scope tool returns the SDKTool ... disabledinvalid-params error.rea setup --tool-families <ids>persists the scope; an unknown id fails startup listing the complete valid ids.metadata:check(inventory coverage) passes on the merged tree.For evidence-bearing changes:
Validation performed
Commands below ran on
5881a830f(mergesupstream/mainatbd5d189a8, after an earlier merge of4a4bbab3c), Windows x64, Node.js v26.12.0. The merge commits alone did not carry the resolution for files that merged cleanly, so the family scope and its tests are committed separately in5881a830f; the tree it commits is the tree these commands ran against.npm ciandnpm run build:cached— clean; the build regenerated the catalog digests and the recorded MCP catalog without a changenpm run check:fast(typecheck + lint, includingverify:module-boundaries) — 2 tasks successful, 0 errorsnpm run test:focusedovertoolFamiliesMcpandmcpDoctor— 27 passednpm run test:focusedoverdeferredRuntimeandpromptMcp— 42 passed, including the new scoped-registration case and the phase test that keeps the deferred entry from loading the schema graphnpm run test:focusedoverserverIdentity,sessionMcp,compactInputSchemaMcp,outputSchemaProfile— 32 passed, 1 failed. The failure is the pre-existing win32 case atserverIdentity.test.ts:213: it comparesresolve("/packaged/rea.mjs")with the literal POSIX path, which resolves toC:\packaged\rea.mjs. I checked out unmodifiedupstream/mainat4a4bbab3c, built it, and the same case fails there identically, so it is not caused by this PR.npm run test:localoversrc/contracts/toolFamilies.test.tsandtests/conformance/contracts/mcpToolFamilies.test.ts— 12 passed, including the new assertion that the id inventory and the definitions stay one listnpm run docs:check— pass, including the family catalog read fromTOOL_FAMILY_DEFINITIONS; the builder throws when the families do not coverTOOL_CONTRACTSrea mcpover stdio: unset 213 tools / 6 prompts,session23/3,session,native46/3,session,enhanced37/3,direct41/0,browser12/0. No listed prompt names a hidden tool,inspect_machois refused with-32602outsidenative, andsession,typofails startup.REA_MCP_TOOL_FAMILIES=session: 23 tools listed andbinary_sessionsucceeds. Before the composition fix this path listed 213 tools and failed every call withMCP catalog identity does not match runtime.REA_MCP_TOOL_FAMILIES=session node scripts/rea.mjs mcp doctor --json— healthy, 23/23 tools, expected and observed catalog digest equalrea capabilities --json— unset andREA_MCP_INPUT_SCHEMA_PROFILE=compactshare digests;fulldiffers, so #5975's compact default survives the mergedist— equals the default server identity (213 tools / 6 prompts) and differs fromfull, matching whatscripts/verify-claude-client.mjsnow assertsnpm run verify:claude-client(needs the Claude Code CLI and a host account); a deliberately slow or unresponsiveREA_EVM_PRLIMIT_COMMANDmount (the probe is no longer attempted rather than bounded); real Hopper/Ghidra provider workloads (no installation available).Compatibility, safety, and release
!/BREAKING CHANGEmarker.Author readiness
Human owner: @0xLLVEL
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.