[PR #3048] fix(android): decode guardian readiness across UTF-8 chunks #5580

Open
opened 2026-10-31 01:07:44 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3048
Author: @LcokHcak
Created: 10/14/2026
Status: 🔄 Open

Base: main ← Head: codex/rea-guardian-readiness-utf8


📝 Commits (2)

  • 8424e9e fix(android): decode guardian readiness across UTF-8 chunks
  • b032408 test(android): cover guardian readiness byte limits

📊 Changes

2 files changed (+104 additions, -15 deletions)

View changed files

📝 src/android/JadxWorkspaceRoot.ts (+41 -15)
➕ tests/boundary/android/guardianReadiness.test.ts (+63 -0)

📄 Description

Summary

  • Decode the Windows guardian readiness line after collecting complete UTF-8 bytes, so a Unicode TEMP path remains exact when pipe chunks split a character.
  • Enforce the readiness limit in bytes and reject invalid UTF-8.
  • Remove the data listener after the first line while retaining stdout error handling.

Verification

  • A controlled split-byte reproduction with a synthetic Unicode path showed that the old per-chunk decoding changed the path.
  • npx vitest run tests/boundary/android/guardianReadiness.test.ts tests/boundary/android/workspaceGuardianRetry.test.ts — 4 passed on Windows after rebasing onto current main.
  • npm run check:fast — 2 tasks passed (typecheck, lint).
  • Targeted oxfmt --check, oxlint, and git show --check passed.

No real JADX/APK provider run was performed for this narrow guardian readiness change. Follow-up to #2440.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3048 **Author:** [@LcokHcak](https://github.com/LcokHcak) **Created:** 10/14/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/rea-guardian-readiness-utf8` --- ### 📝 Commits (2) - [`8424e9e`](https://github.com/morluto/rea/commit/8424e9e0a4307d35e8fbfe2d443a48d41d884ac4) fix(android): decode guardian readiness across UTF-8 chunks - [`b032408`](https://github.com/morluto/rea/commit/b032408f16fd3ee4d9fb4f9a256717fe11974705) test(android): cover guardian readiness byte limits ### 📊 Changes **2 files changed** (+104 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/android/JadxWorkspaceRoot.ts` (+41 -15) ➕ `tests/boundary/android/guardianReadiness.test.ts` (+63 -0) </details> ### 📄 Description ## Summary - Decode the Windows guardian readiness line after collecting complete UTF-8 bytes, so a Unicode TEMP path remains exact when pipe chunks split a character. - Enforce the readiness limit in bytes and reject invalid UTF-8. - Remove the data listener after the first line while retaining stdout error handling. ## Verification - A controlled split-byte reproduction with a synthetic Unicode path showed that the old per-chunk decoding changed the path. - `npx vitest run tests/boundary/android/guardianReadiness.test.ts tests/boundary/android/workspaceGuardianRetry.test.ts` — 4 passed on Windows after rebasing onto current main. - `npm run check:fast` — 2 tasks passed (typecheck, lint). - Targeted `oxfmt --check`, `oxlint`, and `git show --check` passed. No real JADX/APK provider run was performed for this narrow guardian readiness change. Follow-up to #2440. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#5580
No description provided.