[PR #3050] [MERGED] test(applications): import capture fixtures through file URLs #5582

New issue

Closed

opened 2026-10-31 01:07:45 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3050
Author: @GuilhermeFusari
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/15/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/windows-esm-fixture-file-url

📝 Commits (2)

8a695d1 test(applications): import capture fixtures through file URLs
011be9c test(applications): execute ESM fixtures through encoded file URLs

📊 Changes

1 file changed (+7 additions, -2 deletions)

View changed files

📝 tests/acceptance/applications/applicationWorkflowCli.test.ts (+7 -2)

📄 Description

Summary

The capture-lifetime acceptance fixture passed a raw filesystem path to Node's ESM import(). Windows drive paths are URL schemes to the loader; # in a POSIX path becomes a fragment. Convert the selected path once with pathToFileURL(...).href at the fixture execution boundary.

The existing public CLI/MCP case now uses a test-owned child directory containing spaces and #, so Linux also catches regression. Both authored modules still execute independently of REA analysis, and all captured-value, comparison and provenance assertions remain. The original 20s timeout is unchanged. Only one test file changes; no runtime or caching policy changes.

Refreshed on main 5b16f2431, including #3049 and the latest literal byte-limit implementation. The complete post-merge main file passed all 34 cases before this change. With only the legal special-character child directory added, the original raw-path import fails with ERR_MODULE_NOT_FOUND at the real Node ESM loader (one selected case); this is the negative control, not a semantic failure.

Validation

Linux x64 / Node24.18.0, two cores, 1.5GiB Node heap: complete acceptance file 34 passed. Wall 85.00s, child user/system CPU 88.28/20.96s, sampled family peak RSS 1.97GiB. Warm artifacts, fresh test/CLI/MCP processes. RSS can count shared pages repeatedly and miss short/reparented children; wrapper CPU excluded. Agent tokens unmeasured. No speedup claim.
The valid raw-path negative control fails at the actual ESM loader; unchanged-main full-file verification before this change passes all 34 cases.
check:ci (eight tasks and 1439 architecture guards) and normal pre-push passed.
Native Windows x64 / Node24.18.0: unchanged main 5b16f2431 fails the selected fixture at the actual ESM loader with ERR_UNSUPPORTED_ESM_URL_SCHEME. Candidate 011be9c3d passes the complete file: 34 passed, zero skips, including #3049 transport integration. Reports and source-identity receipt were downloaded and checked. Diagnostic commit 43303502e differs only in ci.yml; the gate restores and verifies clean candidate source. Baseline failed command 4.89s versus full completed file 56.51s are different workloads, not a speed comparison. Hosted CPU/peak memory and isolated cold-MCP Windows timing were not measured. The full file retains one shared stateless MCP connection; the changed capture case took 3.10s in that context.
Complete current-head CI passed, including all five shards, Portable tests and the required gate. Its merged report confirms 34 tests from this file executed. All 35 job results were checked through the paged API, including jobs omitted by the installed older CLI. Additional Go metadata, packet-capture and signal-recording checks passed.
Codex and Greptile reviewed 011be9c3d without findings; no unresolved threads. No test/timeout/runner-condition retry was needed for this head. The initial synchronize run was superseded by the reopened-event run; source was unchanged.

Original contributor: @GuilhermeFusari. The user delegated follow-up implementation, technical review, ready-for-review update and merge. Assistant technical review is reported; a separate human reread is not claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3050 **Author:** [@GuilhermeFusari](https://github.com/GuilhermeFusari) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/15/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/windows-esm-fixture-file-url` --- ### 📝 Commits (2) - [`8a695d1`](https://github.com/morluto/rea/commit/8a695d1585b639eca26f3dbaa2dc0b2165275efe) test(applications): import capture fixtures through file URLs - [`011be9c`](https://github.com/morluto/rea/commit/011be9c3d51a546fa6616145173e4c77b2d103f0) test(applications): execute ESM fixtures through encoded file URLs ### 📊 Changes **1 file changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/acceptance/applications/applicationWorkflowCli.test.ts` (+7 -2) </details> ### 📄 Description ## Summary The capture-lifetime acceptance fixture passed a raw filesystem path to Node's ESM `import()`. Windows drive paths are URL schemes to the loader; `#` in a POSIX path becomes a fragment. Convert the selected path once with `pathToFileURL(...).href` at the fixture execution boundary. The existing public CLI/MCP case now uses a test-owned child directory containing spaces and `#`, so Linux also catches regression. Both authored modules still execute independently of REA analysis, and all captured-value, comparison and provenance assertions remain. The original 20s timeout is unchanged. Only one test file changes; no runtime or caching policy changes. Refreshed on main `5b16f2431`, including #3049 and the latest literal byte-limit implementation. The complete post-merge main file passed all 34 cases before this change. With only the legal special-character child directory added, the original raw-path import fails with `ERR_MODULE_NOT_FOUND` at the real Node ESM loader (one selected case); this is the negative control, not a semantic failure. ## Validation - Linux x64 / Node24.18.0, two cores, 1.5GiB Node heap: complete acceptance file **34 passed**. Wall **85.00s**, child user/system CPU **88.28/20.96s**, sampled family peak RSS **1.97GiB**. Warm artifacts, fresh test/CLI/MCP processes. RSS can count shared pages repeatedly and miss short/reparented children; wrapper CPU excluded. Agent tokens unmeasured. No speedup claim. - The valid raw-path negative control fails at the actual ESM loader; unchanged-main full-file verification before this change passes all 34 cases. - `check:ci` (eight tasks and 1439 architecture guards) and normal pre-push passed. - [Native Windows x64 / Node24.18.0](https://github.com/morluto/rea/actions/runs/38765273330): unchanged main `5b16f2431` fails the selected fixture at the actual ESM loader with **`ERR_UNSUPPORTED_ESM_URL_SCHEME`**. Candidate `011be9c3d` passes the **complete file: 34 passed, zero skips**, including #3049 transport integration. Reports and source-identity receipt were downloaded and checked. Diagnostic commit `43303502e` differs only in `ci.yml`; the gate restores and verifies clean candidate source. Baseline failed command **4.89s** versus full completed file **56.51s** are different workloads, not a speed comparison. Hosted CPU/peak memory and isolated cold-MCP Windows timing were not measured. The full file retains one shared stateless MCP connection; the changed capture case took **3.10s** in that context. - [Complete current-head CI](https://github.com/morluto/rea/actions/runs/38765432469) passed, including all five shards, Portable tests and the required gate. Its merged report confirms **34 tests** from this file executed. All 35 job results were checked through the paged API, including jobs omitted by the installed older CLI. Additional Go metadata, packet-capture and signal-recording checks passed. - Codex and Greptile reviewed `011be9c3d` without findings; no unresolved threads. No test/timeout/runner-condition retry was needed for this head. The initial synchronize run was superseded by the reopened-event run; source was unchanged. Original contributor: @GuilhermeFusari. The user delegated follow-up implementation, technical review, ready-for-review update and merge. Assistant technical review is reported; a separate human reread is not claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:45 +00:00