[PR #3077] [CLOSED] fix(session): report adb, apktool, and jeb readiness #5596

New issue

Closed

opened 2026-10-31 01:07:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:07:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3077
Author: @chessing234
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/session-external-engine-availability

📝 Commits (3)

d15db90 fix(session): probe adb, apktool, and jeb before reporting them missing
4d2ea92 test(session): cover external engine availability reasons
165b14d fix(session): probe adb on the provider and keep JEB setup guidance

📊 Changes

6 files changed (+266 additions, -28 deletions)

View changed files

📝 src/application/CapabilityInventory.test.ts (+96 -0)
📝 src/application/CapabilityInventory.ts (+74 -23)
📝 src/jeb/JebProvider.ts (+2 -0)
📝 src/server/createServer.ts (+5 -0)
📝 src/server/registerSessionStatusTool.ts (+35 -5)
📝 src/server/registerSessionTools.ts (+54 -0)

📄 Description

Summary

binary_session now probes the configured ADB binary, Apktool launcher, and JEB MCP endpoint before filling tool_availability.
A missing engine gets that engine's remediation instead of the generic provider_missing line. A JEB client that is up but does not advertise open_project (typical of headless builds) keeps open_jeb_project unavailable for that reason.
Fixes #3067, #3068, and #3069.

Test plan

vitest run src/application/CapabilityInventory.test.ts src/jeb/JebProvider.test.ts
binary_session with REA_ADB_PATH set reports inspect_adb_client available
binary_session with REA_APKTOOL_COMMAND set reports both apktool tools available
with nothing on REA_JEB_MCP_URL, the JEB tools stay unavailable and name REA_JEB_MCP_URL

Made with Cursor

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3077 **Author:** [@chessing234](https://github.com/chessing234) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/session-external-engine-availability` --- ### 📝 Commits (3) - [`d15db90`](https://github.com/morluto/rea/commit/d15db9019a14a16dd448e21541a77d83f5c9d0a1) fix(session): probe adb, apktool, and jeb before reporting them missing - [`4d2ea92`](https://github.com/morluto/rea/commit/4d2ea92732dc6ae3373f752cd97c48063efc2cf4) test(session): cover external engine availability reasons - [`165b14d`](https://github.com/morluto/rea/commit/165b14da9e5213efb272e047f46c199fa9f63c28) fix(session): probe adb on the provider and keep JEB setup guidance ### 📊 Changes **6 files changed** (+266 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/application/CapabilityInventory.test.ts` (+96 -0) 📝 `src/application/CapabilityInventory.ts` (+74 -23) 📝 `src/jeb/JebProvider.ts` (+2 -0) 📝 `src/server/createServer.ts` (+5 -0) 📝 `src/server/registerSessionStatusTool.ts` (+35 -5) 📝 `src/server/registerSessionTools.ts` (+54 -0) </details> ### 📄 Description ## Summary - `binary_session` now probes the configured ADB binary, Apktool launcher, and JEB MCP endpoint before filling `tool_availability`. - A missing engine gets that engine's remediation instead of the generic `provider_missing` line. A JEB client that is up but does not advertise `open_project` (typical of headless builds) keeps `open_jeb_project` unavailable for that reason. - Fixes #3067, #3068, and #3069. ## Test plan - [x] `vitest run src/application/CapabilityInventory.test.ts src/jeb/JebProvider.test.ts` - [ ] `binary_session` with `REA_ADB_PATH` set reports `inspect_adb_client` available - [ ] `binary_session` with `REA_APKTOOL_COMMAND` set reports both apktool tools available - [ ] with nothing on `REA_JEB_MCP_URL`, the JEB tools stay unavailable and name `REA_JEB_MCP_URL` Made with [Cursor](https://cursor.com) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:07:51 +00:00