morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #3104] [MERGED] fix(electron): preserve selected fuse inspection paths #5619

New issue
Closed
opened 2026-10-31 01:08:01 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 01:08:01 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3104
Author: @shoyann
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/14/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/electron-fuse-cli-path

📝 Commits (3)

  • 852325e fix(electron): preserve selected fuse inspection paths
  • 447682e chore(electron): integrate selected-path fix with current main
  • 7566a8e chore(electron): synchronize verification with latest main

📊 Changes

5 files changed (+304 additions, -29 deletions)

View changed files

📝 docs/electron-fuses.md (+5 -0)
📝 src/cli/electronCommands.ts (+12 -2)
📝 src/electron/ElectronFusePath.ts (+61 -15)
📝 src/electron/ElectronFuseProvider.test.ts (+17 -0)
📝 tests/acceptance/electronFusesCli.test.ts (+209 -12)

📄 Description

Summary

inspect-electron-fuses could successfully report a digest and fuse states for the wrong executable. On POSIX, a selected path containing Current/../ follows the symlink before its parent component; the CLI's path.resolve() instead removed those components lexically. Preserve the selected filesystem target through the CLI and the Electron bundle path owner.

No separate issue: this is a directly reproduced follow-up to the accepted path-preservation correction in #2399.

Problem and expected behavior

With Versions/Current -> nested/B, selecting Versions/Current/../A/Electron Framework means Versions/nested/A/Electron Framework. The CLI inspected Versions/A/Electron Framework instead. Two synthetic files with opposing fuse states demonstrated both a different SHA-256 and opposite reported implications.

The same problem affected an application selected through Current/../Fixture.app: correcting the CLI alone was insufficient because subsequent provider join() calls collapsed the selected parent path again.

Expected: inspect the caller-selected file, keep its selection in Evidence, and preserve existing bundle admission and identity checks.

Change and scope

  • Anchor relative POSIX inputs without normalizing their components. Keep Windows CLI resolution unchanged because Win32 uses different dot-component semantics.
  • Append known child components without reinterpreting the selected parent inside the Electron path owner.
  • Preserve ordinary directory selections ending in . or .. using filesystem checks, retaining checked directory identities for readback validation. Refuse ambiguous terminal parent traversal through a symlink instead of silently selecting a lexical sibling.

This is an ordinary correctness fix in existing read-only fuse inspection; a new capability scope decision is not applicable. No target is launched and no fuse is changed.

Contract and boundary impact

  • Semantic owner: CLI input anchoring and ElectronFusePath filesystem traversal.
  • CLI/MCP contract: existing command/tool and schemas unchanged; provider correction also applies to shared-service callers.
  • Platform compatibility: POSIX link/parent semantics are preserved; Windows keeps its existing CLI resolution.
  • Evidence/provenance: selected path, inspected bytes, digest and derived fuse implications refer to the same artifact.
  • Authority/cleanup: existing filesystem admission and identity rechecks remain; no execution or mutation authority is added.
  • Generated metadata/package impact: none.

Expected effects:

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Public CLI regressions cover absolute and relative binary/application paths with a symlink before .., using distinct expected and decoy files. Assertions check selected and resolved paths, Evidence digest and fuse implications; direct-file controls verify the opposing fixture.
  • Directory selection controls cover trailing/current/parent components and preserve symlink rejection.
  • Base reproduction: all four new wrong-file cases failed on b3c5672c. A CLI-only patch fixed the binary pair but left the application pair failing, demonstrating why the owning traversal also needs correction.
  • An independent native Windows filesystem probe (Node 24.16.0, NTFS junction and two harmless marker files) confirmed that Win32 reads the lexical sibling for link/../. Repository checks use pinned Node 24.18.0 in WSL Ubuntu.
  • Remaining proof gaps: no native Windows/macOS REA run and no actual Electron application execution. Tests inspect synthetic files through the real CLI/provider; runtime behavior is not claimed.

For evidence-bearing changes:

  • Observations and derived fuse implications remain distinguishable.
  • Artifact identity and source provenance remain preserved.
  • Unsupported and unverified outcomes remain explicit.

Validation performed

  • npm run test:focused -- tests/acceptance/electronFusesCli.test.ts src/electron/ElectronFuseProvider.test.ts tests/boundary/mcp/electronFusesMcp.test.ts src/domain/electron/electronFuses.test.ts: 41 passed, one Windows-only CLI test skipped on Linux; four files passed.
  • npm run check: passed, including six static tasks and architecture guards.
  • npm run verify:test-discovery: passed, 1,242 test files.
  • npm run docs:check: passed, including five README consistency tests.
  • git diff --check: passed.

Compatibility, safety, and release

No new dependency, public schema, release metadata or target-execution capability. No binary mutation. Terminal symlink/parent directory selections that cannot be reduced while preserving admission are rejected with the existing typed input-error shape. Verification used owned synthetic files on Linux and a separate native Windows filesystem probe.

Before merge

  • This PR addresses a concrete problem within existing scope.
  • The PR has one focused outcome and a Conventional Commit title.
  • The reason for not linking an issue is stated above.
  • Regression coverage checks observable artifact selection and failure paths.
  • Owning documentation describes path behavior; public schemas and generated metadata are unchanged.
  • Representative CLI and filesystem evidence is included.
  • Final diff and validation reviewed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3104 **Author:** [@shoyann](https://github.com/shoyann) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/14/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/electron-fuse-cli-path` --- ### 📝 Commits (3) - [`852325e`](https://github.com/morluto/rea/commit/852325ee11747e365409d95a79a0196d06ab3098) fix(electron): preserve selected fuse inspection paths - [`447682e`](https://github.com/morluto/rea/commit/447682e131ccc0bc85b81c9d988f67cbb07c78bf) chore(electron): integrate selected-path fix with current main - [`7566a8e`](https://github.com/morluto/rea/commit/7566a8e28ef2594e30b31d74992ddab12de40831) chore(electron): synchronize verification with latest main ### 📊 Changes **5 files changed** (+304 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `docs/electron-fuses.md` (+5 -0) 📝 `src/cli/electronCommands.ts` (+12 -2) 📝 `src/electron/ElectronFusePath.ts` (+61 -15) 📝 `src/electron/ElectronFuseProvider.test.ts` (+17 -0) 📝 `tests/acceptance/electronFusesCli.test.ts` (+209 -12) </details> ### 📄 Description ## Summary `inspect-electron-fuses` could successfully report a digest and fuse states for the wrong executable. On POSIX, a selected path containing `Current/../` follows the symlink before its parent component; the CLI's `path.resolve()` instead removed those components lexically. Preserve the selected filesystem target through the CLI and the Electron bundle path owner. No separate issue: this is a directly reproduced follow-up to the accepted path-preservation correction in [#2399](https://github.com/morluto/rea/pull/2399#discussion_r4260613048). ## Problem and expected behavior With `Versions/Current -> nested/B`, selecting `Versions/Current/../A/Electron Framework` means `Versions/nested/A/Electron Framework`. The CLI inspected `Versions/A/Electron Framework` instead. Two synthetic files with opposing fuse states demonstrated both a different SHA-256 and opposite reported implications. The same problem affected an application selected through `Current/../Fixture.app`: correcting the CLI alone was insufficient because subsequent provider `join()` calls collapsed the selected parent path again. Expected: inspect the caller-selected file, keep its selection in Evidence, and preserve existing bundle admission and identity checks. ## Change and scope - Anchor relative POSIX inputs without normalizing their components. Keep Windows CLI resolution unchanged because Win32 uses different dot-component semantics. - Append known child components without reinterpreting the selected parent inside the Electron path owner. - Preserve ordinary directory selections ending in `.` or `..` using filesystem checks, retaining checked directory identities for readback validation. Refuse ambiguous terminal parent traversal through a symlink instead of silently selecting a lexical sibling. This is an ordinary correctness fix in existing read-only fuse inspection; a new capability scope decision is not applicable. No target is launched and no fuse is changed. ## Contract and boundary impact - Semantic owner: CLI input anchoring and `ElectronFusePath` filesystem traversal. - CLI/MCP contract: existing command/tool and schemas unchanged; provider correction also applies to shared-service callers. - Platform compatibility: POSIX link/parent semantics are preserved; Windows keeps its existing CLI resolution. - Evidence/provenance: selected path, inspected bytes, digest and derived fuse implications refer to the same artifact. - Authority/cleanup: existing filesystem admission and identity rechecks remain; no execution or mutation authority is added. - Generated metadata/package impact: none. Expected effects: - [x] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Public CLI regressions cover absolute and relative binary/application paths with a symlink before `..`, using distinct expected and decoy files. Assertions check selected and resolved paths, Evidence digest and fuse implications; direct-file controls verify the opposing fixture. - Directory selection controls cover trailing/current/parent components and preserve symlink rejection. - Base reproduction: all four new wrong-file cases failed on `b3c5672c`. A CLI-only patch fixed the binary pair but left the application pair failing, demonstrating why the owning traversal also needs correction. - An independent native Windows filesystem probe (Node 24.16.0, NTFS junction and two harmless marker files) confirmed that Win32 reads the lexical sibling for `link/../`. Repository checks use pinned Node 24.18.0 in WSL Ubuntu. - Remaining proof gaps: no native Windows/macOS REA run and no actual Electron application execution. Tests inspect synthetic files through the real CLI/provider; runtime behavior is not claimed. For evidence-bearing changes: - [x] Observations and derived fuse implications remain distinguishable. - [x] Artifact identity and source provenance remain preserved. - [x] Unsupported and unverified outcomes remain explicit. ## Validation performed - `npm run test:focused -- tests/acceptance/electronFusesCli.test.ts src/electron/ElectronFuseProvider.test.ts tests/boundary/mcp/electronFusesMcp.test.ts src/domain/electron/electronFuses.test.ts`: **41 passed**, one Windows-only CLI test skipped on Linux; four files passed. - `npm run check`: passed, including six static tasks and architecture guards. - `npm run verify:test-discovery`: passed, 1,242 test files. - `npm run docs:check`: passed, including five README consistency tests. - `git diff --check`: passed. ## Compatibility, safety, and release No new dependency, public schema, release metadata or target-execution capability. No binary mutation. Terminal symlink/parent directory selections that cannot be reduced while preserving admission are rejected with the existing typed input-error shape. Verification used owned synthetic files on Linux and a separate native Windows filesystem probe. ## Before merge - [x] This PR addresses a concrete problem within existing scope. - [x] The PR has one focused outcome and a Conventional Commit title. - [x] The reason for not linking an issue is stated above. - [x] Regression coverage checks observable artifact selection and failure paths. - [x] Owning documentation describes path behavior; public schemas and generated metadata are unchanged. - [x] Representative CLI and filesystem evidence is included. - [x] Final diff and validation reviewed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 01:08:01 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#5619
No description provided.