[PR #3119] [MERGED] fix(ci): check authored documentation code #5626

New issue

Closed

opened 2026-10-31 01:08:05 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3119
Author: @N0zoM1z0
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/14/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/ci-authored-docs-checks

📝 Commits (4)

eeafead fix(ci): check authored documentation code
b6cba39 fix(ci): handle line breaks in documentation paths
190c6bc test(ci): use a portable line separator fixture
e6bba0e chore(ci): integrate current main verification fixes

📊 Changes

2 files changed (+48 additions, -1 deletions)

View changed files

📝 scripts/ci/plan.mjs (+2 -0)
📝 tests/boundary/filesystem/ciChangeScope.test.ts (+46 -1)

📄 Description

A change confined to docs/.vitepress/config.ts previously selected documentation checks but skipped check:ci. An injected TypeScript error passed formatting and documentation validation while the owning typechecker rejected it.

The planner now selects portable code/static checks for authored JS/TS documentation files, including hidden VitePress directories and removed paths. Markdown-only changes retain their existing documentation route. No native/provider lane is added for these documentation files; the existing portable checks remain required.

Closes #3116.

Validation on Node 24.18.0 / npm 11.16.0, Linux x64:

New regression expectations fail against the original planner: 10 failures for supported extensions, the actual config, and a rename into Markdown. An additional embedded-line-separator filename control failed against the initial implementation and now passes with the corrected path predicate.
Focused selection, required-lane, static-cache and feedback suites: 4 files / 233 tests passed.
npm run check:ci passed; discovery found all 1,242 test files exactly once.
Actual malformed-config control: format:check and docs:check exit 0; tsc --noEmit exits 1 with TS2322. The fault was restored. The corrected planner selects the code checks that catch it.

Performance: 10 alternating warm process runs per workload/implementation, after one warm-up, on the same local host (AMD EPYC 7B12, approximately 64 GiB total memory). Median planner elapsed time was 66.2→65.6 ms for Markdown and 66.6→66.2 ms for typed configuration; corresponding median CPU 73.6→72.4 ms and 72.9→73.7 ms. These differences are within noise, not a claimed speedup. The change adds one path predicate without extra traversal, subprocesses or output. The whole instrumented comparison sampled 64.5 MiB peak summed process-family RSS (200 ms sampling; shared pages may be counted twice). Final static validation took approximately 15 s and the focused guard tests approximately 35 s; those commands overlapped, so their timings are diagnostics rather than comparative benchmarks. Agent token usage was not measured. This fix intentionally restores necessary checks rather than reducing their coverage.

Updated against main at 7ad75bdc80d1d45dd9fb4c0b3153997cb392a710 after #3080 merged. The final combined tree passed 236 focused tests across the selector and actual CLI/MCP application regressions. Four fresh scoped application analyses also passed, including the repository's Notes Electron example (one BrowserWindow, one context bridge and two IPC operations; zero parse failures). Prepared-build measurement for those four analyses: 4.03 s elapsed, 4.87 s user+system CPU, 245 MiB sampled peak summed process-family RSS (200 ms). This is current-workload validation, not a comparative performance claim. Targets were analyzed statically; no Electron target was launched. Complete Evidence was retained outside the tracked tree. No assertion or gate is weakened here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3119 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/14/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/ci-authored-docs-checks` --- ### 📝 Commits (4) - [`eeafead`](https://github.com/morluto/rea/commit/eeafead33395a9a6ac030c87da8ad024a850e602) fix(ci): check authored documentation code - [`b6cba39`](https://github.com/morluto/rea/commit/b6cba39c6b8968afcc8d8fc3c39d61ac8e8b45bb) fix(ci): handle line breaks in documentation paths - [`190c6bc`](https://github.com/morluto/rea/commit/190c6bcf665132721ac71ba4b2b4b912e20ecc31) test(ci): use a portable line separator fixture - [`e6bba0e`](https://github.com/morluto/rea/commit/e6bba0efea285da450b59767d5d09528ba2d8103) chore(ci): integrate current main verification fixes ### 📊 Changes **2 files changed** (+48 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `scripts/ci/plan.mjs` (+2 -0) 📝 `tests/boundary/filesystem/ciChangeScope.test.ts` (+46 -1) </details> ### 📄 Description A change confined to `docs/.vitepress/config.ts` previously selected documentation checks but skipped `check:ci`. An injected TypeScript error passed formatting and documentation validation while the owning typechecker rejected it. The planner now selects portable code/static checks for authored JS/TS documentation files, including hidden VitePress directories and removed paths. Markdown-only changes retain their existing documentation route. No native/provider lane is added for these documentation files; the existing portable checks remain required. Closes #3116. Validation on Node 24.18.0 / npm 11.16.0, Linux x64: - New regression expectations fail against the original planner: 10 failures for supported extensions, the actual config, and a rename into Markdown. An additional embedded-line-separator filename control failed against the initial implementation and now passes with the corrected path predicate. - Focused selection, required-lane, static-cache and feedback suites: **4 files / 233 tests passed**. - `npm run check:ci` passed; discovery found all **1,242 test files exactly once**. - Actual malformed-config control: `format:check` and `docs:check` exit 0; `tsc --noEmit` exits 1 with TS2322. The fault was restored. The corrected planner selects the code checks that catch it. Performance: 10 alternating warm process runs per workload/implementation, after one warm-up, on the same local host (AMD EPYC 7B12, approximately 64 GiB total memory). Median planner elapsed time was 66.2→65.6 ms for Markdown and 66.6→66.2 ms for typed configuration; corresponding median CPU 73.6→72.4 ms and 72.9→73.7 ms. These differences are within noise, **not a claimed speedup**. The change adds one path predicate without extra traversal, subprocesses or output. The whole instrumented comparison sampled 64.5 MiB peak summed process-family RSS (200 ms sampling; shared pages may be counted twice). Final static validation took approximately 15 s and the focused guard tests approximately 35 s; those commands overlapped, so their timings are diagnostics rather than comparative benchmarks. Agent token usage was not measured. This fix intentionally restores necessary checks rather than reducing their coverage. Updated against `main` at `7ad75bdc80d1d45dd9fb4c0b3153997cb392a710` after #3080 merged. The final combined tree passed 236 focused tests across the selector and actual CLI/MCP application regressions. Four fresh scoped application analyses also passed, including the repository's Notes Electron example (one BrowserWindow, one context bridge and two IPC operations; zero parse failures). Prepared-build measurement for those four analyses: 4.03 s elapsed, 4.87 s user+system CPU, 245 MiB sampled peak summed process-family RSS (200 ms). This is current-workload validation, not a comparative performance claim. Targets were analyzed statically; no Electron target was launched. Complete Evidence was retained outside the tracked tree. No assertion or gate is weakened here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:05 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5626

No description provided.

Rows
Columns