mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-15 18:26:11 +00:00 by bsakaguchi
·
1 comment
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#563
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @CassieFox23 on GitHub (Oct 11, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/1665
TL;DR: The getter fix for #1494 works for its six shapes. But four other getter shapes still give a wrong
literal 1, withcompletecoverage. Real JavaScript gives 2 in all four. Three of them come from my #1569 test. The fourth,super.v, was right on #1569 but is wrong on main.Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
I tested main
4733fc810. It has both getter fixes,bc7846db9and639b73097. These four shapes reportliteral 1withcompletecoverage. Real JavaScript gives 2.4733fc810this,box.self.x = 2; return box.xliteral 1this.s, wheresis the shared objectliteral 1this.#sliteral 1super.v,new B().v.x = 2literal 1The result was the same on Node 22.23.1, 24.18.0 and 26.11.1 over the CLI, and on Node 24.18.0 over MCP.
Reproduction
app.jsin an empty folder:node scripts/rea.mjs analyze-javascript-application <folder> --artifact-format directory --json.result. It saysliteral 1, withcompletecoverage.The other three shapes are in the fold below.
Expected behavior
unknown, as the six #1494 shapes now give. Or the right value, 2.Impact and scope
A caller reads a wrong value as complete. All four shapes write through an object that a getter returns. In each one, the getter returns the shared object by another route:
this, a property ofthis, a private field, orsuper.Not affected, on main: the six #1494 shapes now give
unknown. 22 of the 26 extra probes from my #1569 test giveunknownor the right literal. All six probes that should stayliteral 1still do. That includes a getter read with no write, which #1569 had turned intounknown.REA version
main
4733fc810, built from source. Main has moved to69a8b3a95, which changes no JavaScript analysis files.Runtime and platform
Nobara 44 (Fedora 44 base), Linux 7.2.9, x86-64. Node 22.23.1, 24.18.0 and 26.11.1.
Target and artifact context
Small ES modules, one per shape, read as a directory.
Interface
CLI
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
The other three shapes
All 26 extra probes, across three builds
Real JS is from plain Node. Coverage was
completein every cell. The PR column is from my #1569 comment, not rerun.6d8f95e38(#1580)80b186b62(#1569)4733fc810{ x: 1 };box.v.x = 2; return shared.xliteral 1literal 1literal 1this;box.self.x = 2; return box.xliteral 1(wrong)literal 1(wrong)literal 1(wrong)super.v;new B().v.x = 2literal 1(wrong)unknownliteral 1(wrong)Object.create(proto).v.x = 2unknownunknownunknownbox.v = { x: 2 }literal 1literal 1literal 1shared.x = a;box.v = 5unknownunknownunknownnew B().v.x = 2(B extends A)literal 1(wrong)unknownunknownshared.inner;box.v.x = 2literal 1(wrong)unknownunknownbox.v.x = 2; box.v.x = 3literal 1(wrong)unknownunknownconst t = box.v; t.x = 2; box.v.x = 3literal 1(wrong)unknownunknownconst { v } = box; v.x = 2literal 1(wrong)literal 1(wrong)unknownconst copy = { ...box }; copy.v.x = 2literal 1(wrong)unknownunknownw(box)unknownunknownunknownthis.s, wheresis the shared objectliteral 1(wrong)literal 1(wrong)literal 1(wrong)get 1()andbox[1].x = 2literal 1(wrong)unknownunknownget "a-b"()andbox["a-b"].x = 2literal 1(wrong)unknownunknown[shared.x];box.v[0] = 2literal 1literal 1literal 1box.v.x++literal 1(wrong)unknownunknowndelete box.v.xliteral 1(wrong)unknownunknownsharedunknownunknownunknownObject.assign(box.v, { x: 2 })unknownunknownunknownReflect.get(box, "v").x = 2unknownunknownunknownthis.#sliteral 1(wrong)literal 1(wrong)literal 1(wrong)(true ? box.v : {}).x = 2literal 1(wrong)unknownunknownconst k = box.v; const m = k.x;with no writeliteral 1unknownliteral 1vexists, but the write isbox.w.x = 2literal 1literal 1literal 1I rebuilt the 26 probes from the fold of my #1569 comment. As a check, I ran them on
6d8f95e38(#1580). All 26 gave the same value as in that comment.Typed outcome or recovery expected
unknownwith the usual coverage note, as the six #1494 shapes now give.Analysis or suspected cause
I did not read the code for this. I only know which shapes fail. In all four, the getter returns the shared object through
this, a private field orsuper, not by name.Additional context
Follows #1494 and my test of #1569. Thanks, morluto, for the getter fixes in
bc7846db9and639b73097.Test setup
4733fc810npm ciandnpm run build, on Node 24.18.0🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊
@CassieFox23 commented on GitHub (Oct 11, 2026):
TL;DR: All four shapes are fixed in
795693496. Each now givesunknownwithcompletecoverage, not a wrongliteral 1. No other probe changed.What I checked
I built main at
af88184ee, which includes795693496. I ran the four shapes from this issue on Node 22.23.1, 24.18.0 and 26.11.1 over the CLI, and on Node 24.18.0 over MCP. Plain Node gives 2 in all four.4733fc810(earlier run)af88184ee, all four runsthis,box.self.x = 2; return box.xliteral 1unknownthis.sliteral 1unknownthis.#sliteral 1unknownsuper.vliteral 1unknownCoverage was
completein every cell.unknownis the answer this issue asked for.I also reran all 36 probes: the 26 from my #1569 test and the 10 from #1494. Only these four changed from main
4733fc810. All six probes that should stayliteral 1still do. Those are the fresh object, the empty setter, the array wrap, the other property, and two reads with no write. No probe that was right is now wrong. No probe reports a wrong literal.Your two new test files pass on Node 24.18.0: 27 tests, exit code 0. The older #1494 tests also pass: 187 tests, exit code 0. Main has since moved to
f88c99021. That move changes no JavaScript analysis files.Not run
Thanks, morluto, for the fix.
Test setup
af88184eenpm ciandnpm run build, on Node 24.18.0, both exit code 0All 36 probes
The
4733fc810column is from my earlier run, not rerun. Theaf88184eecolumn is the same on all three Node versions over the CLI and on Node 24.18.0 over MCP. Coverage wascompletein every cell. Real JS is from plain Node on all three versions.4733fc810(earlier run)af88184ee(this run){ x: 1 };box.v.x = 2; return shared.xliteral 1literal 1this;box.self.x = 2; return box.xliteral 1(wrong)unknownsuper.v;new B().v.x = 2literal 1(wrong)unknownObject.create(proto).v.x = 2unknownunknownbox.v = { x: 2 }literal 1literal 1shared.x = a;box.v = 5unknownunknownnew B().v.x = 2(B extends A)unknownunknownshared.inner;box.v.x = 2unknownunknownbox.v.x = 2; box.v.x = 3unknownunknownconst t = box.v; t.x = 2; box.v.x = 3unknownunknownconst { v } = box; v.x = 2unknownunknownconst copy = { ...box }; copy.v.x = 2unknownunknownw(box)unknownunknownthis.s, wheresis the shared objectliteral 1(wrong)unknownget 1()andbox[1].x = 2unknownunknownget "a-b"()andbox["a-b"].x = 2unknownunknown[shared.x];box.v[0] = 2literal 1literal 1box.v.x++unknownunknowndelete box.v.xunknownunknownsharedunknownunknownObject.assign(box.v, { x: 2 })unknownunknownReflect.get(box, "v").x = 2unknownunknownthis.#sliteral 1(wrong)unknown(true ? box.v : {}).x = 2unknownunknownconst k = box.v; const m = k.x;with no writeliteral 1literal 1vexists, but the write isbox.w.x = 2literal 1literal 1box.v.x = 2unknownunknownnew B().v.x = 2unknownunknownB.v.x = 2unknownunknownconst t = box.v; t.x = 2unknownunknownunknownunknownunknownunknownunknownunknownunknownunknownObject.definePropertygetterunknownunknownliteral 1literal 1🤖 Generated with Claude Code (Sonnet 5.5, verified by Opus 5.5) 🦊