[PR #3234] [CLOSED] fix(cli): name both recorded-core architectures in the path contract #5663

New issue

Closed

opened 2026-10-31 01:08:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3234
Author: @fengqiaoqu
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: codex/issue-3167-recorded-crash-help

📝 Commits (1)

9720527 fix(cli): name both recorded-core architectures in the path contract

📊 Changes

2 files changed (+50 additions, -1 deletions)

View changed files

📝 src/cli/binaryDiagnosticsCommands.ts (+5 -1)
➕ tests/boundary/cli/recordedCrashHelpArchitectures.test.ts (+45 -0)

📄 Description

Problem

inspect-recorded-crash decodes both supported Linux core profiles — x86_64-little-endian (machine 62) and aarch64-little-endian (machine 183) — and the MCP tool contract already says "Linux ELF64 amd64 or AArch64 little-endian core". The CLI path argument still described only Local Linux amd64 ELF core (#3167), so the CLI help and exported schema omitted the documented AArch64 support that PR #2505 added.

Fix

Align the CLI path description with the MCP contract wording: Local Linux ELF64 amd64 or AArch64 little-endian core. No decoder, acceptance, or option behavior changes.

Validation

New CLI boundary test tests/boundary/cli/recordedCrashHelpArchitectures.test.ts exports the command schema via --schema --json and asserts the path description names both amd64 and AArch64. It fails before the fix and passes after.
npm run check:fast passes.

Fixes #3167

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3234 **Author:** [@fengqiaoqu](https://github.com/fengqiaoqu) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/issue-3167-recorded-crash-help` --- ### 📝 Commits (1) - [`9720527`](https://github.com/morluto/rea/commit/9720527be3e96123d9f48cff3fe3a5ed8b3e1ac6) fix(cli): name both recorded-core architectures in the path contract ### 📊 Changes **2 files changed** (+50 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/binaryDiagnosticsCommands.ts` (+5 -1) ➕ `tests/boundary/cli/recordedCrashHelpArchitectures.test.ts` (+45 -0) </details> ### 📄 Description ## Problem `inspect-recorded-crash` decodes both supported Linux core profiles — `x86_64-little-endian` (machine 62) and `aarch64-little-endian` (machine 183) — and the MCP tool contract already says "Linux ELF64 amd64 or AArch64 little-endian core". The CLI path argument still described only `Local Linux amd64 ELF core` (#3167), so the CLI help and exported schema omitted the documented AArch64 support that PR #2505 added. ## Fix Align the CLI `path` description with the MCP contract wording: `Local Linux ELF64 amd64 or AArch64 little-endian core`. No decoder, acceptance, or option behavior changes. ## Validation - New CLI boundary test `tests/boundary/cli/recordedCrashHelpArchitectures.test.ts` exports the command schema via `--schema --json` and asserts the `path` description names both `amd64` and `AArch64`. It fails before the fix and passes after. - `npm run check:fast` passes. Fixes #3167 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:24 +00:00