[PR #3235] [CLOSED] fix(cli): list retained analysis-view parents the service projects #5664

New issue

Closed

opened 2026-10-31 01:08:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3235
Author: @fengqiaoqu
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: codex/issue-3194-analysis-view-help

📝 Commits (3)

db0112e fix(cli): list retained analysis-view parents the service projects
1fbf633 Merge remote-tracking branch 'origin/main' into HEAD
60e40a2 test(cli): read the inspect-analysis-view description from its help

📊 Changes

2 files changed (+39 additions, -1 deletions)

View changed files

📝 src/cli/analysisViewCommands.ts (+1 -1)
➕ tests/boundary/cli/analysisViewHelpParents.test.ts (+38 -0)

📄 Description

Problem

The shared analysis-view service (src/domain/analysisView/analysisView.ts) projects retained views for far more parents than the CLI help claimed: inspect_web_network_capture, inspect_pcap_capture, inspect_binary_layout, analyze_javascript_application, analyze_function plus the retained projectors for WASM, Mach-O, Interface Builder, EVM, managed, Android package, Dart AOT and artifact inventories. The CLI description only said "layout, JavaScript application or native function Evidence JSON" (#3194), so the documented web-capture view path looked unsupported even though it succeeds.

Fix

Update the inspect-analysis-view description to name every parent family the service actually projects, mirroring the MCP tool contract's parent list. Behavior and validation are unchanged; unsupported parents still receive the typed unsupported_target result.

Validation

New CLI boundary test tests/boundary/cli/analysisViewHelpParents.test.ts exports the command schema via --schema --json and asserts the description names the web network capture and pcap parents. It fails before the fix and passes after.
npm run check:fast passes.

Fixes #3194

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3235 **Author:** [@fengqiaoqu](https://github.com/fengqiaoqu) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/issue-3194-analysis-view-help` --- ### 📝 Commits (3) - [`db0112e`](https://github.com/morluto/rea/commit/db0112e1d25b1f1a9a25a40437058d980fe151d0) fix(cli): list retained analysis-view parents the service projects - [`1fbf633`](https://github.com/morluto/rea/commit/1fbf633e4c7f03afef59d6605a56d82d54ba02f9) Merge remote-tracking branch 'origin/main' into HEAD - [`60e40a2`](https://github.com/morluto/rea/commit/60e40a2591df565184322be07575da780d7de4f5) test(cli): read the inspect-analysis-view description from its help ### 📊 Changes **2 files changed** (+39 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/analysisViewCommands.ts` (+1 -1) ➕ `tests/boundary/cli/analysisViewHelpParents.test.ts` (+38 -0) </details> ### 📄 Description ## Problem The shared analysis-view service (`src/domain/analysisView/analysisView.ts`) projects retained views for far more parents than the CLI help claimed: `inspect_web_network_capture`, `inspect_pcap_capture`, `inspect_binary_layout`, `analyze_javascript_application`, `analyze_function` plus the retained projectors for WASM, Mach-O, Interface Builder, EVM, managed, Android package, Dart AOT and artifact inventories. The CLI description only said "layout, JavaScript application or native function Evidence JSON" (#3194), so the documented web-capture view path looked unsupported even though it succeeds. ## Fix Update the `inspect-analysis-view` description to name every parent family the service actually projects, mirroring the MCP tool contract's parent list. Behavior and validation are unchanged; unsupported parents still receive the typed `unsupported_target` result. ## Validation - New CLI boundary test `tests/boundary/cli/analysisViewHelpParents.test.ts` exports the command schema via `--schema --json` and asserts the description names the web network capture and pcap parents. It fails before the fix and passes after. - `npm run check:fast` passes. Fixes #3194 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:24 +00:00