[PR #3250] [CLOSED] fix(reference): report unsupported non-regular source entries as unknown kind #5675

New issue

Closed

opened 2026-10-31 01:08:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3250
Author: @sx4im
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/3218-fifo-source-import-kind

📝 Commits (2)

57c3058 fix(reference): report unsupported non-regular source entries as unknown kind
1e4c1e9 style(reference): format FIFO kind test per oxfmt

📊 Changes

2 files changed (+59 additions, -1 deletions)

View changed files

📝 src/application/ReferenceSourceImportEntries.test.ts (+58 -0)
📝 src/application/ReferenceSourceImportEntries.ts (+1 -1)

📄 Description

Fixes #3218

What broke
Importing a source tree containing a FIFO reported it as kind "file" with content_state "unreadable", while its own limitation said it is not a regular file. The summary counted it as a file, so one regular file plus one FIFO showed files=2.

What changed
One line in failedEntry (src/application/ReferenceSourceImportEntries.ts): reader kind "other" (FIFO, socket, device) now projects to graph kind "unknown" instead of falling through to "file". A real file that fails to read still projects as kind "file".

How verified
New test fails before the fix (the FIFO entry came out as kind "file") and passes after. Also verified end to end with a real FIFO on disk through the actual reader. Related suites green: ReferenceSourceImportEntries 3/3, ReferenceSourceReaderFile 3/3, referenceSourceGraph + referenceSourceSummary 30/30. tsc clean, oxlint clean.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3250 **Author:** [@sx4im](https://github.com/sx4im) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/3218-fifo-source-import-kind` --- ### 📝 Commits (2) - [`57c3058`](https://github.com/morluto/rea/commit/57c3058d4e013cf6acace8bea1ec0393fa39b5c1) fix(reference): report unsupported non-regular source entries as unknown kind - [`1e4c1e9`](https://github.com/morluto/rea/commit/1e4c1e9b664f5d8144a931b800f96db1db9e3bae) style(reference): format FIFO kind test per oxfmt ### 📊 Changes **2 files changed** (+59 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ReferenceSourceImportEntries.test.ts` (+58 -0) 📝 `src/application/ReferenceSourceImportEntries.ts` (+1 -1) </details> ### 📄 Description Fixes #3218 What broke Importing a source tree containing a FIFO reported it as kind "file" with content_state "unreadable", while its own limitation said it is not a regular file. The summary counted it as a file, so one regular file plus one FIFO showed files=2. What changed One line in failedEntry (src/application/ReferenceSourceImportEntries.ts): reader kind "other" (FIFO, socket, device) now projects to graph kind "unknown" instead of falling through to "file". A real file that fails to read still projects as kind "file". How verified New test fails before the fix (the FIFO entry came out as kind "file") and passes after. Also verified end to end with a real FIFO on disk through the actual reader. Related suites green: ReferenceSourceImportEntries 3/3, ReferenceSourceReaderFile 3/3, referenceSourceGraph + referenceSourceSummary 30/30. tsc clean, oxlint clean. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:31 +00:00