[PR #3259] [CLOSED] fix(rea): explain display-only bundle differences inline #5680

New issue

Closed

opened 2026-10-31 01:08:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3259
Author: @CRYPTONIKAV
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/3216-bundle-delta

📝 Commits (2)

9745152 chore: scratch gitignore (no viaja)
36728d5 fix(rea): explain display-only bundle differences inline

📊 Changes

3 files changed (+52 additions, -0 deletions)

View changed files

📝 .gitignore (+5 -0)
📝 src/domain/bundleComparison.test.ts (+30 -0)
📝 src/domain/bundleComparison.ts (+17 -0)

📄 Description

Fixes #3216

What I changed

src/domain/bundleComparison.ts (compareBundles): when the canonical digests differ but no record/unknown changes were found, the result now carries one inline bundle:digest entry (changed / observed_change with the digest pair) instead of an unexplained empty changed. Equal bundles still return unchanged with no entries.
src/domain/bundleComparison.test.ts: new test with two bundles sharing one evidence_id but different subject display paths.

Verification

New test fails without the fix (changed with changes: []), passes with it.
vitest run src/domain/bundleComparison.test.ts: 8 passed; tsc --noEmit clean; oxfmt --check clean.

Honest limits

The entry records the digest pair without naming which display field differs; records_changed stays 0 since no record changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3259 **Author:** [@CRYPTONIKAV](https://github.com/CRYPTONIKAV) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/3216-bundle-delta` --- ### 📝 Commits (2) - [`9745152`](https://github.com/morluto/rea/commit/9745152fa7a688ea82afd9d41660fe30eaa79dc4) chore: scratch gitignore (no viaja) - [`36728d5`](https://github.com/morluto/rea/commit/36728d5227cc72060a57c587dbc7b1b1174341a1) fix(rea): explain display-only bundle differences inline ### 📊 Changes **3 files changed** (+52 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+5 -0) 📝 `src/domain/bundleComparison.test.ts` (+30 -0) 📝 `src/domain/bundleComparison.ts` (+17 -0) </details> ### 📄 Description Fixes #3216 ## What I changed - `src/domain/bundleComparison.ts` (`compareBundles`): when the canonical digests differ but no record/unknown changes were found, the result now carries one inline `bundle:digest` entry (`changed` / `observed_change` with the digest pair) instead of an unexplained empty `changed`. Equal bundles still return `unchanged` with no entries. - `src/domain/bundleComparison.test.ts`: new test with two bundles sharing one `evidence_id` but different subject display paths. ## Verification - New test fails without the fix (`changed` with `changes: []`), passes with it. - `vitest run src/domain/bundleComparison.test.ts`: 8 passed; `tsc --noEmit` clean; `oxfmt --check` clean. ## Honest limits - The entry records the digest pair without naming which display field differs; `records_changed` stays 0 since no record changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:47:46 +00:00

[PR #6842] [MERGED] fix(native): preserve whitespace in Mach-O segment and section names #7424

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5680

No description provided.

Rows
Columns