[PR #3262] [CLOSED] fix(rea): empty source-map selection is included, not unavailable #5683

New issue

Closed

opened 2026-10-31 01:08:36 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3262
Author: @CRYPTONIKAV
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/3217-empty-sourcemaps

📝 Commits (2)

84cd253 fix(rea): empty source-map selection is included, not unavailable
03b4a33 fix(rea): budget omission with zero items stays unavailable

📊 Changes

3 files changed (+29 additions, -2 deletions)

View changed files

📝 src/browser/WebSourceMapFetcher.ts (+5 -1)
📝 src/domain/webBundleAnalysis.ts (+1 -1)
📝 tests/boundary/browser/webSourceMapFetcher.test.ts (+23 -0)

📄 Description

Fixes #3217

What I changed

src/browser/WebSourceMapFetcher.ts (sourceMapsStatus): zero requests now report included instead of unavailable — selecting map fetching for scripts that declare none is vacuously complete. Non-empty outcomes are untouched.
src/domain/webBundleAnalysis.ts: the status/coverage validator accepts included for the empty-items case.
tests/boundary/browser/webSourceMapFetcher.test.ts: new test pinning included with requested: 0.

Verification

New test fails without the fix (unavailable), passes with it.
Boundary suite: 82 passed; tsc --noEmit clean; oxfmt --check clean.

Honest limits

The empty-items validator union is now slightly more permissive (not_requested/unavailable/included); the fetcher itself is deterministic so no runtime contradiction.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3262 **Author:** [@CRYPTONIKAV](https://github.com/CRYPTONIKAV) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/3217-empty-sourcemaps` --- ### 📝 Commits (2) - [`84cd253`](https://github.com/morluto/rea/commit/84cd253b93d81442627b977e041633ea5a8d92f5) fix(rea): empty source-map selection is included, not unavailable - [`03b4a33`](https://github.com/morluto/rea/commit/03b4a33857bbd1ab483f4f295f976aeac2b991aa) fix(rea): budget omission with zero items stays unavailable ### 📊 Changes **3 files changed** (+29 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/browser/WebSourceMapFetcher.ts` (+5 -1) 📝 `src/domain/webBundleAnalysis.ts` (+1 -1) 📝 `tests/boundary/browser/webSourceMapFetcher.test.ts` (+23 -0) </details> ### 📄 Description Fixes #3217 ## What I changed - `src/browser/WebSourceMapFetcher.ts` (`sourceMapsStatus`): zero requests now report `included` instead of `unavailable` — selecting map fetching for scripts that declare none is vacuously complete. Non-empty outcomes are untouched. - `src/domain/webBundleAnalysis.ts`: the status/coverage validator accepts `included` for the empty-items case. - `tests/boundary/browser/webSourceMapFetcher.test.ts`: new test pinning `included` with `requested: 0`. ## Verification - New test fails without the fix (`unavailable`), passes with it. - Boundary suite: 82 passed; `tsc --noEmit` clean; `oxfmt --check` clean. ## Honest limits - The empty-items validator union is now slightly more permissive (`not_requested`/`unavailable`/`included`); the fetcher itself is deterministic so no runtime contradiction. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:36 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5683

No description provided.

Rows
Columns