[PR #3264] [CLOSED] test(pcap): align retained cleanup fixture with emitted stdout #5684

New issue

Closed

opened 2026-10-31 01:08:36 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3264
Author: @AdityaKharmaleGoat7
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/pcap-retained-cleanup-fixture-current

📝 Commits (1)

7bed698 test(pcap): align retained cleanup fixture output

📊 Changes

1 file changed (+11 additions, -10 deletions)

View changed files

📝 tests/boundary/pcap/pcapProvider.test.ts (+11 -10)

📄 Description

Fixes #3252

This aligns the retained-cleanup capinfos fixture with the exact stdout bytes it emits:

make CAPINFOS_OUTPUT include the trailing newline
emit that constant with printf '%s' so no second newline is added
compare captured stdout directly against the complete constant

The existing current-head beforeClose teardown hook already releases the injected cleanup failure before test teardown, so no additional cleanup-path change is needed here.

Validation:

verified the contribution commit is based directly on current upstream main (29d3dcb7)
verified the diff is limited to tests/boundary/pcap/pcapProvider.test.ts
local test execution was not available in this environment because the runtime could not resolve GitHub for cloning/installing dependencies; CI should provide the authoritative test result

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3264 **Author:** [@AdityaKharmaleGoat7](https://github.com/AdityaKharmaleGoat7) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pcap-retained-cleanup-fixture-current` --- ### 📝 Commits (1) - [`7bed698`](https://github.com/morluto/rea/commit/7bed6986da914d6bd96fc1fef436088d6ae438c8) test(pcap): align retained cleanup fixture output ### 📊 Changes **1 file changed** (+11 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/pcap/pcapProvider.test.ts` (+11 -10) </details> ### 📄 Description Fixes #3252 This aligns the retained-cleanup capinfos fixture with the exact stdout bytes it emits: - make `CAPINFOS_OUTPUT` include the trailing newline - emit that constant with `printf '%s'` so no second newline is added - compare captured stdout directly against the complete constant The existing current-head `beforeClose` teardown hook already releases the injected cleanup failure before test teardown, so no additional cleanup-path change is needed here. Validation: - verified the contribution commit is based directly on current upstream `main` (`29d3dcb7`) - verified the diff is limited to `tests/boundary/pcap/pcapProvider.test.ts` - local test execution was not available in this environment because the runtime could not resolve GitHub for cloning/installing dependencies; CI should provide the authoritative test result --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:36 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5684

No description provided.

Rows
Columns