morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3280] [MERGED] fix(website): correct the Korean skip-link label #5698

New issue

Closed

opened 2026-10-31 01:08:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3280
Author: @hachi-008
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/14/2026
Merged by: @morluto

Base: main ← Head: fix/ko-website-skip-link

📝 Commits (1)

167c78c fix(website): correct the Korean skip-link label

📊 Changes

1 file changed (+17 additions, -17 deletions)

View changed files

📝 website/locales/ko/messages.po (+17 -17)

📄 Description

Summary

The skip link on Korean pages reads "개인정보보호정책" ("Privacy policy") instead of "Skip to content". Keyboard and screen-reader users reach this link first on every page. This changes the Skip to content entry on the 17 other Korean pages to "본문으로 건너뛰기". The FAQ page is covered by #3276. No issue: it's a translation fix without a scope question.

Problem and expected behavior

Focusing the skip link on a Korean page shows and announces "Privacy policy", which isn't what the link does. Expected: the label says it skips to the main content.

Change and scope

website/locales/ko/messages.po: 17 Skip to content entries, one per page context. With #3276, all 18 Korean pages use the same label.
Not included: other strings on these pages.

Ordinary translation fix within existing boundaries; scope decision not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: website translation catalog (website/locales/ko/messages.po) only.
Contribution scope fit and linked maintainer decision: translation correction; not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable.
Generated metadata, package, or installation impact: none; no generated files committed.
Documentation or usability only; no target interaction.

Evidence and regression coverage

Tests added or updated: none (translation only).
Base reproduction or other evidence: at 877d404 all 18 Korean Skip to content entries are "개인정보보호정책". After building the site, the 17 pages in this change render "본문으로 건너뛰기".
User-visible CLI/MCP output: not applicable.
Remaining proof gaps: none known.

Validation performed

Linux x64, Python 3.13, base 877d404:

python3 scripts/website.py translations check --language ko: 1594/1594 translated, 0 missing or fuzzy
python3 scripts/website.py check: passed (12 tests)
git diff --check: clean

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable.
Package or release metadata impact: none.
Security, privacy, process, or containment review: not applicable.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3280 **Author:** [@hachi-008](https://github.com/hachi-008) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/ko-website-skip-link` --- ### 📝 Commits (1) - [`167c78c`](https://github.com/morluto/rea/commit/167c78cf117e07cc73ef25a75fcd7e10c03f2b26) fix(website): correct the Korean skip-link label ### 📊 Changes **1 file changed** (+17 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `website/locales/ko/messages.po` (+17 -17) </details> ### 📄 Description ## Summary The skip link on Korean pages reads "개인정보보호정책" ("Privacy policy") instead of "Skip to content". Keyboard and screen-reader users reach this link first on every page. This changes the `Skip to content` entry on the 17 other Korean pages to "본문으로 건너뛰기". The FAQ page is covered by #3276. No issue: it's a translation fix without a scope question. ## Problem and expected behavior Focusing the skip link on a Korean page shows and announces "Privacy policy", which isn't what the link does. Expected: the label says it skips to the main content. ## Change and scope - `website/locales/ko/messages.po`: 17 `Skip to content` entries, one per page context. With #3276, all 18 Korean pages use the same label. - Not included: other strings on these pages. Ordinary translation fix within existing boundaries; scope decision not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: website translation catalog (`website/locales/ko/messages.po`) only. - Contribution scope fit and linked maintainer decision: translation correction; not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details (if applicable): not applicable. - Generated metadata, package, or installation impact: none; no generated files committed. - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage - Tests added or updated: none (translation only). - Base reproduction or other evidence: at 877d404 all 18 Korean `Skip to content` entries are "개인정보보호정책". After building the site, the 17 pages in this change render "본문으로 건너뛰기". - User-visible CLI/MCP output: not applicable. - Remaining proof gaps: none known. ## Validation performed Linux x64, Python 3.13, base 877d404: - `python3 scripts/website.py translations check --language ko`: 1594/1594 translated, 0 missing or fuzzy - `python3 scripts/website.py check`: passed (12 tests) - `git diff --check`: clean ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable. - Package or release metadata impact: none. - Security, privacy, process, or containment review: not applicable. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:44 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5698

No description provided.

Rows
Columns