morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3286] [MERGED] docs(contributing): require human ownership and review readiness #5700

New issue

Closed

opened 2026-10-31 01:08:45 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3286
Author: @morluto
Created: 10/14/2026
Status: ✅ Merged
Merged: 10/14/2026
Merged by: @morluto

Base: main ← Head: codex/human-pr-readiness

📝 Commits (2)

4b2c438 docs(contributing): require human ownership and review readiness
ff57477 docs(contributing): strengthen the human declaration instruction

📊 Changes

3 files changed (+85 additions, -3 deletions)

View changed files

📝 .github/pull_request_template.md (+23 -3)
📝 AGENTS.md (+20 -0)
📝 CONTRIBUTING.md (+42 -0)

📄 Description

Summary

PRs need an explicit human owner and useful validation before consuming maintainer review time. Require human review of the final diff, evidence for the current change, and an explicit ready-for-review declaration.

Problem and expected behavior

The existing checklist covers scope and verification but does not require a human to accept ownership or declare the current revision ready for review. Add those requirements while allowing draft PRs with pending questions.

Change and scope

Update CONTRIBUTING.md, AGENTS.md, and the PR template. AI-assisted contributions remain welcome. Agents leave human declarations unchecked; subsequent changes require renewed human review and refreshed evidence.

This is a maintainer-requested contribution-policy update; there is no linked issue. The contribution scope decision for new providers or execution capabilities is not applicable.

Contract and boundary impact

Semantic owner and earliest changed stage: contributor guidance and PR preparation.
Contribution scope fit and linked maintainer decision: documentation-only; advance capability approval is not applicable.
CLI and MCP/tool-catalog contract: no change.
Provider, bridge, target-format, or platform compatibility: no change.
Evidence, artifact, provenance, or reconstruction contract: no runtime change; contributors must state actual validation and gaps.
Target selection, authority, upstream behavior, and cleanup details: no target interaction.
Generated metadata, package, or installation impact: none.

Expected effects:

Documentation or usability only; no target interaction.

Evidence and regression coverage

Source-derived: compared the policy, agent instructions, and template so all require human ownership, validation evidence, and readiness for the current revision.
Validation: formatting and diff checks passed in the isolated PR worktree.
Documentation facts: passed in the original workspace using its existing generated artifacts; Git blob hashes confirmed all three changed files match the PR worktree exactly.
Tests added or updated: none; this changes contributor documentation and a Markdown template.
Remaining proof gaps: readiness is enforced through policy and maintainer review. This change does not add an automated GitHub readiness gate.

Validation performed

oxfmt --check AGENTS.md CONTRIBUTING.md .github/pull_request_template.md — passed using the installed repository formatter.
git diff --check and git diff --cached --check — passed.
node scripts/check-doc-facts.mjs — passed in the original workspace with existing generated artifacts.
Fresh isolated-worktree documentation-fact attempts could not complete because generated runtime metadata and the packaged skill were absent. Full npm run docs:check, npm run check, and runtime/provider tests were not run.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: not applicable to this documentation-only change.
Package or release metadata impact: none.
Security, privacy, process, or containment review: existing integration scope and authority requirements remain in force.

Author readiness

Human owner: @morluto

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare the current revision ready for maintainer review.

Before merge

Material scope and authority questions are resolved.
Required checks pass for the current revision.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3286 **Author:** [@morluto](https://github.com/morluto) **Created:** 10/14/2026 **Status:** ✅ Merged **Merged:** 10/14/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/human-pr-readiness` --- ### 📝 Commits (2) - [`4b2c438`](https://github.com/morluto/rea/commit/4b2c43866cadedd987d9e7b4dd7d0b435056e369) docs(contributing): require human ownership and review readiness - [`ff57477`](https://github.com/morluto/rea/commit/ff57477130c0b1a881a2f30a3b1bd317f1cc86bb) docs(contributing): strengthen the human declaration instruction ### 📊 Changes **3 files changed** (+85 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/pull_request_template.md` (+23 -3) 📝 `AGENTS.md` (+20 -0) 📝 `CONTRIBUTING.md` (+42 -0) </details> ### 📄 Description ## Summary PRs need an explicit human owner and useful validation before consuming maintainer review time. Require human review of the final diff, evidence for the current change, and an explicit ready-for-review declaration. ## Problem and expected behavior The existing checklist covers scope and verification but does not require a human to accept ownership or declare the current revision ready for review. Add those requirements while allowing draft PRs with pending questions. ## Change and scope Update CONTRIBUTING.md, AGENTS.md, and the PR template. AI-assisted contributions remain welcome. Agents leave human declarations unchecked; subsequent changes require renewed human review and refreshed evidence. This is a maintainer-requested contribution-policy update; there is no linked issue. The [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope) decision for new providers or execution capabilities is not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: contributor guidance and PR preparation. - Contribution scope fit and linked maintainer decision: documentation-only; advance capability approval is not applicable. - CLI and MCP/tool-catalog contract: no change. - Provider, bridge, target-format, or platform compatibility: no change. - Evidence, artifact, provenance, or reconstruction contract: no runtime change; contributors must state actual validation and gaps. - Target selection, authority, upstream behavior, and cleanup details: no target interaction. - Generated metadata, package, or installation impact: none. Expected effects: - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage - Source-derived: compared the policy, agent instructions, and template so all require human ownership, validation evidence, and readiness for the current revision. - Validation: formatting and diff checks passed in the isolated PR worktree. - Documentation facts: passed in the original workspace using its existing generated artifacts; Git blob hashes confirmed all three changed files match the PR worktree exactly. - Tests added or updated: none; this changes contributor documentation and a Markdown template. - Remaining proof gaps: readiness is enforced through policy and maintainer review. This change does not add an automated GitHub readiness gate. ## Validation performed - `oxfmt --check AGENTS.md CONTRIBUTING.md .github/pull_request_template.md` — passed using the installed repository formatter. - `git diff --check` and `git diff --cached --check` — passed. - `node scripts/check-doc-facts.mjs` — passed in the original workspace with existing generated artifacts. - Fresh isolated-worktree documentation-fact attempts could not complete because generated runtime metadata and the packaged skill were absent. Full `npm run docs:check`, `npm run check`, and runtime/provider tests were not run. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: not applicable to this documentation-only change. - Package or release metadata impact: none. - Security, privacy, process, or containment review: existing integration scope and authority requirements remain in force. ## Author readiness Human owner: @morluto - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare the current revision ready for maintainer review. ## Before merge - [ ] Material scope and authority questions are resolved. - [ ] Required checks pass for the current revision. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:45 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:44:54 +00:00

[PR #5754] [CLOSED] fix(native): keep recorded-core note types owner-qualified #7039

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5700

No description provided.

Rows
Columns