morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3304] [CLOSED] test(setup): use verified commands in positive uninstall fixtures #5714

New issue

Closed

opened 2026-10-31 01:08:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3304
Author: @N0zoM1z0
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/3301-owned-uninstall-fixtures

📝 Commits (1)

737fe6a test(setup): use verified commands in positive uninstall fixtures

📊 Changes

2 files changed (+7 additions, -4 deletions)

View changed files

📝 tests/boundary/filesystem/clientConfigurationBom.test.ts (+5 -2)
📝 tests/boundary/filesystem/clientLifecycle.test.ts (+2 -2)

📄 Description

Summary

Fixes #3301. Three positive uninstall fixtures still used arbitrary absolute launcher paths after registration identity became conservative. They therefore retained configuration instead of reaching their intended removal/byte-preservation checks.

Use the canonical pinned package-runner command and recognized CLI name for the BOM command-update cycle, and the recognized CLI name for the two lifecycle cases. All removal, exact-byte restoration, unrelated-entry and symlink assertions remain unchanged. Only two test files change.

Contract and boundary impact

The changed owner is test fixture construction. No production identity/ownership rule, public CLI/MCP behavior, provider, evidence format, generated metadata, package or release changes. This is an ordinary correction within existing boundaries; a new capability scope decision is not applicable. These tests read/write isolated temporary configuration files and exercise real setup/uninstall APIs; the registered commands are data and are not executed or downloaded.

Evidence and validation

Clean tracked main 7c962cc70: the three selected cases fail, reproducing hosted #3299 shard 2. An arbitrary absolute bin/rea path is retained as unowned, as intended by the current production rule.
npm run test:focused -- with clientConfigurationBom.test.ts, clientLifecycle.test.ts, clientRegistrationStatus.test.ts and setupClientConfigCleanupOwnership.test.ts — 4 files / 97 tests passed in 7.68 s.
npm run test:focused -- tests/boundary/filesystem/clientConfigurationDialects.test.ts — 25 tests passed, including prior-release recognition and foreign-package rejection.
npm run check:ci — 8 tasks and architecture guards passed.
git diff --check — passed.

Executed on Linux x86_64 / Node 24.18.0 / npm 11.16.0 / Vitest 5.0.3. No macOS/Windows execution or external-client application coverage is claimed. These are fixture drift fixes, not a measured runtime speedup.

Author readiness

Human owner: @N0zoM1z0

AI-assisted preparation. The human owner explicitly confirmed review of this PR's diff and validation evidence, accepted responsibility, and dictated all three declarations on 2026-10-14.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3304 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/3301-owned-uninstall-fixtures` --- ### 📝 Commits (1) - [`737fe6a`](https://github.com/morluto/rea/commit/737fe6a9c2352dab5293637db9557e16098e3fec) test(setup): use verified commands in positive uninstall fixtures ### 📊 Changes **2 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/filesystem/clientConfigurationBom.test.ts` (+5 -2) 📝 `tests/boundary/filesystem/clientLifecycle.test.ts` (+2 -2) </details> ### 📄 Description ## Summary Fixes #3301. Three positive uninstall fixtures still used arbitrary absolute launcher paths after registration identity became conservative. They therefore retained configuration instead of reaching their intended removal/byte-preservation checks. Use the canonical pinned package-runner command and recognized CLI name for the BOM command-update cycle, and the recognized CLI name for the two lifecycle cases. All removal, exact-byte restoration, unrelated-entry and symlink assertions remain unchanged. Only two test files change. ## Contract and boundary impact The changed owner is test fixture construction. No production identity/ownership rule, public CLI/MCP behavior, provider, evidence format, generated metadata, package or release changes. This is an ordinary correction within existing boundaries; a new capability scope decision is not applicable. These tests read/write isolated temporary configuration files and exercise real setup/uninstall APIs; the registered commands are data and are not executed or downloaded. ## Evidence and validation - Clean tracked main `7c962cc70`: the three selected cases fail, reproducing hosted #3299 shard 2. An arbitrary absolute `bin/rea` path is retained as unowned, as intended by the current production rule. - `npm run test:focused --` with `clientConfigurationBom.test.ts`, `clientLifecycle.test.ts`, `clientRegistrationStatus.test.ts` and `setupClientConfigCleanupOwnership.test.ts` — 4 files / 97 tests passed in 7.68 s. - `npm run test:focused -- tests/boundary/filesystem/clientConfigurationDialects.test.ts` — 25 tests passed, including prior-release recognition and foreign-package rejection. - `npm run check:ci` — 8 tasks and architecture guards passed. - `git diff --check` — passed. Executed on Linux x86_64 / Node 24.18.0 / npm 11.16.0 / Vitest 5.0.3. No macOS/Windows execution or external-client application coverage is claimed. These are fixture drift fixes, not a measured runtime speedup. ## Author readiness Human owner: @N0zoM1z0 AI-assisted preparation. The human owner explicitly confirmed review of this PR's diff and validation evidence, accepted responsibility, and dictated all three declarations on 2026-10-14. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:51 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:45:02 +00:00

[PR #5780] [MERGED] fix(hopper): preserve caller abort reasons on cancellation #7057

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5714

No description provided.

Rows
Columns