morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3410] [CLOSED] test(hopper): preserve the updated platform-specific doctor contract #5727

New issue

Closed

opened 2026-10-31 01:08:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:08:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3410
Author: @N0zoM1z0
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/3406-hopper-doctor-fixture

📝 Commits (5)

f62632e test(javascript): assert wrapper ownership in the correct source mode
7419553 test(hopper): provide controlled Linux loader evidence for doctor
a89ce21 Merge latest main and retain the upstream wrapper ownership correction
3698e4f test(hopper): retain the updated platform-specific doctor contract
e2259b5 chore: integrate current release-notes changes before verification

📊 Changes

1 file changed (+2 additions, -28 deletions)

View changed files

📝 tests/boundary/cli/doctorHopperDiscovery.test.ts (+2 -28)

📄 Description

Superseded and closed unmerged: upstream 0686b0754 completes the current discovery/version fixture contract. See the final validation comment. The restoration below was discarded, not merged.

Summary

Fixes #3406. Restore main's platform-specific Hopper doctor fixture after a semantic conflict in #3299's merge.

The tested PR head supplied controlled Linux loader output for a shell launcher. Before the merge, main commit 7435e79d6 independently corrected this fixture to expect the real shell launcher to be unavailable on Linux. Git combined that new negative assertion with my older positive loader setup without a textual conflict, making the merged test fail. I reproduced that exact failure on main a32b4b6ac.

Remove only my obsolete loader setup and restore this file byte-for-byte from the actual pre-merge main parent 60c08802a. Preserve platform-specific readiness, exit status, path diagnostics and no-launch assertions. The Rizin stdin/readiness fix remains intact.

Change and boundary impact

One test file; no production behavior, provider permissions, CLI/MCP contract, evidence format, package, release or generated metadata changes. Ordinary correction within existing boundaries; a new capability scope decision is not applicable. The existing platform scope and 20 s deadline remain unchanged. This restores the actual Linux loader check rather than simulating compatibility.

Evidence and validation

Current head e2259b526 integrates main efe092391; the repair is still the same single-file delta. Linux / Node 24.18.0 / npm 11.16.0 / Vitest 5.0.3. Original regression reproduced on actual merged main a32b4b6ac.
Exact merged-main CLI test: 1 failed, reproducing the conflicting Hopper readiness assertion.
Corrected npm run test:focused -- tests/boundary/cli/doctorHopperDiscovery.test.ts tests/boundary/providers/RizinDebugSessionCoverage.part2.test.ts src/domain/javascript/javascriptStaticAnalysisModuleIndex.test.ts src/domain/javascript/javascriptSemanticAnalysis.require_links.test.ts — 4 files / 76 tests passed in 2.91 s.
npm run check:ci — 8 tasks and architecture guards across 1,394 files passed.
Before the latest release-notes-only main integration, exact head 3698e4f89 passed all hosted code CI: 1,273 unique test files, 14,522 tests passed, 125 skipped, zero failures; Greptile 5/5, no inline findings.
After integrating latest main efe092391, the four relevant files above plus tests/boundary/filesystem/releaseNotes.test.ts passed: 5 files / 81 tests / 9.60 s. check:ci and architecture guards across 1,394 files passed again. Current-head hosted CI is running; earlier evidence is not represented as its result.
Normal commit and pre-push checks passed; git diff --check passed.

The earlier #3299 CI qualified its frozen head, not the later concurrent main edits. A correct three-way tree reconstruction did not by itself prove semantic compatibility. The earlier byte-identical Hopper claim was wrong and has been corrected publicly. This follow-up validates the actual combined fixture and changes only the obsolete setup. No actual installed Hopper compatibility, macOS execution or speedup is claimed.

Author readiness

Human owner: @N0zoM1z0

AI-assisted preparation. Human declarations remain unchecked until explicitly supplied by the human owner.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3410 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/3406-hopper-doctor-fixture` --- ### 📝 Commits (5) - [`f62632e`](https://github.com/morluto/rea/commit/f62632e7a6f38ad9cbdc2e61d636768161dbaa7b) test(javascript): assert wrapper ownership in the correct source mode - [`7419553`](https://github.com/morluto/rea/commit/74195532be5582a7fe3ce5d6651f865113261c78) test(hopper): provide controlled Linux loader evidence for doctor - [`a89ce21`](https://github.com/morluto/rea/commit/a89ce212d6fe6a813f9160b2d4ea3f76deebd6c5) Merge latest main and retain the upstream wrapper ownership correction - [`3698e4f`](https://github.com/morluto/rea/commit/3698e4f89988f9d8a2160270eb23487dc4a2ce65) test(hopper): retain the updated platform-specific doctor contract - [`e2259b5`](https://github.com/morluto/rea/commit/e2259b5264b8e9ace751181e23439c991e950db7) chore: integrate current release-notes changes before verification ### 📊 Changes **1 file changed** (+2 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/doctorHopperDiscovery.test.ts` (+2 -28) </details> ### 📄 Description > Superseded and closed unmerged: upstream `0686b0754` completes the current discovery/version fixture contract. See the final validation comment. The restoration below was discarded, not merged. ## Summary Fixes #3406. Restore main's platform-specific Hopper doctor fixture after a semantic conflict in #3299's merge. The tested PR head supplied controlled Linux loader output for a shell launcher. Before the merge, main commit `7435e79d6` independently corrected this fixture to expect the real shell launcher to be unavailable on Linux. Git combined that new negative assertion with my older positive loader setup without a textual conflict, making the merged test fail. I reproduced that exact failure on main `a32b4b6ac`. Remove only my obsolete loader setup and restore this file byte-for-byte from the actual pre-merge main parent `60c08802a`. Preserve platform-specific readiness, exit status, path diagnostics and no-launch assertions. The Rizin stdin/readiness fix remains intact. ## Change and boundary impact One test file; no production behavior, provider permissions, CLI/MCP contract, evidence format, package, release or generated metadata changes. Ordinary correction within existing boundaries; a new capability scope decision is not applicable. The existing platform scope and 20 s deadline remain unchanged. This restores the actual Linux loader check rather than simulating compatibility. ## Evidence and validation - Current head `e2259b526` integrates main `efe092391`; the repair is still the same single-file delta. Linux / Node 24.18.0 / npm 11.16.0 / Vitest 5.0.3. Original regression reproduced on actual merged main `a32b4b6ac`. - Exact merged-main CLI test: **1 failed**, reproducing the conflicting Hopper readiness assertion. - Corrected `npm run test:focused -- tests/boundary/cli/doctorHopperDiscovery.test.ts tests/boundary/providers/RizinDebugSessionCoverage.part2.test.ts src/domain/javascript/javascriptStaticAnalysisModuleIndex.test.ts src/domain/javascript/javascriptSemanticAnalysis.require_links.test.ts` — **4 files / 76 tests passed** in 2.91 s. - `npm run check:ci` — 8 tasks and architecture guards across 1,394 files passed. - Before the latest release-notes-only main integration, exact head `3698e4f89` passed all hosted code CI: 1,273 unique test files, 14,522 tests passed, 125 skipped, zero failures; Greptile 5/5, no inline findings. - After integrating latest main `efe092391`, the four relevant files above plus `tests/boundary/filesystem/releaseNotes.test.ts` passed: **5 files / 81 tests / 9.60 s**. `check:ci` and architecture guards across 1,394 files passed again. Current-head hosted CI is running; earlier evidence is not represented as its result. - Normal commit and pre-push checks passed; `git diff --check` passed. The earlier #3299 CI qualified its frozen head, not the later concurrent main edits. A correct three-way tree reconstruction did not by itself prove semantic compatibility. The earlier byte-identical Hopper claim was wrong and has been corrected publicly. This follow-up validates the actual combined fixture and changes only the obsolete setup. No actual installed Hopper compatibility, macOS execution or speedup is claimed. ## Author readiness Human owner: @N0zoM1z0 AI-assisted preparation. Human declarations remain unchecked until explicitly supplied by the human owner. - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:08:59 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5727

No description provided.

Rows
Columns