[PR #3450] [CLOSED] fix(android): name the method that holds an inlined body #5745

New issue

Closed

opened 2026-10-31 01:09:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:09:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3450
Author: @chessing234
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/android-inlined-method

📝 Commits (5)

4fe1976 fix(android): name the method that holds an inlined body
adb5587 fix(android): keep the selected overload defined after a bad index
b9a898d fix(android): name an inlined holder only when the method name is unique
cf1b5ec Merge remote-tracking branch 'origin/main' into fix/android-inlined-method
722962d test(android): give the overloaded inlined-holder fixture a concrete index

📊 Changes

5 files changed (+199 additions, -18 deletions)

View changed files

📝 bridge/android/ReaJadxBridge.java (+34 -6)
📝 docs/android-analysis.md (+7 -2)
📝 src/android/JadxAnalysis.ts (+22 -10)
📝 src/android/JadxProtocol.ts (+1 -0)
📝 tests/boundary/android/JadxAnalysis.test.ts (+135 -0)

📄 Description

Summary

When JADX returns the empty-body placeholder, inspect_android_method no longer calls the method native or abstract.
If a sibling's decompiled text has renamed from: <method>,, the result names that sibling and adds the inlined_method marker. The body stays not_available because the selected method itself still has no source.
A bad overload index is rejected with ?? so the selected method stays defined for the rest of the function.
Fixes #3443.

Test plan

vitest run tests/boundary/android/JadxAnalysis.test.ts

Author readiness

Human owner: @Chessing234

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3450 **Author:** [@chessing234](https://github.com/chessing234) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/android-inlined-method` --- ### 📝 Commits (5) - [`4fe1976`](https://github.com/morluto/rea/commit/4fe1976b0966182b0b309b7391714c46850f18d3) fix(android): name the method that holds an inlined body - [`adb5587`](https://github.com/morluto/rea/commit/adb558738f69369f88ca7183c0afb60cb2cdcdb3) fix(android): keep the selected overload defined after a bad index - [`b9a898d`](https://github.com/morluto/rea/commit/b9a898d018f95aea0f417bce7da857b73a8d2ce7) fix(android): name an inlined holder only when the method name is unique - [`cf1b5ec`](https://github.com/morluto/rea/commit/cf1b5ec8bbf61da8ecd4fe7ea08e5ea7938b5039) Merge remote-tracking branch 'origin/main' into fix/android-inlined-method - [`722962d`](https://github.com/morluto/rea/commit/722962d890175ac999f240859c7ab647b2c4a4ad) test(android): give the overloaded inlined-holder fixture a concrete index ### 📊 Changes **5 files changed** (+199 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `bridge/android/ReaJadxBridge.java` (+34 -6) 📝 `docs/android-analysis.md` (+7 -2) 📝 `src/android/JadxAnalysis.ts` (+22 -10) 📝 `src/android/JadxProtocol.ts` (+1 -0) 📝 `tests/boundary/android/JadxAnalysis.test.ts` (+135 -0) </details> ### 📄 Description ## Summary - When JADX returns the empty-body placeholder, `inspect_android_method` no longer calls the method native or abstract. - If a sibling's decompiled text has `renamed from: <method>,`, the result names that sibling and adds the `inlined_method` marker. The body stays `not_available` because the selected method itself still has no source. - A bad overload index is rejected with `??` so the selected method stays defined for the rest of the function. - Fixes #3443. ## Test plan - [x] `vitest run tests/boundary/android/JadxAnalysis.test.ts` ## Author readiness Human owner: @Chessing234 - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:09:06 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5745

No description provided.

Rows
Columns