[PR #3464] [CLOSED] fix(javascript): keep nonfinite timer delays JSON-safe #5755

New issue

Closed

opened 2026-10-31 01:09:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:09:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3464
Author: @AdityaKharmaleGoat7
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/nonfinite-timer-delay

📝 Commits (2)

b22f723 fix(javascript): keep nonfinite timer delays JSON-safe
5bd5c87 test(javascript): cover nonfinite timer delay projection

📊 Changes

2 files changed (+35 additions, -1 deletions)

View changed files

➕ src/domain/javascript/javascriptSemanticAnalysis.nonfinite_timer.test.ts (+33 -0)
📝 src/domain/javascript/javascriptSemanticAsyncEffects.ts (+2 -1)

📄 Description

Fixes #3400

Summary

treat non-finite numeric timer delays as unknown (null) instead of publishing Infinity into the semantic graph
preserve finite numeric timer delays unchanged
add focused regression coverage that keeps unrelated callable semantics while retaining the timer candidate

Validation

branch is based directly on current upstream main (92a0edf187)
diff is limited to the timer-delay helper and one focused semantic-analysis test
local test execution is unavailable in this environment; repository CI should provide the authoritative test/static-check result

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3464 **Author:** [@AdityaKharmaleGoat7](https://github.com/AdityaKharmaleGoat7) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/nonfinite-timer-delay` --- ### 📝 Commits (2) - [`b22f723`](https://github.com/morluto/rea/commit/b22f7230a83aaa8d6252427d7f1f8aa3aa6c0439) fix(javascript): keep nonfinite timer delays JSON-safe - [`5bd5c87`](https://github.com/morluto/rea/commit/5bd5c87ce590c460dcd02473875e6c9d606d440c) test(javascript): cover nonfinite timer delay projection ### 📊 Changes **2 files changed** (+35 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `src/domain/javascript/javascriptSemanticAnalysis.nonfinite_timer.test.ts` (+33 -0) 📝 `src/domain/javascript/javascriptSemanticAsyncEffects.ts` (+2 -1) </details> ### 📄 Description Fixes #3400 ## Summary - treat non-finite numeric timer delays as unknown (`null`) instead of publishing `Infinity` into the semantic graph - preserve finite numeric timer delays unchanged - add focused regression coverage that keeps unrelated callable semantics while retaining the timer candidate ## Validation - branch is based directly on current upstream `main` (`92a0edf187`) - diff is limited to the timer-delay helper and one focused semantic-analysis test - local test execution is unavailable in this environment; repository CI should provide the authoritative test/static-check result --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:09:11 +00:00