mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #3525] fix(mcp): recover structured tool arguments clients serialize as JSON text #5802
Open
opened 2026-10-31 01:09:33 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5802
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/3525
Author: @hemv-857
Created: 10/14/2026
Status: 🔄 Open
Base:
main← Head:fix-3408-stringified-structured-arguments📝 Commits (6)
23692aafix(mcp): recover structured tool arguments clients serialize as JSON text3944f0efix(mcp): skip argument recovery on application-validated registrationsc37f4a2fix(mcp): recover structured arguments on application-validated registrations37f406bMerge origin/main into fix-3408-stringified-structured-argumentsb790b05fix(mcp): keep schema validation synchronous for native arguments11faa18Merge remote-tracking branch 'origin/main' into pr3525📊 Changes
3 files changed (+314 additions, -8 deletions)
View changed files
📝
src/server/EvidenceMcpServerCore.ts(+14 -6)📝
src/server/toolRegistrationOptions.ts(+87 -2)➕
tests/boundary/mcp/stringifiedStructuredArguments.test.ts(+213 -0)📄 Description
Summary
Fixes #3408.
Claude Desktop delivers array and object tool arguments as JSON text, so every structured parameter of every tool failed SDK input validation before reaching its handler. Recover JSON text at the registered input schema's validation step in
EvidenceMcpServerCore.registerTool, then let the canonical parser decide the result unchanged.Problem and expected behavior
Smallest trigger:
tools/callforinspect_web_pagewithallowed_originssupplied as'["https://example.com"]', orcapture_browser_scenariowithbrowser,start_url,actions, andcapturesupplied as JSON text. Violated invariant: a structured parameter whose supplied value is valid JSON text for that parameter's schema should be validated as that structure instead of being rejected as a string.Reported before this change (REA 6.4.0, Claude Desktop 2.37337.1 on Windows 11):
Input validation error: Invalid arguments for tool inspect_web_page: Invalid inputbrowser: Invalid input: expected object, received string, start_url: Invalid input: expected object, received string, actions: Invalid input: expected array, received string, capture: Invalid input: expected object, received stringString-only parameters keep working, so the failure is partial and reads as missing data:
inspect_web_pagewithoutallowed_originssucceeds and reports third-party resources asdisallowed_origin.Change and scope
EvidenceMcpServerCore.registerTool, where every MCP tool registration passes, wraps each registered input schema's Standard SchemavalidatewithacceptStringifiedStructuredArguments(src/server/toolRegistrationOptions.ts). For each top-level string argument that starts with{or[and parses as a JSON object or array, the parsed bag is validated first. If that fails but the caller's original bag validates (JSON text a string parameter accepts), the original is kept. If both fail, the parsed form's content-level issues are reported. Native JSON values never take this path and pass straight to the canonical validator without an extra async hop, so deferred-call ordering and request metadata stay unchanged; the advertised JSON Schema projection is spread through unchanged. Application-owned validators (vendor: "rea-application"fromapplicationToolRegistrationOptions) recover through the same shared bag-merge helper inside their own wrapper: the canonical parser chooses between the recovered bag and the caller's original, the wrapper returns only client-supplied bags (never the canonical parser's parsed output, so application-owned parsing stays in the handler), and when neither bag satisfies the canonical parser the handler receives the caller's original arguments — a capture path named[]keeps its string, whilerecord_ordinals: "[0]"recovers to the array.Intentionally not included:
$ref/$defs.capture_browser_scenario's served schema contains no$refat all (browserisoneOf,start_urlandcaptureareobject,actionsisarray) and still received strings, so inlining would not fix the reported tools, and changing the advertised projection would movetools_sha256.Contribution scope: ordinary fix within the existing MCP boundary. No target execution, injection, mutation, or protection recovery, so no maintainer scope decision is required.
Contract and boundary impact
validatestep; the canonical contract parser stays the semantic owner of validation.tools/listand catalog digests unchanged;tools/callaccepts JSON text where the contract expects an object or array and still rejects everything the contract rejected before.docs/public/product-catalog.json), package, or installation impact: none. No contract or example edits, so regenerated catalogs are unchanged.Expected effects:
No listed target effect is introduced: this change normalizes MCP argument delivery only. Unchecked items do not establish absence.
Evidence and regression coverage
Tests added or updated:
tests/boundary/mcp/stringifiedStructuredArguments.test.ts(7 tests) covering recovery of a fully stringifiedcapture_browser_scenarioexample, recovery ofinspect_web_page.allowed_origins, preservation of JSON text in a string parameter, preservation of a JSON-looking string (capture_path: "[]") on an application-validated registration, recovery of structured text on an application-validated registration (record_ordinals: "[0]"), preservation of the caller's original arguments when neither bag satisfies the canonical parser, and continued rejection of malformed structured text.Base reproduction: the pre-port head
c37f4a2had the same split, with the three recovery tests failing on unmodifiedorigin/main(the handler never ran on the contract tools; application-owned registrations never recovered) and the four guard tests passing. This merge only moves the recovery boundary to main's new core registration and application helper; with the change, all seven pass.User-visible CLI/MCP output: the reported
Input validation error: Invalid arguments for tool ...results become ordinary tool results of the recovered call. Real browser output was not captured here; the recovery boundary is covered by the in-memory MCP client tests above.Remaining proof gaps: Claude Desktop itself was not run (Windows/Electron unavailable in this environment). Recovery is verified through an in-memory MCP client sending exactly the reported wire values. Upstream stringification cases that do not arrive as JSON text (anthropics/claude-code#58747 type stripping) are not recoverable server-side.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npx vitest run tests/boundary/mcp/stringifiedStructuredArguments.test.ts— 7 passed.src/server/DeferredEvidenceMcpServer.test.tsplus the stringified suite — 19 passed, covering both recovery and request-metadata ordering during deferred registration.npm run test:focusedover stringifiedStructuredArguments, EvidenceMcpServer, toolInputAdmission, toolSchemaValidity, compactInputSchemaMcp, browserComparisonInput, outputValidatorReuse — 43 passed, 3 failed; all three are the same catalog tests exceeding the 30 s test timeout under load (59 s, 47 s, 40 s).toolSchemaValiditypasses 14/16 andcompactInputSchemaMcp12/13 in isolation, with the same timeout; the three tests are environmental on this machine.npm run check:fast— passed (typecheck and lint).npx oxfmt --check <changed files>— passed.npm run test:mcpwas not rerun after the merge; the focused MCP set above is the post-merge evidence.Compatibility, safety, and release
JSON.parseruns only on top-level string arguments that begin with{or[, inside the existing MCP request size bound, at most twice per call. The recovered bag is built with object spread andObject.fromEntries(own data properties, no[[Set]]), so__proto__argument keys cannot pollute prototypes. Recovered values pass the same canonical parser as before, and the change adds no file, process, network, or authority access.Author readiness
Human owner: @hemv-857
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.