morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3544] [CLOSED] fix(electron): forward selected XAUTHORITY to owned capture environment #5813

New issue

Closed

opened 2026-10-31 01:09:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:09:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3544
Author: @HoneyTyagii
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix-electron-xauthority-3414

📝 Commits (1)

44ae822 fix(electron): forward selected XAUTHORITY to owned capture environment

📊 Changes

2 files changed (+18 additions, -0 deletions)

View changed files

📝 src/browser/PlaywrightElectronActiveProvider.test.ts (+17 -0)
📝 src/browser/PlaywrightElectronActiveProvider.ts (+1 -0)

📄 Description

Fixes #3414.

Owned Electron capture dropped the caller selected X11 authorization path. safeElectronEnvironment forwarded DISPLAY and WAYLAND_DISPLAY but excluded XAUTHORITY, so an explicitly selected authenticated display failed in the child with an X11 authorization error.

Change:

Forward XAUTHORITY when present in the selected environment, alongside the existing display variables.
No display switching, no disabled authentication, no ownership or cleanup change. Missing XAUTHORITY behaves as before.

Precedent:

src/browser/PlaywrightScenarioBrowser.ts already allowlists XAUTHORITY for the same reason.

Verification:

New unit test in PlaywrightElectronActiveProvider.test.ts checks DISPLAY plus XAUTHORITY pass through and unrelated values stay excluded.
Standalone reproduction of the allowlist logic passed. Full vitest was not run here because node_modules is not installed in this clone.

Risk:

Low. Additive allowlist change only. A caller that never sets XAUTHORITY sees identical behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3544 **Author:** [@HoneyTyagii](https://github.com/HoneyTyagii) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-electron-xauthority-3414` --- ### 📝 Commits (1) - [`44ae822`](https://github.com/morluto/rea/commit/44ae8224e94427253e00f729f22248a6ff82fd86) fix(electron): forward selected XAUTHORITY to owned capture environment ### 📊 Changes **2 files changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/browser/PlaywrightElectronActiveProvider.test.ts` (+17 -0) 📝 `src/browser/PlaywrightElectronActiveProvider.ts` (+1 -0) </details> ### 📄 Description Fixes #3414. Owned Electron capture dropped the caller selected X11 authorization path. safeElectronEnvironment forwarded DISPLAY and WAYLAND_DISPLAY but excluded XAUTHORITY, so an explicitly selected authenticated display failed in the child with an X11 authorization error. Change: - Forward XAUTHORITY when present in the selected environment, alongside the existing display variables. - No display switching, no disabled authentication, no ownership or cleanup change. Missing XAUTHORITY behaves as before. Precedent: - src/browser/PlaywrightScenarioBrowser.ts already allowlists XAUTHORITY for the same reason. Verification: - New unit test in PlaywrightElectronActiveProvider.test.ts checks DISPLAY plus XAUTHORITY pass through and unrelated values stay excluded. - Standalone reproduction of the allowlist logic passed. Full vitest was not run here because node_modules is not installed in this clone. Risk: - Low. Additive allowlist change only. A caller that never sets XAUTHORITY sees identical behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:09:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:45:13 +00:00

[PR #5813] [MERGED] feat(gpu): inspect static CUDA and HIP code objects #7079

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5813

No description provided.

Rows
Columns