mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 01:09:48 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5837
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/3583
Author: @hemanthrayuduu
Created: 10/14/2026
Status: ❌ Closed
Base:
main← Head:fix/signature-unsigned-slices📝 Commits (1)
37c5216fix(native): check every slice of a signed universal Mach-O📊 Changes
7 files changed (+217 additions, -34 deletions)
View changed files
📝
src/native/NativeMacOSProvider.ts(+43 -24)📝
tests/boundary/providers/native/nativeInventory.golden.test.ts(+110 -5)📝
tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts(+7 -5)➕
tests/fixtures/native-macos/codesign-universal-slices/README.md(+25 -0)➕
tests/fixtures/native-macos/codesign-universal-slices/display.txt(+30 -0)➕
tests/fixtures/native-macos/codesign-universal-slices/requirements.txt(+1 -0)➕
tests/fixtures/native-macos/codesign-universal-slices/slice-unsigned.txt(+1 -0)📄 Description
Summary
inspect_signaturereports a universal Mach-O as fully signed when one of its slices is unsigned, as long as the signed slices carry an identity signature rather than an ad hoc one. On macOS 27.0.1, a copy of/bin/lswith its x86_64 slice unsigned returnssigned: trueand the same limitations as the real/bin/ls, with nothing about the unsigned slice.The mixed-signature handling from #701 (for #684) looks at individual slices only when the aggregate
codesign -d -r-or--entitlementsquery reports "not signed". That works for ad hoc signatures, because an ad hoc designated requirement lists every slice's CDHash. An identity requirement such asidentifier "com.apple.ls" and anchor applecomes from codesign's default slice, so the query succeeds and the unsigned slice is never noticed.With this change, a signed universal file is checked slice by slice and unsigned slices are reported with the existing
Unsigned Mach-O slices: …limitation. I didn't open an issue first: this is the case #684's acceptance criterion describes ("that result should state that the x86_64 slice is unsigned rather than report the file as signed without qualification"), only for identity-signed files, and the result shape doesn't change.Problem and expected behavior
Smallest trigger: rebuild
/bin/lswith an unsigned x86_64 slice and inspect it. The system file isn't modified.codesign -d --verbose=4,codesign -d -r-andcodesign -d --entitlements :-all exit 0 on that file. Onlycodesign -d -a x86_64reports "code object is not signed at all". The broken invariant: when slices of one file are signed differently, the result should say which slice is unsigned instead of reportingsigned: truewithout qualification.A second, smaller defect is in the same function.
codeSignArchitectureskept onlyi386|x86_64|armv7|arm64|arm64efrom codesign'sFormat=Mach-O universal (…)list. macOS 27 system binaries also have anarm64e.x1slice, whichcodesign -a arm64e.x1accepts, so that slice was never queried even on the existing mixed-signature path.Change and scope
All in
src/native/NativeMacOSProvider.ts:inspect_signaturenow runscodesign -d -a <architecture> --verbose=4for each slice. Before, it did this only when the aggregate requirement or entitlements query had already reported "not signed".Format=line, and any name token it prints is accepted, soarm64e.x1is now included.#inspectMixedSignatureSlicesandMixedSignatureSlicesare renamed#inspectSignatureSlicesandSignatureSlices, since they now run for every signed universal file.The cost is one extra codesign run per slice for signed universal files: 3 for
/bin/ls. Each run goes through the same#captureSignaturepath, so it reads the registered snapshot and checks the target identity before and after.Not included:
signed: falsewith "Artifact is not signed.", even if its other slices are signed. On this Mac (M2, macOS 27.0.1), codesign's default slice isarm64e.x1, so a copy of/bin/lswith only that slice unsigned returnssigned: false. Fixing that needs a decision about whatsignedshould mean for a partly signed file, and the per-slice names would have to come from somewhere other than the unsigned display, so I've left it out. I'm happy to open an issue for it.Contribution scope: an ordinary fix within the existing
inspect_signatureboundary.Contract and boundary impact
#inspectBoundSignatureand#inspectSignatureSlices). The codesign output parser is unchanged.limitationsnow includesUnsigned Mach-O slices: <arch>.. Signed universal files now have extracodesign -d -a <arch> --verbose=4entries inprovenance.docs/public/product-catalog.json), package, or installation impact: none.Expected effects:
Evidence and regression coverage
Tests added or updated:
tests/boundary/providers/native/nativeInventory.golden.test.ts:mixed-x86file above. These are intests/fixtures/native-macos/codesign-universal-slices/, with a README.arm64e.x1slice on the existing ad hoc mixed path.signatureRunnerhelper gained two options, a successful aggregate requirement and a list of unsigned slices, and its defaults keep the earlier tests unchanged.tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts: the real-codesign directory-swap test copies/usr/bin/true, which is universal (x86_64, arm64e, arm64e.x1). It expected exactly three codesign calls. It now checks that every call, including the per-slice ones, reads the registered snapshot ($ARTIFACT).Base reproduction or other evidence: with only the test changes applied on
c7105d9,nativeInventory.golden.test.tsgave 3 failed and 18 passed. The two identity-signed cases had noUnsigned Mach-O sliceslimitation, and thearm64e.x1case got "could not be classified" because that slice was never queried. The fully signed control and the existing #701 test passed.User-visible CLI/MCP output:
node scripts/rea.mjs inspect-signature <path> --format jsonon macOS 27.0.1 (26A434), Apple M2, built fromc7105d9before the change and from this branch after it. The composites are copies of/bin/lsbuilt as above, and the #684 control isclang -arch x86_64 -arch arm64with clang's default signing:/bin/lssigned: true, no slice limitationmixed-x86signed: true, no slice limitation, the same output as/bin/lssigned: true,Unsigned Mach-O slices: x86_64.mixed-arm64esigned: true, no slice limitationsigned: true,Unsigned Mach-O slices: arm64e.Unsigned Mach-O slices: x86_64.plus the aggregate requirement limitation/bin/lswith only arm64e.x1 unsignedsigned: false, "Artifact is not signed."Remaining proof gaps:
Format=line, beyondarm64e.x1.For evidence-bearing changes:
Validation performed
All with Node 24.18.0 and npm 11.16.0 on macOS 27.0.1, arm64. I developed on
c7105d9and then rebased onto569ef41(the rebase was clean). The last list below is what I re-ran on the rebased branch.npm ci: installed.npm run test:focused -- tests/boundary/providers/native/nativeInventory.golden.test.tswith only the test changes onc7105d9: 3 failed, 18 passed. After the fix: 21 passed.npm run test:focused -- tests/boundary/providers/native/nativeInventory.golden.test.ts src/native/SignatureTargetBinding.test.ts tests/boundary/cli/nativeSignatureCli.test.ts tests/boundary/mcp/nativeSignatureTargetBindingMcp.test.ts tests/boundary/providers/native/nativeProvider.test.ts tests/boundary/providers/native/nativeSignatureTargetBinding.test.ts src/domain/apple/appleApplication.test.ts: 7 files, 119 tests passed.npm run check: passed.npm run check:fast: passed.npm run verify:test-discovery: "Discovered all 1233 test files exactly once."git diff --check: clean.npm run build:cached: passed, before and after.npm run test:fast: 7264 passed, 5 failed, 13 skipped. The 5 failures are inJavaScriptSemanticGraphResources.test.ts,electronWrappedCallPaths.test.ts,javascriptSemanticAmbientWrites.test.ts,javascriptSemanticAnalysis.native_bindings.test.tsandIdaNativeProtocol.test.ts. The same 5 fail onc7105d9without this change (5 failed, 87 passed in those files).After rebasing onto
569ef41:npm ci, then the same 7-filenpm run test:focusedcommand: 125 tests passed.npm run check: passed.npm run verify:test-discovery: "Discovered all 1285 test files exactly once."npm run build:cached, then the same CLI runs: the same results as the "After" column.npm run test:fastafter the rebase.Compatibility, safety, and release
codesign, through the CLI runs above and the existing real-codesign directory-swap test. I didn't run Hopper or Ghidra, and neither is touched.codesign -d -acalls read the same snapshot under the same target-identity checks. Slice names passed to-amust match^[A-Za-z0-9_]+(?:\.[A-Za-z0-9_]+)?$, so a name can't start with-.Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.