[PR #3765] [CLOSED] test(browser): cover WebMCP schema fields through CLI #5884

New issue

Closed

opened 2026-10-31 01:10:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:10:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3765
Author: @Abdooo2235
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: fix/webmcp-schema-property-names

📝 Commits (2)

07da87c fix(browser): keep schema keywords out of WebMCP input fields
041c580 Merge main and preserve upstream WebMCP schema fix

📊 Changes

2 files changed (+71 additions, -2 deletions)

View changed files

📝 src/adb/AdbProvider.ts (+3 -2)
➕ tests/boundary/cli/webMcpSchemaProperties.test.ts (+68 -0)

📄 Description

Summary

Add a compiled CLI regression for the WebMCP schema-field fix already integrated into main in ebd5a82 (Refs #3331). That upstream commit credits this contribution and also preserves empty literal property names.

The branch now incorporates main at 808339f. Conflict resolution retains the upstream analyzer and producer tests exactly, removes the duplicate PR unit cases, and keeps the CLI check for missing, dynamic and literal properties with page-declared trust. A formatter-only correction in AdbProvider.ts removes redundant parentheses introduced upstream; without it, the required formatting check failed. No ADB behavior changes.

Validation

Windows, Node 24.18.0 / npm 11.16.0:

Focused analyzer, compiled schema CLI and upstream receiver CLI tests: 41/41 passed.
npm run check: passed after the formatter correction; existing lint warnings remain.
npm run docs:check: passed, including 5 README tests.
Pre-push check:fast and git diff --check: passed.
Independent conflict-resolution review: no findings.

CLI tests use the local CDP fixture, not a real browser. Current-head GitHub CI must complete separately; earlier results on 07da87c do not validate this merge. No provider or dependency changes.

Author readiness

Human owner: @Abdooo2235

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3765 **Author:** [@Abdooo2235](https://github.com/Abdooo2235) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/webmcp-schema-property-names` --- ### 📝 Commits (2) - [`07da87c`](https://github.com/morluto/rea/commit/07da87c4154e3444974e1310dc9a8888e595fd59) fix(browser): keep schema keywords out of WebMCP input fields - [`041c580`](https://github.com/morluto/rea/commit/041c58021a8c29d4c7196a355f89207bf972b24d) Merge main and preserve upstream WebMCP schema fix ### 📊 Changes **2 files changed** (+71 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/adb/AdbProvider.ts` (+3 -2) ➕ `tests/boundary/cli/webMcpSchemaProperties.test.ts` (+68 -0) </details> ### 📄 Description ## Summary Add a compiled CLI regression for the WebMCP schema-field fix already integrated into main in ebd5a82 (Refs #3331). That upstream commit credits this contribution and also preserves empty literal property names. The branch now incorporates main at 808339f. Conflict resolution retains the upstream analyzer and producer tests exactly, removes the duplicate PR unit cases, and keeps the CLI check for missing, dynamic and literal properties with page-declared trust. A formatter-only correction in AdbProvider.ts removes redundant parentheses introduced upstream; without it, the required formatting check failed. No ADB behavior changes. ## Validation Windows, Node 24.18.0 / npm 11.16.0: - Focused analyzer, compiled schema CLI and upstream receiver CLI tests: 41/41 passed. - npm run check: passed after the formatter correction; existing lint warnings remain. - npm run docs:check: passed, including 5 README tests. - Pre-push check:fast and git diff --check: passed. - Independent conflict-resolution review: no findings. CLI tests use the local CDP fixture, not a real browser. Current-head GitHub CI must complete separately; earlier results on 07da87c do not validate this merge. No provider or dependency changes. ## Author readiness Human owner: @Abdooo2235 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:10:10 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5884

No description provided.

Rows
Columns