morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3810] docs: add a static VB6 native OCX investigation workflow #5915

New issue

Open

opened 2026-10-31 01:10:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:10:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3810
Author: @lucaomlg
Created: 10/15/2026
Status: 🔄 Open

Base: main ← Head: docs/vb6-native-ocx-workflow

📝 Commits (2)

e8a8c68 docs: add a static VB6 native OCX investigation workflow
03811db fix(setup): install and manage the VB6 investigation guide

📊 Changes

5 files changed (+139 additions, -0 deletions)

View changed files

📝 .agents/skills/reverse-engineer-anything/references/native-and-artifacts.md (+4 -0)
➕ .agents/skills/reverse-engineer-anything/references/vb6-native-ocx.md (+85 -0)
📝 src/application/SetupSkill.ts (+1 -0)
📝 tests/acceptance/setup/selectedSkillSetup.test.ts (+47 -0)
📝 tests/boundary/filesystem/setupSkill.test.ts (+2 -0)

📄 Description

Summary

Add a focused static VB6 native OCX/DLL investigation reference and link it from the existing native-target guide. Include the new reference in the shared managed-file inventory so rea setup installs and repairs it and rea uninstall removes the managed guide.

Problem and approach

The native guide lacked VB6-specific interface/implementation and recovery boundaries. The new guide documents compilation-mode corroboration, metadata/thunk binding, compiler/runtime patterns and explicit unknowns. It adds no decoder, provider, target execution or source-recovery guarantee, and does not complete #2383.

The initial documentation patch omitted references/vb6-native-ocx.md from MANAGED_SKILL_FILES, leaving an installed skill with a broken reference. The follow-up adds that entry at its existing owner; installation, drift detection, repair and uninstall already consume this shared list. No parallel inventory or special-case copy/removal logic was introduced.

Changes

Add the authored VB6 reference and parent-guide link.
Register the reference in MANAGED_SKILL_FILES.
Extend existing installed-content and conformance-digest test inventories.
Add a real CLI regression covering installation, idempotence, damaged-guide repair with backup, uninstall, and preservation of user notes and recovery backups.
Format the new guide's table with the repository formatter.

Validation

Executed in an isolated Windows checkout with the pinned Node 24.18.0 and npm 11.16.0:

RED: the new CLI regression and the existing complete-bundle installation test failed with ENOENT for the missing VB6 guide before the inventory fix.
GREEN: both targeted CLI scenarios pass after the fix.
setupSkill.test.ts: 12 passed, 4 platform-skipped.
Complete selectedSkillSetup.test.ts: 5 passed, 2 failed. The two existing linked-path cases compare raw JSON output with unescaped Windows paths; both also failed before the production change.
Broader clientLifecycle.test.ts: 53 passed, 2 failed, 1 platform-skipped. Both existing symlink configuration cases were reproduced with SetupSkill.ts restored byte-for-byte to the original PR head. They remain outside this fix.
npm run check: PASS (typecheck, formatter, lint, module boundaries, knip, metadata and architecture guards; lint reports warnings but no errors).
npm run docs:check: PASS, including 5 README conformance tests.
npm run verify:test-discovery: PASS, 1,301 files discovered exactly once.
npm run build:cached: PASS. npm pack --ignore-scripts: the tarball contains the VB6 guide with bytes matching the generated skill. This is a package-content check, not full package verification.
Independent diff review: no security or logic findings.

Not run: complete repository suite/full package verification, real REA/Ghidra target analysis, VB6 compilation, provider validation or benchmarks. No Windows native addon was built or installed. Build output contains dynamic-import bundling warnings. Generated outputs, dependencies, binaries and local validation logs are not committed.

Safety and compatibility

No API/schema changes or new target authority. The runtime change is limited to managing this authored guide through existing skill lifecycle code. No private binaries, recovered source, disassembly, credentials or private-case paths are included. AI assistance was used. No changes were made to the contributor's installed REA or personal skills.

Author readiness

Human owner: @lucaomlg

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

The existing initial-readiness declarations are preserved unchanged; this update does not claim a new human review or maintainer approval.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3810 **Author:** [@lucaomlg](https://github.com/lucaomlg) **Created:** 10/15/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `docs/vb6-native-ocx-workflow` --- ### 📝 Commits (2) - [`e8a8c68`](https://github.com/morluto/rea/commit/e8a8c680e0952d6c7812de22ed5438bc8df2d88f) docs: add a static VB6 native OCX investigation workflow - [`03811db`](https://github.com/morluto/rea/commit/03811db9733fdc2f8026221b503c0adce38dbe30) fix(setup): install and manage the VB6 investigation guide ### 📊 Changes **5 files changed** (+139 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/reverse-engineer-anything/references/native-and-artifacts.md` (+4 -0) ➕ `.agents/skills/reverse-engineer-anything/references/vb6-native-ocx.md` (+85 -0) 📝 `src/application/SetupSkill.ts` (+1 -0) 📝 `tests/acceptance/setup/selectedSkillSetup.test.ts` (+47 -0) 📝 `tests/boundary/filesystem/setupSkill.test.ts` (+2 -0) </details> ### 📄 Description ## Summary Add a focused static VB6 native OCX/DLL investigation reference and link it from the existing native-target guide. Include the new reference in the shared managed-file inventory so `rea setup` installs and repairs it and `rea uninstall` removes the managed guide. ## Problem and approach The native guide lacked VB6-specific interface/implementation and recovery boundaries. The new guide documents compilation-mode corroboration, metadata/thunk binding, compiler/runtime patterns and explicit unknowns. It adds no decoder, provider, target execution or source-recovery guarantee, and does not complete #2383. The initial documentation patch omitted `references/vb6-native-ocx.md` from `MANAGED_SKILL_FILES`, leaving an installed skill with a broken reference. The follow-up adds that entry at its existing owner; installation, drift detection, repair and uninstall already consume this shared list. No parallel inventory or special-case copy/removal logic was introduced. ## Changes - Add the authored VB6 reference and parent-guide link. - Register the reference in `MANAGED_SKILL_FILES`. - Extend existing installed-content and conformance-digest test inventories. - Add a real CLI regression covering installation, idempotence, damaged-guide repair with backup, uninstall, and preservation of user notes and recovery backups. - Format the new guide's table with the repository formatter. ## Validation Executed in an isolated Windows checkout with the pinned Node 24.18.0 and npm 11.16.0: - **RED:** the new CLI regression and the existing complete-bundle installation test failed with `ENOENT` for the missing VB6 guide before the inventory fix. - **GREEN:** both targeted CLI scenarios pass after the fix. - `setupSkill.test.ts`: **12 passed, 4 platform-skipped**. - Complete `selectedSkillSetup.test.ts`: **5 passed, 2 failed**. The two existing linked-path cases compare raw JSON output with unescaped Windows paths; both also failed before the production change. - Broader `clientLifecycle.test.ts`: **53 passed, 2 failed, 1 platform-skipped**. Both existing symlink configuration cases were reproduced with `SetupSkill.ts` restored byte-for-byte to the original PR head. They remain outside this fix. - `npm run check`: **PASS** (typecheck, formatter, lint, module boundaries, knip, metadata and architecture guards; lint reports warnings but no errors). - `npm run docs:check`: **PASS**, including 5 README conformance tests. - `npm run verify:test-discovery`: **PASS**, 1,301 files discovered exactly once. - `npm run build:cached`: **PASS**. `npm pack --ignore-scripts`: the tarball contains the VB6 guide with bytes matching the generated skill. This is a package-content check, not full package verification. - Independent diff review: no security or logic findings. **Not run:** complete repository suite/full package verification, real REA/Ghidra target analysis, VB6 compilation, provider validation or benchmarks. No Windows native addon was built or installed. Build output contains dynamic-import bundling warnings. Generated outputs, dependencies, binaries and local validation logs are not committed. ## Safety and compatibility No API/schema changes or new target authority. The runtime change is limited to managing this authored guide through existing skill lifecycle code. No private binaries, recovered source, disassembly, credentials or private-case paths are included. AI assistance was used. No changes were made to the contributor's installed REA or personal skills. ## Author readiness Human owner: @lucaomlg - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. The existing initial-readiness declarations are preserved unchanged; this update does not claim a new human review or maintainer approval. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 01:10:24 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5915

No description provided.

Rows
Columns