mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-10-31 01:10:28 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5923
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/3818
Author: @whalemenace
Created: 10/15/2026
Status: 🔄 Open
Base:
main← Head:feat/ghidra-pdb-companion📝 Commits (4)
262c3c6feat(ghidra): apply a caller-selected PDB that matches the target90c653btest(ghidra): verify caller-selected PDBs against real Ghidraa6d69e0docs(ghidra): document caller-selected PDBs5197a44fix(ghidra): keep caller PDBs out of existing projects📊 Changes
24 files changed (+1482 additions, -17 deletions)
View changed files
➕
bridge/ghidra/ReaGhidraApplyPdb.java(+107 -0)📝
bridge/ghidra/ReaGhidraBridge.java(+5 -0)📝
docs/ghidra-provider.md(+39 -3)📝
docs/installation.md(+9 -0)📝
docs/testing.md(+12 -11)📝
docs/user-visible-errors.csv(+1 -0)📝
docs/windows-ghidra-p0.md(+6 -0)📝
package.json(+2 -0)➕
scripts/verify-real-ghidra-pdb.mjs(+305 -0)📝
src/config/environment.ts(+22 -0)📝
src/config/parseConfig.ts(+3 -0)📝
src/config/types.ts(+2 -0)📝
src/ghidra/GhidraLauncher.ts(+31 -0)➕
src/ghidra/GhidraPdbCompanion.test.ts(+451 -0)➕
src/ghidra/GhidraPdbCompanion.ts(+343 -0)📝
src/ghidra/GhidraPeProfile.ts(+1 -1)📝
src/ghidra/GhidraProjectHistory.ts(+3 -0)📝
src/ghidra/GhidraProvider.behavior.test.ts(+9 -0)📝
src/ghidra/GhidraProvider.ts(+14 -1)📝
src/ghidra/GhidraProviderClient.ts(+30 -0)...and 4 more files
📄 Description
Summary
Let a caller hand the Ghidra provider the PDB that belongs to the target (
REA_GHIDRA_PDB_FILE). Today REA states "REA does not admit a caller-selected PDB companion", so a shipped Windows binary whose vendor left its PDB in the install (it happens) is analysed without its own symbols even though Ghidra can apply them. Related to the use case in #3751 (large game binaries where names are the expensive part).Problem and expected behavior
REA_GHIDRA_PDB_FILE=<absolute path>, REA verifies before Ghidra starts that the PDB's GUID and age equal the target's RSDS CodeView record (fail closed,unsupported_targetnaming both identities), then a pre-script verifies again with Ghidra's own PDB reader and hands the file to the analyzer. The profile recordspdb_companionand the session limitations say what was applied and that the symbols are caller-supplied debug information, not Ghidra discoveries.Change and scope
src/ghidra/GhidraPdbCompanion.ts(new): reads the MSF 7.00 superblock, stream directory, PDB info stream (1) and DBI header (3) to get GUID and age without loading the PDB (DBI age wins when non-zero, Ghidra's rule); hashes the file through the same no-follow handle; builds the profile commitment{format: rea-ghidra-pdb-v1, path, configured_path, sha256, bytes, guid, age}; compares againsttarget.codeView(REA's existing PE parse of the RSDS record). Refusals: GUID/age mismatch, PE without an RSDS GUID, non-PE target (unsupported_target); unreadable or non-MSF file (ProviderAdapterError,setting: REA_GHIDRA_PDB_FILE).bridge/ghidra/ReaGhidraApplyPdb.java(new pre-script, modelled onReaGhidraApplySeeds.java): re-hashes the file, reads GUID/age withPdbParser/getIdentifiers(), compares with the committed values and the Program'sPdbProgramAttributes, and only then callsPdbUniversalAnalyzer.setPdbFileOption. Any mismatch throws and analyzeHeadless aborts before analysis. Outcome stored in the Program Info option "REA PDB companion"; the bridge reports it aspdb_companionin the handshake. (Ghidra 12.1.4'sPdbAnalyzerCommon.findPdbapplies a forced PDB without any GUID check, so REA's check is the only gate.)GhidraProviderClient.ts,GhidraProvider.ts,GhidraSessionValues.ts): fail-closed outcome check — report must match the commitment's sha256/GUID/age, the Program's GUID/age must match, and Ghidra must reportPDB Loadedtrue; otherwiseProviderAdapterErrorand the session closes. New limitation line "PDB applied: … caller-supplied debug information, not Ghidra discoveries; a matching GUID and age identify the build, not the completeness of the PDB". The old "does not admit a caller-selected PDB companion" sentence now reads "To apply a PDB from this exact build, set REA_GHIDRA_PDB_FILE; REA does not search for one."environment.ts,parseConfig.ts,types.ts): the setting;REA_GHIDRA_DISABLED_ANALYZERSmay not containPDB Universalwhile it is set (ConfigurationError).package.json:ReaGhidraApplyPdb.javaadded tofiles(the package would otherwise ship without it);verify:ghidra:pdbscript.REA_GHIDRA_PDB_FILEshould join its refused import-time settings). Scope decision: not applicable — static analysis input, no execution, injection or mutation.Contract and boundary impact
analysis_profile.parameters.pdb_companionadded when the setting is present; error contract row 90.8 indocs/user-visible-errors.csv(no new code).fileslist + one npm script; no catalog change.Expected effects:
Evidence and regression coverage
Tests added or updated:
src/ghidra/GhidraPdbCompanion.test.ts(MSF parsing incl. truncated/invalid containers, GUID normalisation, DBI-age rule, commitment and refusal paths, outcome check),tests/boundary/providers/ghidra/ghidraLauncher.test.ts(pre-script argument order after seeds and before analyzer options; the disabled-analyzer conflict),tests/conformance/ghidra/pdb-companion.c(fixture source).Base reproduction or other evidence:
npm run verify:ghidra:pdb(new,scripts/verify-real-ghidra-pdb.mjs, needsREA_CLANG/REA_LLD_LINKas the cross-format lane does): links two variants of the fixture into x86-64 PE + PDB pairs (/debug /pdb:), moves each PDB away from the path recorded in the image, then throughrea mcp: control without the setting →rea_pdb_scaleabsent fromlist_procedures; matching PDB →rea_pdb_scaleandrea_pdb_entrypresent, pseudocodeint __cdecl rea_pdb_entry(void) { … iVar1 = rea_pdb_scale(4,5); … },pdb_companionGUID/age equal the RSDS record and sha256 equals the file; the other link's PDB →unsupported_target"The PDB …/other-renamed.pdb has GUID 13445a73-… and age 1, but the target's CodeView record declares GUID 1a2550ec-… and age 1. REA refuses to apply debug information from another build."; direct analyzeHeadless with a wrong committed sha → pre-script refusal, "Processing aborted as a result of pre-script."User-visible CLI/MCP output: as quoted above.
Remaining proof gaps: MSVC-linked PDBs (the lane uses LLD's PDB writer); PDBs whose stream-directory block map spans more than one block are refused with a format error rather than parsed (32 KiB blocks reach that above 2 TiB); Windows P0 and macOS not run; time and heap for multi-GB PDBs (hashed twice: TypeScript at profile time, Java in the pre-script) not measured.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
All on Linux x64 (Fedora, Node 22.23, Ghidra 12.1.4, Temurin 21.0.12.1, zig 0.17.0's clang + lld-link for the fixture), final head of this branch:
npm run typecheck— cleannpm run lint— 0 errors, 1429 warnings (baseline count on upstream main)oxfmt --check— cleannpm run verify:test-discovery— passednpm run docs:check— passedsrc/ghidra,src/config,tests/boundary/providers/ghidra) — 752 tests passnpm run test:prepare && npm run test:run— Test files 3 failed / 1284 passed / 14 skipped; Tests 3 failed / 15023 passed / 175 skipped. The 3 failures (packageImportAliases,runnerCancellation,closedStdout) fail identically on a cleanupstream/mainworktree on the same host.npm run verify:ghidra:pdb— exit 0 (details above)Compatibility, safety, and release
filesgains the new Java script; one new npm script.Author readiness
Human owner: @whalemenace
(Opened as a draft; AI-assisted implementation, the human owner completes the declarations.)
Before merge
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.