mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-10-31 01:10:51 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#5971
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/3968
Author: @hetaoBackend
Created: 10/15/2026
Status: 🔄 Open
Base:
main← Head:feat/minimax-code-client📝 Commits (4)
eaa5b83feat(setup): add MiniMax Code clientd6f979cfix(setup): align MiniMax Code client with review833d745Merge remote-tracking branch 'origin/main' into feat/minimax-code-client3228033fix(setup): address MiniMax Code client review nits📊 Changes
6 files changed (+218 additions, -0 deletions)
View changed files
📝
docs/client-configuration.md(+15 -0)📝
docs/installation.md(+3 -0)📝
src/application/SupportedClients.ts(+16 -0)📝
tests/boundary/filesystem/clientLifecycle.test.ts(+1 -0)➕
tests/boundary/filesystem/minimaxCodeClientConfiguration.test.ts(+181 -0)📝
tests/fixtures/clientEnvironment.ts(+2 -0)📄 Description
Summary
Adds MiniMax Code (CLI
mcode) as a setup client.npx rea-agents setup --client minimax_coderegisters REA's MCP server and installs the REA skill. Before this change, setup did not know about MiniMax Code and users had to register REA by hand.No issue is linked. None exists; this is a small client addition that reuses the existing
jsonformat.Problem and expected behavior
MiniMax Code reads a plain
mcpServersJSON file andSKILL.mdskill directories, but setup does not detect it. With this change, setup detects~/.minimax, upsertsmcpServers.reainto~/.minimax/mcp.json(other servers and top-level keys are kept), and copies the skill to~/.minimax/skills/reverse-engineer-anything. WhenMINIMAX_DATA_DIR(or, failing that,MAVIS_DATA_DIR) is set, setup uses that directory instead of~/.minimax.Change and scope
src/application/SupportedClients.ts: newminimax_codeentry using the existingjsonformat, same shape as WorkBuddy, placed between WorkBuddy and Grok Build. No new dialect. The data directory isMINIMAX_DATA_DIR, thenMAVIS_DATA_DIR, then~/.minimax, matching MiniMax Code's own resolution (getExplicitPublicDataDirEnvinpackages/config/src/config.ts). An empty value counts as unset; values are not trimmed, like the Codex and Qoder helpers.~/.minimax(packages/config/src/data-dir.ts), profile MCP file<dataDir>/mcp.json(packages/local-runtime-v2/src/service/mcp/runtime/local-mcp.service.ts), user skills<dataDir>/skills(packages/local-runtime/src/skills/roots.ts).docs/installation.mdclient table, a note thatminimax_codeneeds a release after 6.7.0, and a MiniMax Code section indocs/client-configuration.md.MAVIS_DATA_DIRandMINIMAX_DATA_DIRare added to the fixture that clears client env, andminimax_codeis added to the client order in the lifecycle test.<workspace>/.mcp.json(left untouched, as for other clients), named profiles (~/.minimax-<profile>) and the legacy~/.mavisdirectory. The last two are follow-ups.Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
This is a setup client addition within existing boundaries. It adds no provider and no target interaction, so a maintainer scope decision is not applicable.
Contract and boundary impact
SupportedClients.ts).--clientvalue,minimax_code. No tool changes.reaentry and the REA skill copy.docs/public/product-catalog.json), package, or installation impact: the generated product catalog picks up the new client ID; no build outputs are committed. Installation docs gain one table row and a version note.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Setup writes
mcpServers.reainto MiniMax Code'smcp.json(with amcp.json.rea.backup) and copies the REA skill into itsskillsdirectory.Evidence and regression coverage
tests/boundary/filesystem/minimaxCodeClientConfiguration.test.ts(8 tests) covers the default paths on Linux, macOS and Windows; thejsonformat;MINIMAX_DATA_DIRbeforeMAVIS_DATA_DIRbefore the home default, an empty value falling back, and the skill path under the override; upsert that keeps other servers; an existing file with no servers table; an empty file; and uninstall that removes onlyrea.clientLifecycle.test.tsincludesminimax_codein its client order.tests/fixtures/clientEnvironment.tsclears both new variables.minimax_codeis not a known client ID, so setup cannot register REA for MiniMax Code. The evidence below was run on the updated head after merging current main.rea setup --client minimax_code --yesplansconfigure_client:minimax_codetargeting<HOME>/.minimax/mcp.jsonwith backup<HOME>/.minimax/mcp.json.rea.backup, plusinstall_skill:minimax_code.rea doctor --client minimax_code --jsonthen reportsregistration:minimax_codeashealthy./mcp reloadadvice and the MiniMax Code paths come from reading MiniMax Code source.For evidence-bearing changes:
Not an evidence-bearing change; these do not apply.
Validation performed
All on head
3228033(current main merged in), Node 22.20.0, Linux (Debian 13).npx vitest run tests/boundary/filesystem/minimaxCodeClientConfiguration.test.ts tests/boundary/filesystem/clientLifecycle.test.ts: 2 files, 70/70 passed.npx vitest run tests/boundary/filesystem/productCatalog.test.ts tests/boundary/filesystem/documentationFacts.test.ts tests/conformance/readmeConsistency.test.ts tests/boundary/filesystem/workbuddyClientConfiguration.test.ts: passed (catalog and docs checks, including the client table).npm run verify:test-discovery: "Discovered all 2106 test files exactly once."npm run typecheck(tsc --noEmit): clean.npx oxfmt --check .: clean.npx oxlint: exit 0; the only output is existingmax-depthwarnings inscripts/ci/plan.mjs, none in changed files.npm run verify:module-boundaries: passed.npm run build: passed.HOMEwith an existing~/.minimax/mcp.jsonholding another server and a top-level key:rea setup --client minimax_code --yesexits 0, addsmcpServers.reawhile keeping the other server and key, writesmcp.json.rea.backup, and installsskills/reverse-engineer-anything.rea doctor --client minimax_code --jsonreportsregistration:minimax_codehealthy. The registered command answers MCPinitialize(serverInforea).HOMEwithMINIMAX_DATA_DIRset: setup exits 0, writesmcp.jsonandskills/reverse-engineer-anythingunder that directory, and writes nothing underHOME.Compatibility, safety, and release
minimax_codeis not inrea-agents@6.7.0or earlier;docs/installation.mdsays it needs the first release after 6.7.0.mcp.json(with a backup) and the skill directory, and preserves unrelated configuration. It does not touch project-level.mcp.json.Author readiness
Human owner: @hetaoBackend
Before merge
type(scope): outcome.Follow-ups
~/.minimax-<profile>).~/.mavisdirectory.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.