morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #3973] [CLOSED] test: retain import and provider cleanup regressions #5978

New issue

Closed

opened 2026-10-31 01:10:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:10:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3973
Author: @xu91102
Created: 10/15/2026
Status: ❌ Closed

Base: main ← Head: codex/reference-source-resolution-order

📝 Commits (10+)

48fde10 fix(reference): resolve package main without an index
903d71b test(reference): retain package resolution boundary regressions
6934e44 fix(mcp): preserve shared observation provider ownership
c3f731b test(cli): retain recovered packet cleanup evidence
885f8cf test(reference): integrate main and retain boundary regressions
66cee70 test(reference): integrate MTS and CTS resolution coverage
c889f61 test(kuna): preserve cancellation through cleanup recovery
e040bdd test(providers): align async status and cancellation regressions
ed7c04b Merge current main and retain independent regression controls
33091a1 test(ghidra): retain exact shutdown cancellation outcome

📊 Changes

8 files changed (+348 additions, -121 deletions)

View changed files

📝 src/application/ReferenceSourceImportEntries.test.ts (+70 -5)
📝 tests/acceptance/providers/jebConfigurationIsolation.test.ts (+4 -1)
📝 tests/boundary/cli/referenceSourceDirectoryImports.test.ts (+34 -0)
📝 tests/boundary/filesystem/ghidraProfileArtifactOwnership.test.ts (+12 -11)
📝 tests/boundary/filesystem/javascript-applications/javascriptModuleRelationships.test.ts (+88 -66)
📝 tests/boundary/process/browserScenarioProbeLifecycle.test.ts (+89 -34)
📝 tests/boundary/process/electronLaunchRejections.test.ts (+36 -0)
📝 tests/boundary/providers/kuna/kunaProvider.test.ts (+15 -4)

📄 Description

Problem and retained behavior

The original package-main fix is already adopted on main with contributor credit retained. This PR keeps eight regression test files using the included main's production owners and cleanup contracts.

Coverage retains unknown/ambiguous Unicode imports and six compiled CLI directory combinations; actual replacement MCP dispatch and concurrent shared-provider cleanup/retry; precise Kuna/Ghidra cancellation ownership; JEB isolation with required host tools; imported versus unrelated sibling identity; and overlapping Electron launch rejection handling.

This revision normally merges main 3ddb2e4cf. The one conflict was in the Electron launch test: main now asserts the public projected diagnostics, while this branch also checks the exact two ordered typed error children, primary cause reference and cleanup ownership. Both sets remain. Superseded duplicate display fields were removed. Listener/orphan counts, all five failed outcomes and the other launch controls remain. The other seven contributed files are byte-identical to 90fe97ef. Production and documentation are identical to included main 3ddb2e4cf.

Fixes #3896

Verification

Final head: cbb26bc7794b268f50a5d36e5b750e8f67dd96d3 (parents 90fe97ef and main 3ddb2e4cf).

Fresh macOS arm64 / Node24.18.0: 22 focused files / 230 passed / no skips, including all eight contribution files and relevant new main process-output/cache controls. Separate fresh README: 5 passed; 23 distinct files / 235 passed total.
npm run check, npm run docs:check and discovery passed. Module/architecture guards checked 2,063 / 1,494 sources; discovery found all 1,544 test files exactly once.
Independent frozen Standards/Spec review: PASS. Normal hooks/commit/push preserved all 4,274 raw inputs, five gitlinks and the reviewed tree.
Final-head CI39054155583, attempt1: SUCCESS, 31 jobs: 11 succeeded / 20 conditional skips. All 2,233,145 bytes of logs and all 11 executing jobs' first own checkout payloads were verified: 7922229d, parents main 3ad1032b and final cbb26bc7. Portable 18,430 passed / 163 skipped exactly aggregates source 9,681 passed / 8 skipped and five shards; it is not an extra execution. All eight contribution files ran, including all 13 Electron launch tests. This is GitHub Linux portable execution; Windows, Apple, native-package, real-provider and Docs lanes were skipped. The later CI base is not the feature's included main, which remains 3ddb2e4cf.

Inherited main paths have not all received separate semantic certification. Controlled Playwright launches do not execute a real Electron application. Real browser/Electron qualification, native engines, native Linux/Windows, installed packages, target devices and performance remain unverified. Historical assertion failures and their diagnostic evidence are retained. Old generic Codex failures remain undiagnosed; no new-head Codex result is established. Local review, Actions, remote automated review and human readiness remain separate.

Author readiness

I reviewed the final diff and relevant existing code, and I can explain the approach and tradeoffs.
I checked the evidence above, including its limitations and unverified coverage.
I declare this PR ready for initial maintainer review.

Before merge

Required checks pass for this PR revision.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3973 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/reference-source-resolution-order` --- ### 📝 Commits (10+) - [`48fde10`](https://github.com/morluto/rea/commit/48fde102a1d1fbc7dbceaab1530149fdd7fc0320) fix(reference): resolve package main without an index - [`903d71b`](https://github.com/morluto/rea/commit/903d71b7eb1b66476dc6fd1df039dc464c88e5f7) test(reference): retain package resolution boundary regressions - [`6934e44`](https://github.com/morluto/rea/commit/6934e44f44d4775ae0c849eba51b06d41a03eb70) fix(mcp): preserve shared observation provider ownership - [`c3f731b`](https://github.com/morluto/rea/commit/c3f731b48327c9501e681692777d3b105f7686df) test(cli): retain recovered packet cleanup evidence - [`885f8cf`](https://github.com/morluto/rea/commit/885f8cf9c6036db2b3c5c256c9036486165e9312) test(reference): integrate main and retain boundary regressions - [`66cee70`](https://github.com/morluto/rea/commit/66cee70d31961ee31cc093c9b5aeaec985eb0c98) test(reference): integrate MTS and CTS resolution coverage - [`c889f61`](https://github.com/morluto/rea/commit/c889f61debbb45e699aa34b4b9e264a9b041a524) test(kuna): preserve cancellation through cleanup recovery - [`e040bdd`](https://github.com/morluto/rea/commit/e040bdd2e67c8324af244afb7c34d4cb57d971b6) test(providers): align async status and cancellation regressions - [`ed7c04b`](https://github.com/morluto/rea/commit/ed7c04bacd45249a0addc613c4876870a4d6fb26) Merge current main and retain independent regression controls - [`33091a1`](https://github.com/morluto/rea/commit/33091a19a565795a866728db3cae8ee475b9639a) test(ghidra): retain exact shutdown cancellation outcome ### 📊 Changes **8 files changed** (+348 additions, -121 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ReferenceSourceImportEntries.test.ts` (+70 -5) 📝 `tests/acceptance/providers/jebConfigurationIsolation.test.ts` (+4 -1) 📝 `tests/boundary/cli/referenceSourceDirectoryImports.test.ts` (+34 -0) 📝 `tests/boundary/filesystem/ghidraProfileArtifactOwnership.test.ts` (+12 -11) 📝 `tests/boundary/filesystem/javascript-applications/javascriptModuleRelationships.test.ts` (+88 -66) 📝 `tests/boundary/process/browserScenarioProbeLifecycle.test.ts` (+89 -34) 📝 `tests/boundary/process/electronLaunchRejections.test.ts` (+36 -0) 📝 `tests/boundary/providers/kuna/kunaProvider.test.ts` (+15 -4) </details> ### 📄 Description ## Problem and retained behavior The original package-main fix is already adopted on main with contributor credit retained. This PR keeps eight regression test files using the included main's production owners and cleanup contracts. Coverage retains unknown/ambiguous Unicode imports and six compiled CLI directory combinations; actual replacement MCP dispatch and concurrent shared-provider cleanup/retry; precise Kuna/Ghidra cancellation ownership; JEB isolation with required host tools; imported versus unrelated sibling identity; and overlapping Electron launch rejection handling. This revision normally merges main `3ddb2e4cf`. The one conflict was in the Electron launch test: main now asserts the public projected diagnostics, while this branch also checks the exact two ordered typed error children, primary cause reference and cleanup ownership. Both sets remain. Superseded duplicate display fields were removed. Listener/orphan counts, all five failed outcomes and the other launch controls remain. The other seven contributed files are byte-identical to `90fe97ef`. Production and documentation are identical to included main `3ddb2e4cf`. Fixes #3896 ## Verification Final head: `cbb26bc7794b268f50a5d36e5b750e8f67dd96d3` (parents `90fe97ef` and main `3ddb2e4cf`). - Fresh macOS arm64 / Node24.18.0: **22 focused files / 230 passed / no skips**, including all eight contribution files and relevant new main process-output/cache controls. Separate fresh README: **5 passed**; **23 distinct files / 235 passed** total. - `npm run check`, `npm run docs:check` and discovery passed. Module/architecture guards checked 2,063 / 1,494 sources; discovery found all 1,544 test files exactly once. - Independent frozen Standards/Spec review: **PASS**. Normal hooks/commit/push preserved all 4,274 raw inputs, five gitlinks and the reviewed tree. - Final-head [CI39054155583](https://github.com/morluto/rea/actions/runs/39054155583), attempt1: **SUCCESS**, 31 jobs: 11 succeeded / 20 conditional skips. All 2,233,145 bytes of logs and all 11 executing jobs' first own checkout payloads were verified: `7922229d`, parents main `3ad1032b` and final `cbb26bc7`. Portable **18,430 passed / 163 skipped** exactly aggregates source **9,681 passed / 8 skipped** and five shards; it is not an extra execution. All eight contribution files ran, including all 13 Electron launch tests. This is GitHub Linux portable execution; Windows, Apple, native-package, real-provider and Docs lanes were skipped. The later CI base is not the feature's included main, which remains `3ddb2e4cf`. Inherited main paths have not all received separate semantic certification. Controlled Playwright launches do not execute a real Electron application. Real browser/Electron qualification, native engines, native Linux/Windows, installed packages, target devices and performance remain unverified. Historical assertion failures and their diagnostic evidence are retained. Old generic Codex failures remain undiagnosed; no new-head Codex result is established. Local review, Actions, remote automated review and human readiness remain separate. ## Author readiness - [ ] I reviewed the final diff and relevant existing code, and I can explain the approach and tradeoffs. - [ ] I checked the evidence above, including its limitations and unverified coverage. - [ ] I declare this PR ready for initial maintainer review. ## Before merge - [ ] Required checks pass for this PR revision. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:10:54 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5978

No description provided.

Rows
Columns