[PR #3996] [CLOSED] fix(js): ignore unrelated join/resolve for Electron preload paths #5982

New issue

Closed

opened 2026-10-31 01:10:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:10:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/3996
Author: @maxiaochaos
Created: 10/15/2026
Status: ❌ Closed

Base: main ← Head: cursor/fix-unrelated-join-resolve-aeb9

📝 Commits (2)

2d1af40 fix(js): ignore unrelated join/resolve for Electron preload paths
553e360 fix(js): prove path.join via binding-aware intrinsic query

📊 Changes

3 files changed (+109 additions, -5 deletions)

View changed files

📝 src/domain/javascript/javascriptStaticAnalysisHelpers.ts (+4 -2)
📝 src/domain/javascript/javascriptStaticPathIntrinsics.ts (+9 -1)
📝 src/domain/javascript/javascriptStaticPathResolution.test.ts (+96 -2)

📄 Description

Only treat path.join / path.resolve (and posix variants) as filesystem path helpers. Custom .resolve(...) and array .join(...) stay unknown instead of fabricating preload paths like /b or /.

Genuine path.join(__dirname, …) / path.resolve still work.

Fixes #3962

Author readiness

Human owner: @maxiaochaos

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/3996 **Author:** [@maxiaochaos](https://github.com/maxiaochaos) **Created:** 10/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cursor/fix-unrelated-join-resolve-aeb9` --- ### 📝 Commits (2) - [`2d1af40`](https://github.com/morluto/rea/commit/2d1af4003c513d99aeb3d2e5aa87088e1fbf0ec5) fix(js): ignore unrelated join/resolve for Electron preload paths - [`553e360`](https://github.com/morluto/rea/commit/553e360033946fe08d9953b862f9c11fd7fa3a53) fix(js): prove path.join via binding-aware intrinsic query ### 📊 Changes **3 files changed** (+109 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptStaticAnalysisHelpers.ts` (+4 -2) 📝 `src/domain/javascript/javascriptStaticPathIntrinsics.ts` (+9 -1) 📝 `src/domain/javascript/javascriptStaticPathResolution.test.ts` (+96 -2) </details> ### 📄 Description Only treat `path.join` / `path.resolve` (and posix variants) as filesystem path helpers. Custom `.resolve(...)` and array `.join(...)` stay unknown instead of fabricating preload paths like `/b` or `/`. Genuine `path.join(__dirname, …)` / `path.resolve` still work. Fixes #3962 ## Author readiness Human owner: @maxiaochaos - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:10:56 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5982

No description provided.

Rows
Columns