[PR #4007] [CLOSED] fix: accept zero-length PE resources at section end #5987

New issue

Closed

opened 2026-10-31 01:10:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:10:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4007
Author: @Akashmdshetty
Created: 10/15/2026
Status: ❌ Closed

Base: main ← Head: fix/pe-zero-length-resource

📝 Commits (1)

cb08f9e fix: accept zero-length PE resources at section end

📊 Changes

2 files changed (+31 additions, -4 deletions)

View changed files

📝 src/native/pe/PeResourceLayout.ts (+11 -4)
📝 src/native/pe/PeResourceParser.test.ts (+20 -0)

📄 Description

Summary

Fixes #3970.

Allow zero-length PE resources whose RVA is exactly at the end of a section's virtual extent.
Preserve the existing section mapping and range validation for other resources.
Add a regression test for a zero-length resource at the section virtual boundary.

Testing

npm run test:local -- src/native/pe/PeResourceParser.test.ts — 25 tests passed.
npm run test:acceptance -- tests/acceptance/applications/peResources.test.ts --reporter=verbose --testTimeout=60000 — 1 test passed.
npm run check:fast — typecheck and lint passed during push.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4007 **Author:** [@Akashmdshetty](https://github.com/Akashmdshetty) **Created:** 10/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pe-zero-length-resource` --- ### 📝 Commits (1) - [`cb08f9e`](https://github.com/morluto/rea/commit/cb08f9e5d62dc7c5c186ed9ffa818cef5a3ca3e1) fix: accept zero-length PE resources at section end ### 📊 Changes **2 files changed** (+31 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/native/pe/PeResourceLayout.ts` (+11 -4) 📝 `src/native/pe/PeResourceParser.test.ts` (+20 -0) </details> ### 📄 Description ## Summary Fixes #3970. - Allow zero-length PE resources whose RVA is exactly at the end of a section's virtual extent. - Preserve the existing section mapping and range validation for other resources. - Add a regression test for a zero-length resource at the section virtual boundary. ## Testing - `npm run test:local -- src/native/pe/PeResourceParser.test.ts` — 25 tests passed. - `npm run test:acceptance -- tests/acceptance/applications/peResources.test.ts --reporter=verbose --testTimeout=60000` — 1 test passed. - `npm run check:fast` — typecheck and lint passed during push. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:10:59 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:45:52 +00:00

[PR #6151] [CLOSED] fix(cancellation): preserve the caller abort reason #7168

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5987

No description provided.

Rows
Columns