mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Open
opened 2026-10-31 01:11:05 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6002
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4031
Author: @jsk1004ha
Created: 10/15/2026
Status: 🔄 Open
Base:
main← Head:feat/artifact-selection-3490📝 Commits (8)
9c72458feat(artifacts): select extraction entries and output destination60c3c21fix(artifacts): omit absent selection from execution parameters5901a36fix(artifacts): protect source directories and verify public selection3d2920efix(artifacts): keep optional selection inputs JSON-safee23a802fix(artifacts): preserve selected occurrence and destination identity917730afix(artifacts): separate reader ownership from selected destinations92eb9a0fix(artifacts): sync extraction selection with current main204766dfix(artifacts): advertise absolute extraction destinations📊 Changes
13 files changed (+1099 additions, -57 deletions)
View changed files
📝
docs/mcp-contracts.md(+20 -0)📝
src/application/artifacts/ArtifactExtractionDestination.ts(+5 -3)📝
src/artifacts/ArtifactProvider.ts(+3 -0)📝
src/artifacts/extraction/ArtifactExtraction.ts(+59 -41)➕
src/artifacts/extraction/ArtifactExtractionSelection.ts(+77 -0)📝
src/cli/artifactCommands.ts(+18 -2)📝
src/contracts/artifactToolContracts.ts(+23 -5)📝
src/server/registerArtifactTools.ts(+12 -5)➕
tests/acceptance/artifactExtractionSelection.test.ts(+177 -0)📝
tests/boundary/mcp/absoluteLocalPathSchema.test.ts(+6 -0)📝
tests/boundary/mcp/unityFsMcp.test.ts(+13 -1)➕
tests/boundary/providers/native/artifactProvider.extractionDestination.test.ts(+61 -0)➕
tests/boundary/providers/native/artifactProvider.extractionSelection.test.ts(+625 -0)📄 Description
Summary
Fixes #3490.
extract_artifactcan now write to a caller-selected destination and extract only selected inventory occurrences. This lets a caller take a native library from an APK without materializing unrelated resources whose names collide on the destination filesystem. Omitting both options keeps the existing all-file extraction into a fresh temporary directory.Change and scope
The CLI accepts
--output-rootand repeatable--occurrence-idflags. MCP exposes the same options asoutput_rootandoccurrence_ids. Selection uses occurrence identity rather than content identity, so two paths with identical bytes can be selected independently.Selection is resolved against the active reader's complete inventory before output creation. Unknown, duplicate, empty, root, directory, link and nested-member selections are refused. Nested archive members remain outside this change: extract their containing archive and inspect it separately. No glob matching is added.
Full reader-inventory consistency checks are kept separate from materialization. Deliberately excluded files are not mistaken for missing entries, while unexpected or missing regular entries still prevent publication. Selected writes retain their expected hashes and lengths, and failures use the existing owned-output rollback.
A custom destination must be absolute, absent, and have an existing parent. Existing destinations are never overwritten. The resolved output parent is checked before creating the tree, preventing extraction into the source directory through either a direct path or a symlink alias. Successful output remains available after the operation and after closing the session.
Contract and boundary impact
ArtifactExtractionSelectionselects active occurrences;ArtifactExtractionverifies and materializes them.SafeOutputTreekeeps output ownership and cleanup.Expected effects:
The write effect is limited to extraction output and its cleanup. Target bytes are not modified.
Evidence and regression coverage
Added 19 tests across selection, destination protection and public CLI/MCP acceptance. Coverage includes identical-content occurrences, omitted selection, excluded case-distinct names, invalid IDs, request-order independence, nested-member refusal, existing destinations, cancellation, changed bytes and rollback, source-directory aliases, repeated CLI flags, CLI/MCP manifest parity, and output persistence after
close_binary.The original limitation is documented in #3490. Source inspection of base
6fcfc5b5confirms that the adapter chose the temporary root and exposed no occurrence selection. The original third-party APK and its Windows bind-mount reproduction were not independently rerun. The executed checks use self-generated archives and directories, including case-distinct resource names.The public acceptance test selects
lib/selected.soandlib/other.sofrom a ZIP that also containsres/2f.xmlandres/2F.xml. These are the result fields asserted by that passing CLI test, with its temporary directory abbreviated:The single-file CLI and stdio MCP calls return identical artifact lists and extraction manifests. The tests also check that no
resdirectory is materialized and that extracted files remain readable afterclose_binary.Validation performed
Verified source:
3d2920e2e4c9f31f1978015c8809b9071117a1b3.Linux and macOS verification run.
npm run test:focused --the 11 extraction, output-ownership and public-acceptance files listed in the run — 73 passed.npm run test:focused --the six selection, destination, extraction, archive-safety, output-tree and public-acceptance files listed in the run — 42 passed, 1 skipped.npm run check— passed, including type checking, lint, formatting, Knip, metadata and architecture checks. Existing repository lint warnings remain.npm run verify:test-discovery— passed.npm run docs:check— passed, including the generated catalog and five README consistency tests.Earlier iterations failed on optional-property typing and test/harness expectations; those were corrected before this verified revision. These results do not claim the full repository suite, real Windows coverage, or a performance improvement. Inventory still covers the complete input, so subset extraction is not a promise of proportionally lower inventory time or memory use.
Compatibility, safety, and release
No new dependency or migration is required. Caller-owned output is refused rather than replaced. Existing containment, integrity, cancellation and cleanup checks remain; the existing portable pathname-race limitation is unchanged. Nested extraction, wildcard selection and encrypted-entry recovery are not included.
Author readiness
Human owner: @jsk1004ha
Before merge
type(scope): outcome.Review fixes and validation — 2026-10-27
Synchronized with upstream
6749bd090and resolved all six conflicts. ZIP extraction now preserves ordered occurrence identity for duplicate paths, including selecting the second occurrence or excluding all duplicates; selecting conflicting output destinations is rejected before writing. Destination handling preserves symlink-sensitive parent traversal, rejects missing parents, and returns the actual canonical output root. Optional CLI fields now use the correct optional schema wrappers, and directory fixtures follow source admission requirements.Validation on the final synchronized tree:
npm run check:fast, build, formatting, and staged diff checks passed.action_required; test-job execution awaits workflow approval.Existing human declarations above are preserved.
Follow-up review fixes
Published
917730ac79e23113da8cb00f8723290e575917aaafter validating the fresh review findings:artifactMcpCallto discover and validate advertised public schemas.The final 57/57 focused cases passed: 10 extraction unit, 31 selection, 14 completeness, and 2 CLI/MCP acceptance cases. These include real PyInstaller/ASAR fixtures and excluded-entry missing/added/unsafe-path regressions.
npm run check:fast, formatting, and staged diff checks also passed. All three corresponding follow-up review threads are resolved; full upstream CI remains subject to workflow approval.Main synchronization and validation (2026-11-05)
Merged upstream
71f680d7c1aa7a45ba0325fe87b104744b0c105finto this branch as92eb9a05e02e2ff42409755c11e5792e9da82044. The extraction conflict is resolved while preserving occurrence selection, destination handling, and the upstream UnityFS/wxapkg directory-status refusals. UnityFS MCP now also verifies unsupported-layout extraction refusal and absence of the requested output directory under both schema profiles.Validation on the published tree, on Linux with Node 24.22.1 and the available npm 11.9.0 (the repository pins npm 11.16.0):
npm run docs:checkpassed, including 9 README consistency tests. Test discovery found all 3031 test files exactly once.npm run checkdid not finish successfully: its repository-wide typed-lint subprocess was terminated by SIGKILL. Earlier stages passed; the focused typed-lint rerun does not replace a full-repository pass.GitHub now reports the PR as conflict-free. CI, CodeQL, and PR title for this exact revision are
action_requiredand await upstream workflow approval. The complete test suite and Windows behavior were not rerun. Existing human declarations above are unchanged.Advertised extraction-path constraint
Follow-up commit
204766d9d7d1ea6a9cc142414b034ba409796ee0replaces the runtime-onlyisAbsoluterefinement with the sharedabsoluteLocalPathStringSchema. The runtime, CLI and SDK-converted MCP schema now share the host-absolute, nonempty and NUL-free constraint. The existing advertised-path/MCP-handler matrix now includesextract_artifact.output_root.The new advertised-schema assertion first reproduced the defect by accepting a relative output root, then passed after the fix. Final validation: 64/64 cases across 7 files,
npm run check:fast, runtime build, formatting, staged diff checks, andnpm run docs:checkincluding 9 README tests passed. Typed lint for the two follow-up files passed with 0 errors and 0 warnings. The earlier repository-wide typed-lint SIGKILL limitation remains; these results are focused checks, not the complete test suite.The published head remains conflict-free. Its CI, CodeQL, and PR-title run are still
action_required, awaiting upstream workflow approval.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.