[PR #4073] [MERGED] fix(adb): normalize absent installer package sentinels #6037

New issue

Closed

opened 2026-10-31 01:11:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:11:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4073
Author: @yankikucuk
Created: 10/15/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto

Base: main ← Head: fix/adb-package-null-installer

📝 Commits (4)

c4886e8 fix(adb): report a null installer declaration as an absent installer
70eb0e4 fix(adb): keep the null sentinel handling to the installer field
16171b3 Merge remote-tracking branch 'origin/main' into HEAD
6e31737 test(adb): establish permission inventory in null-installer fixture

📊 Changes

3 files changed (+85 additions, -1 deletions)

View changed files

📝 src/adb/AdbProvider.test.ts (+27 -0)
📝 src/adb/AdbShellOutput.test.ts (+46 -0)
📝 src/adb/AdbShellOutput.ts (+12 -1)

📄 Description

Summary

Treats absent installerPackageName sentinels from dumpsys as JSON null rather than the text "null". Sentinel interpretation belongs to the installer-field parser and is projected consistently through the provider.

The literal versionName="null" is preserved: it can be valid manifest data and is not an absence sentinel. The source and parser regression explicitly retain that distinction.

Validation and limits

On the current head with Node 24.18.0/npm 11.16.0, npm run test:local -- src/adb/AdbShellOutput.test.ts src/adb/AdbProvider.test.ts passed 111 tests (23 parser, 88 provider). These tests exercise representative dumpsys output and provider projection. No physical Android device was used in this verification pass.

Author readiness

Human owner: @yankikucuk

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4073 **Author:** [@yankikucuk](https://github.com/yankikucuk) **Created:** 10/15/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/adb-package-null-installer` --- ### 📝 Commits (4) - [`c4886e8`](https://github.com/morluto/rea/commit/c4886e845b3bd4510828d7bd7cacc181a24bc6bb) fix(adb): report a null installer declaration as an absent installer - [`70eb0e4`](https://github.com/morluto/rea/commit/70eb0e4eed8575dc88f084ed643096475082f7ce) fix(adb): keep the null sentinel handling to the installer field - [`16171b3`](https://github.com/morluto/rea/commit/16171b3c6e0ad5b9993cf947690e80d23d5b578d) Merge remote-tracking branch 'origin/main' into HEAD - [`6e31737`](https://github.com/morluto/rea/commit/6e31737d6e46e63f1b2c38fff471e79b27c25b1d) test(adb): establish permission inventory in null-installer fixture ### 📊 Changes **3 files changed** (+85 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/adb/AdbProvider.test.ts` (+27 -0) 📝 `src/adb/AdbShellOutput.test.ts` (+46 -0) 📝 `src/adb/AdbShellOutput.ts` (+12 -1) </details> ### 📄 Description ## Summary Treats absent installerPackageName sentinels from dumpsys as JSON null rather than the text `"null"`. Sentinel interpretation belongs to the installer-field parser and is projected consistently through the provider. The literal `versionName="null"` is preserved: it can be valid manifest data and is not an absence sentinel. The source and parser regression explicitly retain that distinction. ## Validation and limits On the current head with Node 24.18.0/npm 11.16.0, `npm run test:local -- src/adb/AdbShellOutput.test.ts src/adb/AdbProvider.test.ts` passed 111 tests (23 parser, 88 provider). These tests exercise representative dumpsys output and provider projection. No physical Android device was used in this verification pass. ## Author readiness Human owner: @yankikucuk - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:11:22 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6037

No description provided.

Rows
Columns