mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4103] [MERGED] fix(providers): report provider-selection diagnostics when the selected provider refuses its profile #6059
Closed
opened 2026-10-31 01:11:32 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6059
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4103
Author: @pablodiazjorge
Created: 10/15/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto
Base:
main← Head:fix/explicit-profile-refusal-selection-details📝 Commits (8)
6c61693fix(providers): report provider-selection diagnostics when the selected provider refuses its profile4539a85fix(providers): keep refusal evidence and cleanup ownership on selection failures43cec3cMerge upstream main into fix/explicit-profile-refusal-selection-details67cb026Merge upstream main into fix/explicit-profile-refusal-selection-details4a1103eMerge upstream main into fix/explicit-profile-refusal-selection-detailsdda7972Merge upstream main into fix/explicit-profile-refusal-selection-detailsa765200Merge upstream main into fix/explicit-profile-refusal-selection-details8db415fMerge upstream main into fix/explicit-profile-refusal-selection-details📊 Changes
6 files changed (+248 additions, -11 deletions)
View changed files
📝
src/application/binary/AnalysisProviderRegistry.test.ts(+68 -0)📝
src/application/binary/AnalysisProviderRegistry.ts(+37 -3)📝
src/domain/analysisErrorPresentation.ts(+5 -0)📝
src/domain/analysisErrorProjection.test.ts(+26 -0)📝
src/domain/providerSelectionError.ts(+16 -8)➕
tests/boundary/mcp/ghidraProfileRefusalMcp.test.ts(+96 -0)📄 Description
Summary
Fixes #3930. When a provider is selected explicitly and then refuses the target while resolving its analysis profile,
open_binaryreturned the raw refusal (unsupported_target, operationresolve_analysis_profile) and dropped the provider-selection diagnostics that every other unsupported selection carries:selection_reason,requested_provider_id,candidate_idsandrejections. The evaluation already records that refusal as the candidate's target rejection (AnalysisProviderEvaluation.ts), but#selectConcretereturned the profile error before building the selection error (AnalysisProviderRegistry.ts). Now an unsupported-target refusal becomes thetarget_unsupportedselection error with the updated candidate statuses, and it keeps the refusal's own message and, when the provider gives one, its specific recovery.Problem and expected behavior
Smallest trigger, from the issue: explicit
provider_id: "ghidra"withREA_GHIDRA_LANGUAGE_IDset, opening a raw ARM binary. On main the MCP error isunsupported_targetwith reasonREA_GHIDRA_LANGUAGE_ID cannot override the admitted raw-binary import.and no selection details. Expected, as the issue asks:capability_unavailablewithdetails.selection_reason: "target_unsupported",requested_provider_id: "ghidra", the candidate IDs and the provider's rejection, with the refusal reason still visible.Change and scope
src/application/binary/AnalysisProviderRegistry.ts: in explicit selection, anAnalysisUnsupportedTargetErrorfrom profile resolution returnsselectionError("target_unsupported", …)built from the evaluated statuses, whose rejection already holds the refusal reason (code: "target_format_unsupported"). ItsuserMessageis the refusal's message, so callers read the same text as before; its recovery is the refusal'sremediationActionwhen there is one; and it carries the refusal's captured output, diagnostics and partial observation, with the refusal as itscause. A refusal with unconfirmed cleanup is returned unchanged, so it still projects ascleanup_incompletewith its resources, as automatic selection already does. Other profile errors (adapter errors) are returned unchanged.src/domain/providerSelectionError.ts: an optionalremediationAction, asAnalysisUnsupportedTargetErroralready has, and the sharedcause,diagnosticsandpartialObservationoptions passed to the base error alongsidecapturedOutput.src/domain/analysisErrorPresentation.ts: a selection error withremediationActionuses it asremediation.action; without it, the action stays the user message, as before.Keeping the refusal's recovery matters for the refusals that know a specific fix: for example, the NativeAOT extension refusals tell the caller to omit
REA_GHIDRA_NATIVEAOT_JAR, and the generic "choose another provider" guidance alone would point the wrong way.Automatic selection is unchanged; it already folds profile refusals into its selection result.
Contribution scope: not applicable (error reporting of an existing selection path).
Contract and boundary impact
AnalysisProviderRegistry.capability_unavailablewith selection details instead ofunsupported_target; the message is unchanged.docs/public/product-catalog.json), package, or installation impact: none.Expected effects:
Evidence and regression coverage
tests/boundary/mcp/ghidraProfileRefusalMcp.test.ts: the issue's case through the publicopen_binaryMCP tool with the production Ghidra provider and a simulated installation. The refusal returnscapability_unavailablewithselection_reason,requested_provider_id,candidate_idsand a rejection whose reason is the refusal text, without starting an engine; the same raw input without the override still opens. With main's registry the first test fails withunsupported_target.src/application/binary/AnalysisProviderRegistry.test.ts, in its own block: an explicit refusal with a recovery, captured output and diagnostics keeps all three, its reason and the refusal ascauseon the selection failure; a refusal with unconfirmed cleanup is returned unchanged and projectscleanup_incomplete. Removing the recovery copy or the cleanup guard makes the matching test fail.src/domain/analysisErrorProjection.test.ts: a selection error keeps a supplied recovery asremediation.actionand otherwise falls back to its message.For evidence-bearing changes:
Validation performed
Windows 11 x64 (10.0.26300), Node 24.18.0, branch based on
8ed3d1df7.npx vitest run src/application/binary/AnalysisProviderRegistry.test.ts tests/boundary/mcp/ghidraProfileRefusalMcp.test.ts src/domain/analysisErrorProjection.test.ts: 68 passed.AnalysisProviderRegistry.ts: the refusal case failed withunsupported_target, as expected.npm run build:cachedandnpm run test:prepare, the 20 test files that reference provider selection or its errors: 124 passed, 2 failures,ghidraInventoryMcp(byte search) andBinarySessionLiveness(cancelled-switch restoration, 30 s timeout). Both fail identically with main's code on this host.npm run check:fast: passed.npx oxfmt --checkon the changed files: passed.Compatibility, safety, and release
unsupported_targetfor an explicitly selected provider's profile refusal now receivecapability_unavailablewith selection details, the same code other unsupported selections already use.Author readiness
Human owner: @pablodiazjorge
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.